Created
August 11, 2016 16:00
-
-
Save bneiluj/75c6aba659518ad30cc8b8718a1ef88c to your computer and use it in GitHub Desktop.
An Ethereum simple auction contract that everyone can send their bids during a bidding period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contract SimpleAuction { | |
// Parameters of the auction. Times are either | |
// absolute unix timestamps (seconds since 1970-01-01) | |
// or time periods in seconds. | |
address public beneficiary; | |
uint public auctionStart; | |
uint public biddingTime; | |
// Current state of the auction. | |
address public highestBidder; | |
uint public highestBid; | |
// Allowed withdrawals of previous bids | |
mapping(address => uint) pendingReturns; | |
// Set to true at the end, disallows any change | |
bool ended; | |
// Events that will be fired on changes. | |
event HighestBidIncreased(address bidder, uint amount); | |
event AuctionEnded(address winner, uint amount); | |
// The following is a so-called natspec comment, | |
// recognizable by the three slashes. | |
// It will be shown when the user is asked to | |
// confirm a transaction. | |
/// Create a simple auction with `_biddingTime` | |
/// seconds bidding time on behalf of the | |
/// beneficiary address `_beneficiary`. | |
function SimpleAuction( | |
uint _biddingTime, | |
address _beneficiary | |
) { | |
beneficiary = _beneficiary; | |
auctionStart = now; | |
biddingTime = _biddingTime; | |
} | |
/// Bid on the auction with the value sent | |
/// together with this transaction. | |
/// The value will only be refunded if the | |
/// auction is not won. | |
function bid() { | |
// No arguments are necessary, all | |
// information is already part of | |
// the transaction. | |
if (now > auctionStart + biddingTime) { | |
// Revert the call if the bidding | |
// period is over. | |
throw; | |
} | |
if (msg.value <= highestBid) { | |
// If the bid is not higher, send the | |
// money back. | |
throw; | |
} | |
if (highestBidder != 0) { | |
// Sending back the money by simply using | |
// highestBidder.send(highestBid) is a security risk | |
// because it can be prevented by the caller by e.g. | |
// raising the call stack to 1023. It is always safer | |
// to let the recipient withdraw their money themselves. | |
pendingReturns[highestBidder] += highestBid; | |
} | |
highestBidder = msg.sender; | |
highestBid = msg.value; | |
HighestBidIncreased(msg.sender, msg.value); | |
} | |
/// Withdraw a bid that was overbid. | |
function withdraw() { | |
var amount = pendingReturns[msg.sender]; | |
// It is important to set this to zero because the recipient | |
// can call this function again as part of the receiving call | |
// before `send` returns. | |
pendingReturns[msg.sender] = 0; | |
if (!msg.sender.send(amount)) | |
throw; // If anything fails, this will revert the changes above | |
} | |
/// End the auction and send the highest bid | |
/// to the beneficiary. | |
function auctionEnd() { | |
// It is a good guideline to structure functions that interact | |
// with other contracts (i.e. they call functions or send Ether) | |
// into three phases: | |
// 1. checking conditions | |
// 2. performing actions (potentially changing conditions) | |
// 3. interacting with other contracts | |
// If these phases are mixed up, the other contract could call | |
// back into the current contract and modify the state or cause | |
// effects (ether payout) to be perfromed multiple times. | |
// If functions called internally include interaction with external | |
// contracts, they also have to be considered interaction with | |
// external contracts. | |
// 1. Conditions | |
if (now <= auctionStart + biddingTime) | |
throw; // auction did not yet end | |
if (ended) | |
throw; // this function has already been called | |
// 2. Effects | |
ended = true; | |
AuctionEnded(highestBidder, highestBid); | |
// 3. Interaction | |
if (!beneficiary.send(highestBid)) | |
throw; | |
} | |
function () { | |
// This function gets executed if a | |
// transaction with invalid data is sent to | |
// the contract or just ether without data. | |
// We revert the send so that no-one | |
// accidentally loses money when using the | |
// contract. | |
throw; | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment