Skip to content

Instantly share code, notes, and snippets.

@bobtfish
Created October 13, 2009 16:54
Show Gist options
  • Select an option

  • Save bobtfish/209364 to your computer and use it in GitHub Desktop.

Select an option

Save bobtfish/209364 to your computer and use it in GitHub Desktop.
Things which suck about credential::openid:
Important:
. new method is EVIL - grabs config out of the realm's internals. This needs fixing with back compat so that it'll do that IF NEEDED and warn.. This MUST be fixed..
Unimportant:
. errors_are_fatal - appears not to be used all the places it should be? Why not have a _throw_error method which does the right thing depending on config setting?
. Docs show use of flash, nasty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment