Skip to content

Instantly share code, notes, and snippets.

@bonnieking

bonnieking/bbb rcn bb-kernel am33x-v3.8

Last active November 2, 2015 05:38
Show Gist options
  • Save bonnieking/c2a312bba6384b366170 to your computer and use it in GitHub Desktop.
Save bonnieking/c2a312bba6384b366170 to your computer and use it in GitHub Desktop.
Download ZIP
bbb rcn bb-kernel am33x-v3.8
Raw
bbb rcn bb-kernel am33x-v3.8
#################################################################
[bonniek@featherfall bb-kernel]$ git checkout am33x-v3.8
Already on 'am33x-v3.8'
Your branch is up-to-date with 'origin/am33x-v3.8'.
[bonniek@featherfall bb-kernel]$
[bonniek@featherfall bb-kernel]$ ./build_kernel.sh
+ Detected build host ["Fedora release 22 (Twenty Two)"]
+ host: [x86_64]
+ git HEAD commit: [a50680ea2cc2fc4519353dee4c1cbb47e475d8b2]
RPM distro version: [22]
Red Hat, or derivatives: missing dependencies, please install:
-----------------------------
dnf install ncurses-devel ncurses-devel.x86_64 ncurses-devel.i686
-----------------------------
* Failed dependency check
[bonniek@featherfall bb-kernel]$ dnf install ncurses-devel ncurses-devel.x86_64 ncurses-devel.i686
Error: This command has to be run under the root user.
[bonniek@featherfall bb-kernel]$ sudo dnf install ncurses-devel ncurses-devel.x86_64 ncurses-devel.i686
[sudo] password for bonniek:
Last metadata expiration check performed 2:29:38 ago on Sat Oct 31 08:49:45 2015.
Dependencies resolved.
=============================================================================================================================================================================
Package Arch Version Repository Size
=============================================================================================================================================================================
Installing:
ncurses-devel i686 5.9-18.20150214.fc22 fedora 731 k
ncurses-devel x86_64 5.9-18.20150214.fc22 fedora 731 k
Removing:
kernel x86_64 3.14.27-100.fc19 @System 135 M
Transaction Summary
=============================================================================================================================================================================
Install 2 Packages
Remove 1 Package
Total download size: 1.4 M
Is this ok [y/N]: y
Downloading Packages:
(1/2): ncurses-devel-5.9-18.20150214.fc22.x86_64.rpm 399 kB/s | 731 kB 00:01
(2/2): ncurses-devel-5.9-18.20150214.fc22.i686.rpm 343 kB/s | 731 kB 00:02
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total 521 kB/s | 1.4 MB 00:02
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
Installing : ncurses-devel-5.9-18.20150214.fc22.i686 1/3
Installing : ncurses-devel-5.9-18.20150214.fc22.x86_64 2/3
Erasing : kernel-3.14.27-100.fc19.x86_64 3/3
Verifying : ncurses-devel-5.9-18.20150214.fc22.x86_64 1/3
Verifying : ncurses-devel-5.9-18.20150214.fc22.i686 2/3
Verifying : kernel-3.14.27-100.fc19.x86_64 3/3
Removed:
kernel.x86_64 3.14.27-100.fc19
Installed:
ncurses-devel.i686 5.9-18.20150214.fc22 ncurses-devel.x86_64 5.9-18.20150214.fc22
Complete!
[bonniek@featherfall bb-kernel]$
####################################################
[bonniek@featherfall bb-kernel]$ ./build_kernel.sh
LD [M] sound/usb/6fire/snd-usb-6fire.ko
LD [M] sound/usb/misc/snd-ua101.ko
LD [M] sound/usb/snd-usb-audio.ko
LD [M] sound/usb/snd-usbmidi-lib.ko
IHEX2FW firmware/emi26/loader.fw
IHEX2FW firmware/emi26/firmware.fw
IHEX2FW firmware/emi26/bitstream.fw
IHEX2FW firmware/emi62/loader.fw
IHEX2FW firmware/emi62/bitstream.fw
IHEX2FW firmware/emi62/spdif.fw
IHEX2FW firmware/emi62/midi.fw
IHEX firmware/kaweth/new_code.bin
IHEX firmware/kaweth/trigger_code.bin
IHEX firmware/kaweth/new_code_fix.bin
IHEX firmware/kaweth/trigger_code_fix.bin
IHEX firmware/ti_3410.fw
IHEX firmware/ti_5052.fw
IHEX firmware/mts_cdma.fw
IHEX firmware/mts_gsm.fw
IHEX firmware/mts_edge.fw
H16TOFW firmware/edgeport/boot.fw
H16TOFW firmware/edgeport/down2.fw
H16TOFW firmware/edgeport/down.fw
H16TOFW firmware/edgeport/boot2.fw
IHEX firmware/edgeport/down3.bin
IHEX2FW firmware/whiteheat_loader.fw
IHEX2FW firmware/whiteheat.fw
IHEX2FW firmware/keyspan_pda/xircom_pgs.fw
IHEX2FW firmware/keyspan_pda/keyspan_pda.fw
IHEX firmware/cpia2/stv0672_vp4.bin
IHEX firmware/yam/1200.bin
IHEX firmware/yam/9600.bin
-----------------------------
make -j4 ARCH=arm LOCALVERSION=-bone79 CROSS_COMPILE="ccache /home/bonniek/drew/bbb/bb-kernel/dl/gcc-linaro-arm-linux-gnueabihf-4.7-2013.04-20130415_linux/bin/arm-linux-gnueabihf-" dtbs
-----------------------------
DTC arch/arm/boot/dts/omap2420-h4.dtb
DTC arch/arm/boot/dts/omap3-beagle.dtb
DTC arch/arm/boot/dts/omap3-evm.dtb
DTC arch/arm/boot/dts/omap3-beagle-xm.dtb
DTC arch/arm/boot/dts/omap3-tobi.dtb
DTC arch/arm/boot/dts/omap4-panda.dtb
DTC arch/arm/boot/dts/omap4-panda-a4.dtb
DTC arch/arm/boot/dts/omap4-panda-es.dtb
DTC arch/arm/boot/dts/omap4-var-som.dtb
DTC arch/arm/boot/dts/omap4-sdp.dtb
DTC arch/arm/boot/dts/omap5-evm.dtb
DTC arch/arm/boot/dts/am335x-evm.dtb
DTC arch/arm/boot/dts/am335x-evmsk.dtb
DTC arch/arm/boot/dts/am335x-bone.dtb
DTC arch/arm/boot/dts/am335x-boneblack.dtb
DTC arch/arm/boot/dts/am335x-bonegreen.dtb
DTC arch/arm/boot/dts/arduino-tre.dtb
DTC arch/arm/boot/dts/am335x-tester.dtb
-----------------------------
‘arch/arm/boot/zImage’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79.zImage’
‘.config’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/config-3.8.13-bone79’
-rwxrwxr-x 1 bonniek bonniek 5.3M Oct 31 12:11 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79.zImage
-----------------------------
Building modules archive...
Compressing 3.8.13-bone79-modules.tar.gz...
-rw-rw-r-- 1 bonniek bonniek 12M Oct 31 12:11 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79-modules.tar.gz
-----------------------------
Building firmware archive...
Compressing 3.8.13-bone79-firmware.tar.gz...
-rw-rw-r-- 1 bonniek bonniek 1.3M Oct 31 12:11 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79-firmware.tar.gz
-----------------------------
Building dtbs archive...
‘./arch/arm/boot/dts/omap4-panda.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-panda.dtb’
‘./arch/arm/boot/dts/am335x-boneblack.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-boneblack.dtb’
‘./arch/arm/boot/dts/omap3-evm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-evm.dtb’
‘./arch/arm/boot/dts/omap4-panda-a4.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-panda-a4.dtb’
‘./arch/arm/boot/dts/omap4-sdp.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-sdp.dtb’
‘./arch/arm/boot/dts/am335x-evmsk.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-evmsk.dtb’
‘./arch/arm/boot/dts/arduino-tre.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/arduino-tre.dtb’
‘./arch/arm/boot/dts/omap4-var-som.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-var-som.dtb’
‘./arch/arm/boot/dts/am335x-bone.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-bone.dtb’
‘./arch/arm/boot/dts/am335x-tester.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-tester.dtb’
‘./arch/arm/boot/dts/omap4-panda-es.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-panda-es.dtb’
‘./arch/arm/boot/dts/omap3-beagle-xm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-beagle-xm.dtb’
‘./arch/arm/boot/dts/am335x-evm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-evm.dtb’
‘./arch/arm/boot/dts/omap3-tobi.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-tobi.dtb’
‘./arch/arm/boot/dts/omap3-beagle.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-beagle.dtb’
‘./arch/arm/boot/dts/omap5-evm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap5-evm.dtb’
‘./arch/arm/boot/dts/am335x-bonegreen.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-bonegreen.dtb’
‘./arch/arm/boot/dts/omap2420-h4.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap2420-h4.dtb’
Compressing 3.8.13-bone79-dtbs.tar.gz...
-rw-rw-r-- 1 bonniek bonniek 39K Oct 31 12:11 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79-dtbs.tar.gz
-----------------------------
Script Complete
eewiki.net: [user@localhost:~$ export kernel_version=3.8.13-bone79]
-----------------------------
[bonniek@featherfall bb-kernel]$
#######################################################
[bonniek@featherfall bb-kernel]$ ./tools/rebuild.sh
+ Detected build host ["Fedora release 22 (Twenty Two)"]
+ host: [x86_64]
+ git HEAD commit: [a50680ea2cc2fc4519353dee4c1cbb47e475d8b2]
RPM distro version: [22]
-----------------------------
scripts/gcc: Using: arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.7-2013.04-20130415 - Linaro GCC 2013.04) 4.7.3 20130328 (prerelease)
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
-----------------------------
CROSS_COMPILE=/home/bonniek/drew/bbb/bb-kernel/dl/gcc-linaro-arm-linux-gnueabihf-4.7-2013.04-20130415_linux/bin/arm-linux-gnueabihf-
ccache [enabled]
scripts/kconfig/mconf Kconfig
drivers/video/Kconfig:60:error: recursive dependency detected!
drivers/video/Kconfig:60: symbol FB is selected by DRM_KMS_HELPER
drivers/gpu/drm/Kconfig:28: symbol DRM_KMS_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1: symbol DRM_TILCDC depends on BACKLIGHT_LCD_SUPPORT
drivers/video/backlight/Kconfig:5: symbol BACKLIGHT_LCD_SUPPORT is selected by FB_BACKLIGHT
drivers/video/Kconfig:247: symbol FB_BACKLIGHT is selected by PMAC_BACKLIGHT
drivers/macintosh/Kconfig:134: symbol PMAC_BACKLIGHT depends on FB
warning: (USB_MUSB_HDRC) selects TWL6030_USB which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET) && TWL4030_CORE && OMAP_USB2 && USB_MUSB_OMAP2PLUS)
warning: (DVB_USB_PCTV452E) selects TTPCI_EEPROM which has unmet direct dependencies (MEDIA_SUPPORT && MEDIA_PCI_SUPPORT && MEDIA_DIGITAL_TV_SUPPORT && I2C)
*** End of the configuration.
*** Execute 'make' to start the build or try 'make help'.
‘.config’ -> ‘/home/bonniek/drew/bbb/bb-kernel/patches/defconfig’
-----------------------------
make -j4 ARCH=arm LOCALVERSION=-bone79 CROSS_COMPILE="ccache /home/bonniek/drew/bbb/bb-kernel/dl/gcc-linaro-arm-linux-gnueabihf-4.7-2013.04-20130415_linux/bin/arm-linux-gnueabihf-" zImage modules
-----------------------------
scripts/kconfig/conf --silentoldconfig Kconfig
drivers/video/Kconfig:60:error: recursive dependency detected!
drivers/video/Kconfig:60: symbol FB is selected by DRM_KMS_HELPER
drivers/gpu/drm/Kconfig:28: symbol DRM_KMS_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1: symbol DRM_TILCDC depends on BACKLIGHT_LCD_SUPPORT
drivers/video/backlight/Kconfig:5: symbol BACKLIGHT_LCD_SUPPORT is selected by FB_BACKLIGHT
drivers/video/Kconfig:247: symbol FB_BACKLIGHT is selected by PMAC_BACKLIGHT
drivers/macintosh/Kconfig:134: symbol PMAC_BACKLIGHT depends on FB
warning: (USB_MUSB_HDRC) selects TWL6030_USB which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET) && TWL4030_CORE && OMAP_USB2 && USB_MUSB_OMAP2PLUS)
warning: (DVB_USB_PCTV452E) selects TTPCI_EEPROM which has unmet direct dependencies (MEDIA_SUPPORT && MEDIA_PCI_SUPPORT && MEDIA_DIGITAL_TV_SUPPORT && I2C)
warning: (USB_MUSB_HDRC) selects TWL6030_USB which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET) && TWL4030_CORE && OMAP_USB2 && USB_MUSB_OMAP2PLUS)
warning: (DVB_USB_PCTV452E) selects TTPCI_EEPROM which has unmet direct dependencies (MEDIA_SUPPORT && MEDIA_PCI_SUPPORT && MEDIA_DIGITAL_TV_SUPPORT && I2C)
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
make[1]: 'include/generated/mach-types.h' is up to date.
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CC kernel/printk.o
GZIP kernel/config_data.gz
CHK kernel/config_data.h
UPD kernel/config_data.h
CC kernel/configs.o
LD kernel/built-in.o
CC drivers/spi/spi.o
CC drivers/spi/spidev.o
CC drivers/spi/spi-omap2-mcspi.o
CC [M] drivers/spi/spi-sc18is602.o
CC [M] drivers/spi/spi-xcomm.o
LD drivers/spi/built-in.o
LD drivers/built-in.o
LINK vmlinux
LD vmlinux.o
MODPOST vmlinux.o
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
GEN .version
CHK include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
KSYM .tmp_kallsyms1.o
KSYM .tmp_kallsyms2.o
LD vmlinux
SORTEX vmlinux
sort done marker at 8100c8
SYSMAP System.map
OBJCOPY arch/arm/boot/Image
Building modules, stage 2.
Kernel: arch/arm/boot/Image is ready
LZO arch/arm/boot/compressed/piggy.lzo
MODPOST 1281 modules
AS arch/arm/boot/compressed/piggy.lzo.o
LD arch/arm/boot/compressed/vmlinux
OBJCOPY arch/arm/boot/zImage
Kernel: arch/arm/boot/zImage is ready
LD [M] drivers/spi/spi-sc18is602.ko
LD [M] drivers/spi/spi-xcomm.ko
-----------------------------
make -j4 ARCH=arm LOCALVERSION=-bone79 CROSS_COMPILE="ccache /home/bonniek/drew/bbb/bb-kernel/dl/gcc-linaro-arm-linux-gnueabihf-4.7-2013.04-20130415_linux/bin/arm-linux-gnueabihf-" dtbs
-----------------------------
-----------------------------
‘arch/arm/boot/zImage’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79.zImage’
‘.config’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/config-3.8.13-bone79’
-rwxrwxr-x 1 bonniek bonniek 5.3M Oct 31 12:40 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79.zImage
-----------------------------
Building modules archive...
Compressing 3.8.13-bone79-modules.tar.gz...
-rw-rw-r-- 1 bonniek bonniek 12M Oct 31 12:41 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79-modules.tar.gz
-----------------------------
Building firmware archive...
Compressing 3.8.13-bone79-firmware.tar.gz...
-rw-rw-r-- 1 bonniek bonniek 1.3M Oct 31 12:41 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79-firmware.tar.gz
-----------------------------
Building dtbs archive...
‘./arch/arm/boot/dts/omap4-panda.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-panda.dtb’
‘./arch/arm/boot/dts/am335x-boneblack.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-boneblack.dtb’
‘./arch/arm/boot/dts/omap3-evm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-evm.dtb’
‘./arch/arm/boot/dts/omap4-panda-a4.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-panda-a4.dtb’
‘./arch/arm/boot/dts/omap4-sdp.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-sdp.dtb’
‘./arch/arm/boot/dts/am335x-evmsk.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-evmsk.dtb’
‘./arch/arm/boot/dts/arduino-tre.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/arduino-tre.dtb’
‘./arch/arm/boot/dts/omap4-var-som.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-var-som.dtb’
‘./arch/arm/boot/dts/am335x-bone.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-bone.dtb’
‘./arch/arm/boot/dts/am335x-tester.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-tester.dtb’
‘./arch/arm/boot/dts/omap4-panda-es.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap4-panda-es.dtb’
‘./arch/arm/boot/dts/omap3-beagle-xm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-beagle-xm.dtb’
‘./arch/arm/boot/dts/am335x-evm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-evm.dtb’
‘./arch/arm/boot/dts/omap3-tobi.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-tobi.dtb’
‘./arch/arm/boot/dts/omap3-beagle.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap3-beagle.dtb’
‘./arch/arm/boot/dts/omap5-evm.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap5-evm.dtb’
‘./arch/arm/boot/dts/am335x-bonegreen.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/am335x-bonegreen.dtb’
‘./arch/arm/boot/dts/omap2420-h4.dtb’ -> ‘/home/bonniek/drew/bbb/bb-kernel/deploy/tmp/omap2420-h4.dtb’
Compressing 3.8.13-bone79-dtbs.tar.gz...
-rw-rw-r-- 1 bonniek bonniek 39K Oct 31 12:41 /home/bonniek/drew/bbb/bb-kernel/deploy/3.8.13-bone79-dtbs.tar.gz
-----------------------------
Script Complete
eewiki.net: [user@localhost:~$ export kernel_version=3.8.13-bone79]
-----------------------------
##############################################################
[bonniek@featherfall video]$ git clone https://github.com/notro/fbtft
Cloning into 'fbtft'...
remote: Counting objects: 1170, done.
remote: Total 1170 (delta 0), reused 0 (delta 0), pack-reused 1170
Receiving objects: 100% (1170/1170), 526.16 KiB | 0 bytes/s, done.
Resolving deltas: 100% (726/726), done.
Checking connectivity... done.
[bonniek@featherfall video]$ pwd
/home/bonniek/drew/bbb/bb-kernel/KERNEL/drivers/video
[bonniek@featherfall video]$ git diff
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index a0c757a..50c5d62 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2494,4 +2494,6 @@ config FB_SSD1307
This driver implements support for the Solomon SSD1307
OLED controller over I2C.
+source "drivers/video/fbtft/Kconfig"
+
endmenu
diff --git a/drivers/video/Makefile b/drivers/video/Makefile
index 28bfbca..6bd03af 100644
--- a/drivers/video/Makefile
+++ b/drivers/video/Makefile
@@ -174,3 +174,6 @@ obj-$(CONFIG_DISPLAY_TIMING) += display_timing.o
obj-$(CONFIG_OF_DISPLAY_TIMING) += of_display_timing.o
obj-$(CONFIG_VIDEOMODE) += videomode.o
obj-$(CONFIG_OF_VIDEOMODE) += of_videomode.o
+
+obj-y += fbtft/
+
[bonniek@featherfall video]$
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment