Skip to content

Instantly share code, notes, and snippets.

@brgnepal
Last active January 29, 2018 09:13
Show Gist options
  • Save brgnepal/fd669e817ab0297b9c814be2f6fc2a18 to your computer and use it in GitHub Desktop.
Save brgnepal/fd669e817ab0297b9c814be2f6fc2a18 to your computer and use it in GitHub Desktop.
Git diff go vet changes
diff --git a/pkg/minishift/addon/manager/addon_manager_test.go b/pkg/minishift/addon/manager/addon_manager_test.go
index 9bc8f20c..d40a0f57 100644
--- a/pkg/minishift/addon/manager/addon_manager_test.go
+++ b/pkg/minishift/addon/manager/addon_manager_test.go
@@ -44,7 +44,7 @@ func Test_creating_addon_manager_for_non_existing_directory_returns_an_error(t *
path := filepath.Join("this", "path", "really", "should", "not", "exists", "unless", "you", "have", "a", "crazy", "setup")
_, err := NewAddOnManager(path, make(map[string]*addon.AddOnConfig))
- assert.Error(t, err, "Creating the manager in directory '%s' should have failed", path)
+ assert.Error(t, err, fmt.Sprintf("Creating the manager in directory '%s' should have failed", path))
assert.Regexp(t, "^Unable to create addon manager", err.Error(), "Unexpected error message '%s'", err)
}
diff --git a/pkg/minishift/config/validations_test.go b/pkg/minishift/config/validations_test.go
index 82eb13a6..0ca477a0 100644
--- a/pkg/minishift/config/validations_test.go
+++ b/pkg/minishift/config/validations_test.go
@@ -19,6 +19,7 @@ package config
import (
"testing"
+ "fmt"
"github.com/stretchr/testify/assert"
)
@@ -31,10 +32,10 @@ func runValidations(t *testing.T, tests []validationTest, name string, f func(st
for _, tt := range tests {
err := f(name, tt.value)
if !tt.shouldErr {
- assert.NoError(t, err, "Error for testcase %v", tt)
+ assert.NoError(t, err, fmt.Sprintf("Error for testcase %v", tt))
}
if tt.shouldErr {
- assert.Error(t, err, "Error for testcase %v", tt)
+ assert.Error(t, err, fmt.Sprintf("Error for testcase %v", tt))
}
}
}
# My executions
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
pkg/minishift/addon/manager/addon_manager_test.go:47: possible formatting directive in Error call
exit status 1
pkg/minishift/config/validations_test.go:37: possible formatting directive in Error call
exit status 1
make: *** [Makefile:229: vet] Error 1
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
pkg/minishift/addon/manager/addon_manager_test.go:47: possible formatting directive in Error call
exit status 1
pkg/minishift/config/validations_test.go:37: possible formatting directive in Error call
exit status 1
make: *** [Makefile:229: vet] Error 1
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
pkg/minishift/addon/manager/addon_manager_test.go:47: possible formatting directive in Error call
exit status 1
pkg/minishift/config/validations_test.go:37: possible formatting directive in Error call
exit status 1
make: *** [Makefile:229: vet] Error 1
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
pkg/minishift/addon/manager/addon_manager_test.go:47: possible formatting directive in Error call
exit status 1
pkg/minishift/config/validations_test.go:37: possible formatting directive in Error call
exit status 1
make: *** [Makefile:229: vet] Error 1
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
pkg/minishift/addon/manager/addon_manager_test.go:47: possible formatting directive in Error call
exit status 1
pkg/minishift/config/validations_test.go:37: possible formatting directive in Error call
exit status 1
make: *** [Makefile:229: vet] Error 1
################## Updated addon_manager_test.go file
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
pkg/minishift/config/validations_test.go:37: possible formatting directive in Error call
exit status 1
make: *** [Makefile:229: vet] Error 1
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
pkg/minishift/config/validations_test.go
make: *** [Makefile:233: fmtcheck] Error 1
$ make fmt
pkg/minishift/config/validations_test.go
$ make prerelease
rm -rf /home/budhram/gowork/pkg/linux_amd64/github.com/minishift
rm -rf out
rm -rf release
rm -rf vendor
rm -f docs/source/_tmp/*.md
dep ensure -v
[-------- Working --------------]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment