Created
February 19, 2021 17:41
-
-
Save brian-lim-42/dbe9793caf7871d3f274526974aef95e to your computer and use it in GitHub Desktop.
Code Review 2020-02-19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Overall Comments | |
| * Difficult to understand logic | |
| * Magic numbers | |
| * Consider rewriting with functional programming and not object oriented | |
| Line by Line | |
| * code style line 1 - Order of imports… most significant first | |
| * code style line 10 - export session query for unit tests | |
| * implementation line 24 - why is it a different code path for dev? | |
| * implementation line 32-34 - why are these numbers not configurable? (hardcoded magic numbers) | |
| * implementation line 36 - why use object oriented? | |
| * implementation line 46 - 250ms is incorrect (Material-UI is 300ms for transitions) | |
| * line 61 - good comment | |
| * line 85 - instead of “0” should check for true/false or greater than less than (difficult to grok logic) | |
| * line 100 - difficult to grok logic | |
| * line 159 and line 171 - determine if possible to fix/remove these comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment