Code Review Task

README.md

Code Review Task

This source code (Javascript ES6) implements a class designed to analyse people’s hobbies based upon their age. The data is stored in a database and is retrieved by the class using the Database.GetPeople method. Each person’s name, age and hobbies are stored in an instance of the Person class.

The FindPeople method has two purposes:

• Find the average age of all people who play ball sports. In this exercise “ball sports” is taken to include football and rugby.
• Find if any person exists whose only hobby is football and who is aged under five or over 70.

Your task is to identify and comment on as many of these issues as you can in 20 minutes.

source.js

import {
    Database
} from './database.mjs';
import fs from 'fs';

class Class1 {

    constructor(name, age, hobbies) {
        this.Name = name,
            this.Age = age,
            this.#m_Hobies = hobbies
    }

    Name;
    Age;

    #m_Hobies;

    getHobbies = () => {
        return this.#m_Hobies;
    };

    setHobbies(hobbies) {
        this.#m_Hobies |= hobbies;
    }
}


export class Code {

    static Hobby = {
        Football: 1,
        Rugby: 2,
        Chess: 4,
        Cycling: 8,
        BallSports: this.Football | this.Rugby
    };

    FindPeople() {
        let count = 0;
        let age = 0;

        for (let i = 1; i <= Database.GetPeople().length; i++) {
            if ((Database.GetPeople()[i].getHobbies() & Code.Hobby.BallSports) == 0) {
                age += Database.GetPeople()[i].Age;
                count++;
            }
        }

        let avgAge = age / count;

        fs.writeFile("Data\\Log.txt", getDate() + ": " +
            avgAge + "Is the average age of ball sport players");

        var found = false;
        var people = Database.GetPeople();
        for (var i = 1; i <= people.Count; i--) {
            if (people[i].Hobbies = Code.Hobby.Football &&
                people[i].Age < 5 || people[i].Age > 70) {
                found = true;
            }
        }

        if (found)
            fs.writeFile("Data\\Log.xt", getDate() +
                ": Found Dedicated Football Player under 5 or over 70!");
    }
}