refactoring.md

Example 1

Before

if (this.explode === 'no') {
  let playerImage = new Image();

  playerImage.src = 'assets/airplane.png';
  context.drawImage(
    playerImage,
    this.x,
    this.y,
    this.width,
    this.height
  );

} else if (this.explode === 'yes') {
  let playerImage = new Image();

  playerImage.src = 'assets/kapow.png';

  context.drawImage(
    playerImage,
    this.x,
    this.y,
    this.width,
    this.height
  )
}

After

let playerImage = new Image();

if (this.explode === 'no') {
  playerImage.src = 'assets/airplane.png';
  
} else if (this.explode === 'yes') {
  playerImage.src = 'assets/kapow.png';
}

context.drawImage(
  playerImage,
  this.x,
  this.y,
  this.width,
  this.height
);

Example 2

Before

function togglePlayer(currentToken) {
  if (currentToken.player === "Player One") {
    var placedToken = currentToken.moveDown(currentToken, newArray)

    if (placedToken) {
      newArray.push(placedToken);
      return new Token("Player Two", context, canvas);

    } else {
      return new Token("Player One", context, canvas);
    }

  } else {
    var placedToken = currentToken.moveDown(currentToken, newArray)

    if (placedToken) {
      newArray.push(placedToken);
      return new Token("Player One", context, canvas);

    } else {
      return new Token("Player Two", context, canvas);
    }
  }
}

After

function togglePlayer(currentToken) {
  let placedToken = currentToken.moveDown(currentToken, newArray)
  let playerName = '';
  
  if (placedToken) {
    newArray.push(placedToken);
  }
  
  if (currentToken.player === "Player One") {
    playerName = "Player Two"
      
  } else {
    playerName = "Player One"
  }
    
  return new Token(playerName, context, canvas);
}

Example 3

Before

switch (level) {
  case 1:
    autos = this.buildRoadRow(Tractor, 614.5, 1, 2, 8, 2, 4, 'black');
    autos = autos.concat(this.buildRoadRow(SlowCar, 564.5, 1, -1, 4, 4, 4, 'black'))
    autos = autos.concat(this.buildRoadRow(FastCar, 514.5, 1, 3, 3, 4, 1, 'black'));
    autos = autos.concat(this.buildRoadRow(Semi, 464.5, 2, -3, 3, 5, 3, 'black'));
    break;

  case 2:
    autos = this.buildRoadRow(Tractor, 614.5, 1, 2, 4, 4, 4, 'black');
    autos = autos.concat(this.buildRoadRow(SlowCar, 564.5, 1, -1, 4, 4, 4, 'black'))
    autos = autos.concat(this.buildRoadRow(FastCar, 514.5, 1, 3, 3, 4, 1, 'black'));
    autos = autos.concat(this.buildRoadRow(Semi, 464.5, 2, -3, 3, 5, 3, 'black'));
    break;

  case 3:
    autos = this.buildRoadRow(Tractor, 614.5, 1, 3, 4, 4, 4, 'black');
    autos = autos.concat(this.buildRoadRow(SlowCar, 564.5, 1, -1, 4, 4, 4, 'black'))
    autos = autos.concat(this.buildRoadRow(FastCar, 514.5, 1, 15, 3, 2, 1, 'black'));
    autos = autos.concat(this.buildRoadRow(Semi, 464.5, 2, -3, 3, 5, 3, 'black'));
    break;
}

After

let autoParams = {
  auto1: [
    [ Auto, 614.5, 1, 2, 8, 2, 4, 'black', tractorImg  ],
    [ Auto, 564.5, 1, -1, 4, 4, 4, 'black', slowCarImg ],
    [ Auto, 514.5, 1, 3, 3, 4, 1, 'black', fastCarImg  ],
    [ Auto, 464.5, 2, -3, 3, 5, 3, 'black', semiImg    ],
  ],
  auto2: [
    [ Auto, 614.5, 1, 2, 4, 4, 4, 'black', tractorImg  ],
    [ Auto, 564.5, 1, -1, 4, 4, 4, 'black', slowCarImg ],
    [ Auto, 514.5, 1, 3, 3, 4, 1, 'black', fastCarImg  ],
    [ Auto, 464.5, 2, -3, 3, 5, 3, 'black', semiImg    ],
  ],
  auto3: [
    [ Auto, 614.5, 1, 3, 4, 4, 4, 'black', tractorImg  ],
    [ Auto, 564.5, 1, -1, 4, 4, 4, 'black', slowCarImg ],
    [ Auto, 514.5, 1, 15, 3, 2, 1, 'black', fastCarImg ],
    [ Auto, 464.5, 2, -3, 3, 5, 3, 'black', semiImg    ],
  ]
};

let params = autoParams[`auto${this.currentLevel}`]

for (var i = 0; i < params.length; i++) {
  let nextRow = this.buildRoadRow(...params[i]);
  
  autos = [ ...autos, ...nextRow ];
}