Skip to content

Instantly share code, notes, and snippets.

@bryceosterhaus
Created October 27, 2017 23:32
Show Gist options
  • Save bryceosterhaus/cad259e448b0ed65b26602c8f20d4140 to your computer and use it in GitHub Desktop.
Save bryceosterhaus/cad259e448b0ed65b26602c8f20d4140 to your computer and use it in GitHub Desktop.

Calling these supers aren't necessary https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/wizard/MaterialWizard.es.js#L45

Not sure if there is a specific reason for this, but the default values for state can be set in the Config. By calling setState on attached, it will probably cause a flash on the initial load. https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/wizard/MaterialWizard.es.js#L45

Example Config.number().value(0)

This block seems really weird. Might be easier to pass a callback fn to the child components https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/wizard/MaterialWizard.es.js#L57

This seems like a bad pattern https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/wizard/MaterialWizard.es.js#L113

These if's hurt my head a bit. https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/modal/MaterialModal.es.js#L37

duplicate methods https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/modal/MaterialModal.es.js#L73 https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/modal/MaterialModal.es.js#L77

I think there is a built in way for metal to handle emitting events, instead of having to do this. https://github.com/liferay/lfrgs-google-pario/blob/master/modules/material-design/components-soy-web/src/main/resources/META-INF/resources/components/input/CheckBox.es.js#L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment