List all files into an array, no dirs, optianally filtered by extension (using scandir)

bxt_fileList.php

<?php
function bxt_fileList($d,$x=false){
  foreach(scandir($d) as $f)if(is_file($d.'/'.$f)&&(!$x||preg_match('/'.$x.'$/i',$f)))$l[]=$f;
  return $l;
}

// silly "ninja" comment code from
// http://de3.php.net/manual/en/function.scandir.php#90628
function file_list($d,$x){
       foreach(array_diff(scandir($d),array('.','..')) as $f)if(is_file($d.'/'.$f)&&(($x)?ereg($x.'$',$f):1))$l[]=$f;
       return $l;
}
/*
* Funny, this self-declared "NNNIIIinnnjaaa" made me spot 6 issues
* in his four lines of code at first sight.
*
* Problems here:
* - array_diff() doesn't provide anything because . and .. are dirs
* - ereg() is silly, use eregi() istead, sinde file extensions are not case-sensitive
* - ereg()-Functions are depraced since PHP5.3
* - preg_match() is faster anyway
* - ternary is just poor, replace with usual boolean expressions
* - make 2nd parameter explicitly optional
*/

// Testing:

echo "\nhis:\n";
echo implode("\n",file_list('.'));
echo "\n\n\n\nhis.php:\n";
echo implode("\n",file_list('.','php'));


echo "\nmine:\n";
echo implode("\n",bxt_fileList('.'));
echo "\n\n\n\nmine.php:\n";
echo implode("\n",bxt_fileList('.','php'));

And of course there's the OOP/SPL/PEAR-way of doing things: https://github.com/sebastianbergmann/php-file-iterator