Created
April 15, 2023 21:58
-
-
Save caccavale/a8646b205173de9a82aa7c3c0d943cf9 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/sim/common/wotlk/shadowmourne.go b/sim/common/wotlk/shadowmourne.go | |
index 8529994a..6d45414f 100644 | |
--- a/sim/common/wotlk/shadowmourne.go | |
+++ b/sim/common/wotlk/shadowmourne.go | |
@@ -22,7 +22,7 @@ func init() { | |
core.NewItemEffect(49623, func(agent core.Agent) { | |
player := agent.GetCharacter() | |
- ppmm := player.AutoAttacks.NewPPMManager(12, core.ProcMaskMelee) | |
+ ppmm := player.AutoAttacks.NewPPMManager(12, core.ProcMaskMeleeAndSuppressedMeleeProcs) | |
chaosBaneAura := player.NewTemporaryStatsAura("Chaos Bane", core.ActionID{SpellID: 73422}, stats.Stats{stats.Strength: 270}, time.Second*10) | |
diff --git a/sim/core/flags.go b/sim/core/flags.go | |
index 40553323..9614ae0c 100644 | |
--- a/sim/core/flags.go | |
+++ b/sim/core/flags.go | |
@@ -56,6 +56,7 @@ const ( | |
ProcMaskRangedSpecial | |
ProcMaskSpellDamage | |
ProcMaskSpellHealing | |
+ ProcMaskSuppressedMeleeProc | |
) | |
const ( | |
@@ -81,6 +82,8 @@ const ( | |
ProcMaskTwoRoll = ProcMaskRanged | ProcMaskMeleeSpecial | |
ProcMaskSpecial = ProcMaskMeleeOrRangedSpecial | ProcMaskSpellDamage | |
+ | |
+ ProcMaskMeleeAndSuppressedMeleeProcs = ProcMaskMelee | ProcMaskSuppressedMeleeProc | |
) | |
func GetMeleeProcMaskForHands(mh bool, oh bool) ProcMask { | |
diff --git a/sim/deathknight/talents_unholy.go b/sim/deathknight/talents_unholy.go | |
index 7d6ed02c..4456e987 100644 | |
--- a/sim/deathknight/talents_unholy.go | |
+++ b/sim/deathknight/talents_unholy.go | |
@@ -151,10 +151,7 @@ func (dk *Deathknight) applyBloodCakedBlade() { | |
} | |
func (dk *Deathknight) bloodCakedBladeHit(isMh bool) *core.Spell { | |
- procMask := core.ProcMaskMeleeOHSpecial | |
- if isMh { | |
- procMask = core.ProcMaskMeleeMHSpecial | |
- } | |
+ procMask := core.ProcMaskSuppressedMeleeProc | |
return dk.Unit.RegisterSpell(core.SpellConfig{ | |
ActionID: core.ActionID{SpellID: 50463}.WithTag(core.TernaryInt32(isMh, 1, 2)), | |
diff --git a/sim/paladin/sov.go b/sim/paladin/sov.go | |
index ae9c727f..0e3e15b9 100644 | |
--- a/sim/paladin/sov.go | |
+++ b/sim/paladin/sov.go | |
@@ -119,7 +119,7 @@ func (paladin *Paladin) registerSealOfVengeanceSpellAndAura() { | |
onSpecialOrSwingProc := paladin.RegisterSpell(core.SpellConfig{ | |
ActionID: core.ActionID{SpellID: 42463}, // Seal of Vengeance damage bonus. | |
SpellSchool: core.SpellSchoolHoly, | |
- ProcMask: core.ProcMaskEmpty, // does proc certain spell damage-based items, e.g. Black Magic, Pendulum of Telluric Currents | |
+ ProcMask: core.ProcMaskSuppressedMeleeProc, // does proc certain spell damage-based items, e.g. Black Magic, Pendulum of Telluric Currents | |
Flags: core.SpellFlagMeleeMetrics, | |
// (mult * weaponScaling / stacks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment