Tell, Don't Ask.

a_smell.rb

class SomeClass

  def some_method(obj)
    if obj.foo
      obj.bar
    end
  end
end

class SomeOtherClass

  def foo; end
  def bar; end
end

better.rb

class SomeClass

  def some_method(obj)
    obj.foo_bar
  end
end


class SomeOtherClass

  def foo_bar
    if foo
      bar
    end
  end


private

  def foo; end
  def bar; end
end

Not enough banana

^ 👍 What he said.