Created
October 30, 2020 02:42
-
-
Save ccfiel/b719c00958fb4794a3a13afc3d273578 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ./src/app/pages/settings/DiningOptionFees.jsx | |
| Line 167:8: React Hook useEffect has missing dependencies: 'name', 'type', and 'value'. Either include them or remove the dependency array. You can also do a functional update 'setName(n => ...)' if you only need 'name' in the 'setName' call react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/components/DiningOptionModal.jsx | |
| Line 18:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| Line 24:8: React Hook useEffect has a missing dependency: 'filteredOptionList.length'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| Line 66:34: Unnecessarily computed property ["diningOptionFees"] found no-useless-computed-key | |
| ./src/app/pages/settings/OpenTickets.jsx | |
| Line 194:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/Settings.jsx | |
| Line 19:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/components/DiningOptionFeesCard.jsx | |
| Line 22:5: React Hook useEffect contains a call to 'setName'. Without a list of dependencies, this can lead to an infinite chain of updates. To fix this, pass [propsName, propsId, propsType, currency, propsValue] as a second argument to the useEffect Hook react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/components/DefaultForm.jsx | |
| Line 286:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| Line 331:8: React Hook useEffect has a missing dependency: 'form'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/components/AddModal.jsx | |
| Line 28:8: React Hook useEffect has a missing dependency: 'form'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/RouterManager.jsx | |
| Line 38:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/inventory/ItemsStocks.jsx | |
| Line 48:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| Line 75:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/components/DiningOptionCard.jsx | |
| Line 54:8: React Hook useEffect has a missing dependency: 'name'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/components/ErpnextForm.jsx | |
| Line 57:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| Line 67:8: React Hook useEffect has a missing dependency: 'form'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/receipts/Receipts.jsx | |
| Line 64:8: React Hook useEffect has a missing dependency: 'getReceipts'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| Line 73:8: React Hook useEffect has missing dependencies: 'dispatch' and 'querySize'. Either include them or remove the dependency array react-hooks/exhaustive-deps | |
| Line 124:5: Date prototype is read only, properties should not be added no-extend-native | |
| ./src/app/pages/quickbooks/components/SettingsModal.jsx | |
| Line 72:8: React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| Line 197:8: React Hook useEffect has missing dependencies: 'assetAccountIndex', 'discountItemIndex', 'drawerInItemIndex', 'drawerOutItemIndex', 'expenseAccountIndex', 'incomeAccountIndex', 'overUnderItemIndex', 'refundAccountIndex', 'serviceFeeItemIndex', and 'taxItemIndex'. Either include them or remove the dependency array. You can also do a functional update 'setIncomeAccountIndex(i => ...)' if you only need 'incomeAccountIndex' in the 'setIncomeAccountIndex' call react-hooks/exhaustive-deps | |
| ./src/app/pages/settings/components/OnlineStoreForm.jsx | |
| Line 90:8: React Hook useEffect has a missing dependency: 'form'. Either include it or remove the dependency array react-hooks/exhaustive-deps | |
| ./src/app/pages/quickbooks/Quickbooks.jsx | |
| Line 93:17: Destructuring assignment discountItem unnecessarily renamed no-useless-rename | |
| Line 94:17: Destructuring assignment drawerInItem unnecessarily renamed no-useless-rename | |
| Line 95:17: Destructuring assignment drawerOutItem unnecessarily renamed no-useless-rename | |
| Line 96:17: Destructuring assignment overUnderItem unnecessarily renamed no-useless-rename | |
| Line 97:17: Destructuring assignment serviceFeeItem unnecessarily renamed no-useless-rename | |
| Line 98:17: Destructuring assignment taxItem unnecessarily renamed no-useless-rename | |
| Line 100:17: Destructuring assignment assetAccount unnecessarily renamed no-useless-rename | |
| Line 101:17: Destructuring assignment incomeAccount unnecessarily renamed no-useless-rename | |
| Line 102:17: Destructuring assignment expenseAccount unnecessarily renamed no-useless-rename | |
| Line 103:17: Destructuring assignment refundAccount unnecessarily renamed no-useless-rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment