Skip to content

Instantly share code, notes, and snippets.

@chinmaygarde
Created September 26, 2017 00:36
Show Gist options
  • Select an option

  • Save chinmaygarde/b5d0455ce497e9c0086fa8f0bc39a3ed to your computer and use it in GitHub Desktop.

Select an option

Save chinmaygarde/b5d0455ce497e9c0086fa8f0bc39a3ed to your computer and use it in GitHub Desktop.
diff --git a/bin/flutter b/bin/flutter
index ee4131c00..db7f30a69 100755
--- a/bin/flutter
+++ b/bin/flutter
@@ -76,7 +76,7 @@ FLUTTER_TOOL_ARGS="--assert-initializer $FLUTTER_TOOL_ARGS"
# some platforms (e.g. Mac) don't have flock or any reliable alternative
fi
REVISION=`(cd "$FLUTTER_ROOT"; git rev-parse HEAD)`
- if [ ! -f "$SNAPSHOT_PATH" ] || [ ! -s "$STAMP_PATH" ] || [ `cat "$STAMP_PATH"` != "$REVISION" ] || [ "$FLUTTER_TOOLS_DIR/pubspec.yaml" -nt "$FLUTTER_TOOLS_DIR/pubspec.lock" ]; then
+ # if [ ! -f "$SNAPSHOT_PATH" ] || [ ! -s "$STAMP_PATH" ] || [ `cat "$STAMP_PATH"` != "$REVISION" ] || [ "$FLUTTER_TOOLS_DIR/pubspec.yaml" -nt "$FLUTTER_TOOLS_DIR/pubspec.lock" ]; then
mkdir -p "$FLUTTER_ROOT/bin/cache"
touch "$FLUTTER_ROOT/bin/cache/.dartignore"
"$FLUTTER_ROOT/bin/internal/update_dart_sdk.sh"
@@ -95,7 +95,7 @@ FLUTTER_TOOL_ARGS="--assert-initializer $FLUTTER_TOOL_ARGS"
done
"$DART" --snapshot="$SNAPSHOT_PATH" --packages="$FLUTTER_TOOLS_DIR/.packages" "$SCRIPT_PATH"
echo $REVISION > "$STAMP_PATH"
- fi
+ # fi
) 3< "$PROG_NAME"
set +e
diff --git a/packages/flutter_tools/lib/src/commands/build_aot.dart b/packages/flutter_tools/lib/src/commands/build_aot.dart
index 01f1ef627..cd1bff2e8 100644
--- a/packages/flutter_tools/lib/src/commands/build_aot.dart
+++ b/packages/flutter_tools/lib/src/commands/build_aot.dart
@@ -324,7 +324,7 @@ Future<String> _buildAotSnapshot(
if (platform == TargetPlatform.ios) {
printStatus('Building App.framework...');
- final List<String> commonBuildOptions = <String>['-arch', 'arm64', '-miphoneos-version-min=8.0'];
+ final List<String> commonBuildOptions = <String>['-arch', 'armv7s', '-miphoneos-version-min=8.0'];
if (interpreter) {
await runCheckedAsync(<String>['mv', vmSnapshotData, fs.path.join(outputDir.path, kVmSnapshotData)]);
@johanhenselmans

Copy link
Copy Markdown

I think armv7s should be armv7. Otherwise it will only run on iphone 5, not on iphone4s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment