Created
January 8, 2017 16:36
-
-
Save coderabbi/17c1c4ab2f7c9f9a4f34ff377a22495c to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's say you have this: | |
class SomeClass | |
{ | |
// users are encouraged to extend and set to true to enable magical powers... | |
protected $someQuality = false; | |
public function isSomeQuality() | |
{ | |
return $this->someQuality; | |
} | |
} | |
and want to use this: | |
trait SomeTrait | |
{ | |
protected $someQuality = true; | |
// useful stuff based upon that difference... | |
} | |
like this: | |
class SomeExtendedCLass extends SomeClass | |
{ | |
use SomeTrait; | |
} | |
You can't, you'll get a Fatal Error for redeclaring the member variable with a different initialized value. | |
Instead, you're forced to do this: | |
trait SomeTrait | |
{ | |
public function isSomeQuality() | |
{ | |
return true; // eww! Especially considering that $someQuality == false. | |
} | |
// useful stuff based upon that difference... | |
} | |
when had the original class author done this: | |
class SomeClass | |
{ | |
public function isSomeQuality() | |
{ | |
return $this->someQuality ?? false; | |
} | |
} | |
leaving $someQuality undeclared, everyone would be better off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment