Created
March 21, 2019 17:57
-
-
Save colintheshots/705c10c4d36530f03a5765b6cce92888 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> | |
| <html xmlns="http://www.w3.org/1999/xhtml"> | |
| <head> | |
| <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> | |
| <title>Lint Report</title> | |
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons"> | |
| <link rel="stylesheet" href="https://code.getmdl.io/1.2.1/material.blue-indigo.min.css" /> | |
| <link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Roboto:300,400,500,700" type="text/css"> | |
| <script defer src="https://code.getmdl.io/1.2.0/material.min.js"></script> | |
| <style> | |
| section.section--center { | |
| max-width: 860px; | |
| } | |
| .mdl-card__supporting-text + .mdl-card__actions { | |
| border-top: 1px solid rgba(0, 0, 0, 0.12); | |
| } | |
| main > .mdl-layout__tab-panel { | |
| padding: 8px; | |
| padding-top: 48px; | |
| } | |
| .mdl-card__actions { | |
| margin: 0; | |
| padding: 4px 40px; | |
| color: inherit; | |
| } | |
| .mdl-card > * { | |
| height: auto; | |
| } | |
| .mdl-card__actions a { | |
| color: #00BCD4; | |
| margin: 0; | |
| } | |
| .error-icon { | |
| color: #bb7777; | |
| vertical-align: bottom; | |
| } | |
| .warning-icon { | |
| vertical-align: bottom; | |
| } | |
| .mdl-layout__content section:not(:last-of-type) { | |
| position: relative; | |
| margin-bottom: 48px; | |
| } | |
| .mdl-card .mdl-card__supporting-text { | |
| margin: 40px; | |
| -webkit-flex-grow: 1; | |
| -ms-flex-positive: 1; | |
| flex-grow: 1; | |
| padding: 0; | |
| color: inherit; | |
| width: calc(100% - 80px); | |
| } | |
| div.mdl-layout__drawer-button .material-icons { | |
| line-height: 48px; | |
| } | |
| .mdl-card .mdl-card__supporting-text { | |
| margin-top: 0px; | |
| } | |
| .chips { | |
| float: right; | |
| vertical-align: middle; | |
| } | |
| pre.errorlines { | |
| background-color: white; | |
| font-family: monospace; | |
| border: 1px solid #e0e0e0; | |
| line-height: 0.9rem; | |
| font-size: 0.9rem; padding: 1px 0px 1px; 1px; | |
| overflow: scroll; | |
| } | |
| .prefix { | |
| color: #660e7a; | |
| font-weight: bold; | |
| } | |
| .attribute { | |
| color: #0000ff; | |
| font-weight: bold; | |
| } | |
| .value { | |
| color: #008000; | |
| font-weight: bold; | |
| } | |
| .tag { | |
| color: #000080; | |
| font-weight: bold; | |
| } | |
| .comment { | |
| color: #808080; | |
| font-style: italic; | |
| } | |
| .javadoc { | |
| color: #808080; | |
| font-style: italic; | |
| } | |
| .annotation { | |
| color: #808000; | |
| } | |
| .string { | |
| color: #008000; | |
| font-weight: bold; | |
| } | |
| .number { | |
| color: #0000ff; | |
| } | |
| .keyword { | |
| color: #000080; | |
| font-weight: bold; | |
| } | |
| .caretline { | |
| background-color: #fffae3; | |
| } | |
| .lineno { | |
| color: #999999; | |
| background-color: #f0f0f0; | |
| } | |
| .error { | |
| display: inline-block; | |
| position:relative; | |
| background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAQAAAAECAYAAACp8Z5+AAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH4AwCFR4T/3uLMgAAADxJREFUCNdNyLERQEAABMCjL4lQwIzcjErpguAL+C9AvgKJDbeD/PRpLdm35Hm+MU+cB+tCKaJW4L4YBy+CAiLJrFs9mgAAAABJRU5ErkJggg==) bottom repeat-x; | |
| } | |
| .warning { | |
| text-decoration: none; | |
| background-color: #f6ebbc; | |
| } | |
| .overview { | |
| padding: 10pt; | |
| width: 100%; | |
| overflow: auto; | |
| border-collapse:collapse; | |
| } | |
| .overview tr { | |
| border-bottom: solid 1px #eeeeee; | |
| } | |
| .categoryColumn a { | |
| text-decoration: none; | |
| color: inherit; | |
| } | |
| .countColumn { | |
| text-align: right; | |
| padding-right: 20px; | |
| width: 50px; | |
| } | |
| .issueColumn { | |
| padding-left: 16px; | |
| } | |
| .categoryColumn { | |
| position: relative; | |
| left: -50px; | |
| padding-top: 20px; | |
| padding-bottom: 5px; | |
| } | |
| </style> | |
| <script language="javascript" type="text/javascript"> | |
| <!-- | |
| function reveal(id) { | |
| if (document.getElementById) { | |
| document.getElementById(id).style.display = 'block'; | |
| document.getElementById(id+'Link').style.display = 'none'; | |
| } | |
| } | |
| function hideid(id) { | |
| if (document.getElementById) { | |
| document.getElementById(id).style.display = 'none'; | |
| } | |
| } | |
| //--> | |
| </script> | |
| </head> | |
| <body class="mdl-color--grey-100 mdl-color-text--grey-700 mdl-base"> | |
| <div class="mdl-layout mdl-js-layout mdl-layout--fixed-header"> | |
| <header class="mdl-layout__header"> | |
| <div class="mdl-layout__header-row"> | |
| <span class="mdl-layout-title">Lint Report: 96 warnings</span> | |
| <div class="mdl-layout-spacer"></div> | |
| <nav class="mdl-navigation mdl-layout--large-screen-only"> | |
| Check performed at Thu Mar 21 12:53:46 CDT 2019 </nav> | |
| </div> | |
| </header> | |
| <div class="mdl-layout__drawer"> | |
| <span class="mdl-layout-title">Issue Types</span> | |
| <nav class="mdl-navigation"> | |
| <a class="mdl-navigation__link" href="#overview"><i class="material-icons">dashboard</i>Overview</a> | |
| <a class="mdl-navigation__link" href="#InlinedApi"><i class="material-icons warning-icon">warning</i>Using inlined constants on older versions (8)</a> | |
| <a class="mdl-navigation__link" href="#UnusedAttribute"><i class="material-icons warning-icon">warning</i>Attribute unused on older versions (24)</a> | |
| <a class="mdl-navigation__link" href="#VectorRaster"><i class="material-icons warning-icon">warning</i>Vector Image Generation (2)</a> | |
| <a class="mdl-navigation__link" href="#PluralsCandidate"><i class="material-icons warning-icon">warning</i>Potential Plurals (2)</a> | |
| <a class="mdl-navigation__link" href="#AllowBackup"><i class="material-icons warning-icon">warning</i>AllowBackup/FullBackupContent Problems (2)</a> | |
| <a class="mdl-navigation__link" href="#StaticFieldLeak"><i class="material-icons warning-icon">warning</i>Static Field Leaks (1)</a> | |
| <a class="mdl-navigation__link" href="#VectorPath"><i class="material-icons warning-icon">warning</i>Long vector paths (8)</a> | |
| <a class="mdl-navigation__link" href="#Overdraw"><i class="material-icons warning-icon">warning</i>Overdraw: Painting regions more than once (3)</a> | |
| <a class="mdl-navigation__link" href="#UnusedResources"><i class="material-icons warning-icon">warning</i>Unused resources (19)</a> | |
| <a class="mdl-navigation__link" href="#UselessParent"><i class="material-icons warning-icon">warning</i>Useless parent layout (1)</a> | |
| <a class="mdl-navigation__link" href="#UnusedNamespace"><i class="material-icons warning-icon">warning</i>Unused namespace (1)</a> | |
| <a class="mdl-navigation__link" href="#IconLocation"><i class="material-icons warning-icon">warning</i>Image defined in density-independent drawable folder (1)</a> | |
| <a class="mdl-navigation__link" href="#IconDensities"><i class="material-icons warning-icon">warning</i>Icon densities validation (4)</a> | |
| <a class="mdl-navigation__link" href="#GoogleAppIndexingWarning"><i class="material-icons warning-icon">warning</i>Missing support for Firebase App Indexing (1)</a> | |
| <a class="mdl-navigation__link" href="#AlwaysShowAction"><i class="material-icons warning-icon">warning</i>Usage of <code>showAsAction=always</code> (1)</a> | |
| <a class="mdl-navigation__link" href="#ContentDescription"><i class="material-icons warning-icon">warning</i>Image without <code>contentDescription</code> (9)</a> | |
| <a class="mdl-navigation__link" href="#SetTextI18n"><i class="material-icons warning-icon">warning</i>TextView Internationalization (1)</a> | |
| <a class="mdl-navigation__link" href="#HardcodedText"><i class="material-icons warning-icon">warning</i>Hardcoded text (2)</a> | |
| <a class="mdl-navigation__link" href="#RtlSymmetry"><i class="material-icons warning-icon">warning</i>Padding and margin symmetry (6)</a> | |
| </nav> | |
| </div> | |
| <main class="mdl-layout__content"> | |
| <div class="mdl-layout__tab-panel is-active"> | |
| <a name="overview"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="OverviewCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Overview</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <table class="overview"> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Correctness">Correctness</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">8</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#InlinedApi">InlinedApi</a>: Using inlined constants on older versions</td></tr> | |
| <tr> | |
| <td class="countColumn">24</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#UnusedAttribute">UnusedAttribute</a>: Attribute unused on older versions</td></tr> | |
| <tr> | |
| <td class="countColumn">2</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#VectorRaster">VectorRaster</a>: Vector Image Generation</td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Correctness:Messages">Correctness:Messages</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">2</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#PluralsCandidate">PluralsCandidate</a>: Potential Plurals</td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Security">Security</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">2</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#AllowBackup">AllowBackup</a>: AllowBackup/FullBackupContent Problems</td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Performance">Performance</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#StaticFieldLeak">StaticFieldLeak</a>: Static Field Leaks</td></tr> | |
| <tr> | |
| <td class="countColumn">8</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#VectorPath">VectorPath</a>: Long vector paths</td></tr> | |
| <tr> | |
| <td class="countColumn">3</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#Overdraw">Overdraw</a>: Overdraw: Painting regions more than once</td></tr> | |
| <tr> | |
| <td class="countColumn">19</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#UnusedResources">UnusedResources</a>: Unused resources</td></tr> | |
| <tr> | |
| <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#UselessParent">UselessParent</a>: Useless parent layout</td></tr> | |
| <tr> | |
| <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#UnusedNamespace">UnusedNamespace</a>: Unused namespace</td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Usability:Icons">Usability:Icons</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#IconLocation">IconLocation</a>: Image defined in density-independent drawable folder</td></tr> | |
| <tr> | |
| <td class="countColumn">4</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#IconDensities">IconDensities</a>: Icon densities validation</td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Usability">Usability</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#GoogleAppIndexingWarning">GoogleAppIndexingWarning</a>: Missing support for Firebase App Indexing</td></tr> | |
| <tr> | |
| <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#AlwaysShowAction">AlwaysShowAction</a>: Usage of <code>showAsAction=always</code></td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Accessibility">Accessibility</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">9</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#ContentDescription">ContentDescription</a>: Image without <code>contentDescription</code></td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Internationalization">Internationalization</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#SetTextI18n">SetTextI18n</a>: TextView Internationalization</td></tr> | |
| <tr> | |
| <td class="countColumn">2</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#HardcodedText">HardcodedText</a>: Hardcoded text</td></tr> | |
| <tr><td class="countColumn"></td><td class="categoryColumn"><a href="#Internationalization:Bidirectional Text">Internationalization:Bidirectional Text</a> | |
| </td></tr> | |
| <tr> | |
| <td class="countColumn">6</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i> | |
| <a href="#RtlSymmetry">RtlSymmetry</a>: Padding and margin symmetry</td></tr> | |
| <tr><td></td><td class="categoryColumn"><a href="#MissingIssues">Disabled Checks (31)</a> | |
| </td></tr></table> | |
| <br/> </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="OverviewCardLink" onclick="hideid('OverviewCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Correctness"></a> | |
| <a name="InlinedApi"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="InlinedApiCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Using inlined constants on older versions</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:82</span>: <span class="message">Field requires API level 23 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 79 </span> <span class="keyword">when</span> (themeManager.currentTheme) { | |
| <span class="lineno"> 80 </span> ThemeManager.Theme.Light -> { | |
| <span class="lineno"> 81 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility or | |
| <span class="caretline"><span class="lineno"> 82 </span> <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</span> or View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</span> | |
| <span class="lineno"> 83 </span> } | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| </pre> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:82</span>: <span class="message">Field requires API level 23 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 79 </span> <span class="keyword">when</span> (themeManager.currentTheme) { | |
| <span class="lineno"> 80 </span> ThemeManager.Theme.Light -> { | |
| <span class="lineno"> 81 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility or | |
| <span class="caretline"><span class="lineno"> 82 </span> <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</span> or View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</span> | |
| <span class="lineno"> 83 </span> } | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| </pre> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:82</span>: <span class="message">Field requires API level 26 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 79 </span> <span class="keyword">when</span> (themeManager.currentTheme) { | |
| <span class="lineno"> 80 </span> ThemeManager.Theme.Light -> { | |
| <span class="lineno"> 81 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility or | |
| <span class="caretline"><span class="lineno"> 82 </span> View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR or <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</span></span> | |
| <span class="lineno"> 83 </span> } | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| </pre> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:82</span>: <span class="message">Field requires API level 26 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 79 </span> <span class="keyword">when</span> (themeManager.currentTheme) { | |
| <span class="lineno"> 80 </span> ThemeManager.Theme.Light -> { | |
| <span class="lineno"> 81 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility or | |
| <span class="caretline"><span class="lineno"> 82 </span> View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR or <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</span></span> | |
| <span class="lineno"> 83 </span> } | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| </pre> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:86</span>: <span class="message">Field requires API level 23 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 83 </span> } | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| <span class="caretline"><span class="lineno"> 86 </span> <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</span>.inv() and </span> | |
| <span class="lineno"> 87 </span> View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR.inv() | |
| <span class="lineno"> 88 </span> } | |
| <span class="lineno"> 89 </span> } | |
| </pre> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:86</span>: <span class="message">Field requires API level 23 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 83 </span> } | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| <span class="caretline"><span class="lineno"> 86 </span> <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR</span>.inv() and </span> | |
| <span class="lineno"> 87 </span> View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR.inv() | |
| <span class="lineno"> 88 </span> } | |
| <span class="lineno"> 89 </span> } | |
| </pre> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:87</span>: <span class="message">Field requires API level 26 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| <span class="lineno"> 86 </span> View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR.inv() and | |
| <span class="caretline"><span class="lineno"> 87 </span> <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</span>.inv() </span> | |
| <span class="lineno"> 88 </span> } | |
| <span class="lineno"> 89 </span> } | |
| <span class="lineno"> 90 </span> } | |
| </pre> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/ThemeManager.kt">../../src/main/java/org/mozilla/fenix/ThemeManager.kt</a>:87</span>: <span class="message">Field requires API level 26 (current min is 21): <code>android.view.View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</code></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 84 </span> ThemeManager.Theme.Private -> { | |
| <span class="lineno"> 85 </span> window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and | |
| <span class="lineno"> 86 </span> View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR.inv() and | |
| <span class="caretline"><span class="lineno"> 87 </span> <span class="warning">View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR</span>.inv() </span> | |
| <span class="lineno"> 88 </span> } | |
| <span class="lineno"> 89 </span> } | |
| <span class="lineno"> 90 </span> } | |
| </pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationInlinedApi" style="display: none;"> | |
| This check scans through all the Android API field references in the application and flags certain constants, such as static final integers and Strings, which were introduced in later versions. These will actually be copied into the class files rather than being referenced, which means that the value is available even when running on older devices. In some cases that's fine, and in other cases it can result in a runtime crash or incorrect behavior. It depends on the context, so consider the code carefully and decide whether it's safe and can be suppressed or whether the code needs to be guarded.<br/> | |
| <br/> | |
| If you really want to use this API and don't need to support older devices just set the <code>minSdkVersion</code> in your <code>build.gradle</code> or <code>AndroidManifest.xml</code> files.<br/> | |
| If your code is <b>deliberately</b> accessing newer APIs, and you have ensured (e.g. with conditional execution) that this code will only ever be called on a supported platform, then you can annotate your class or method with the <code>@TargetApi</code> annotation specifying the local minimum SDK to apply, such as <code>@TargetApi(11)</code>, such that this check considers 11 rather than your manifest file's minimum SDK as the required API level.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "InlinedApi" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">InlinedApi</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Correctness</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 6/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationInlinedApiLink" onclick="reveal('explanationInlinedApi');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="InlinedApiCardLink" onclick="hideid('InlinedApiCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="UnusedAttribute"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="UnusedAttributeCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Attribute unused on older versions</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_search.xml">../../src/main/res/layout/fragment_search.xml</a>:50</span>: <span class="message">Attribute <code>drawableTint</code> is only used in API level 23 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 47 </span> <span class="prefix">android:</span><span class="attribute">layout_marginEnd</span>=<span class="value">"8dp"</span> | |
| <span class="lineno"> 48 </span> <span class="prefix">android:</span><span class="attribute">textColor</span>=<span class="value">"?attr/searchShortcutsTextColor"</span> | |
| <span class="lineno"> 49 </span> <span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"?attr/pillWrapperBackground"</span> | |
| <span class="caretline"><span class="lineno"> 50 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">drawableTint</span>=<span class="value">"?attr/searchShortcutsTextColor"</span></span>/> </span> | |
| <span class="lineno"> 51 </span> | |
| <span class="lineno"> 52 </span> <span class="tag"><Button</span><span class="attribute"> | |
| </span><span class="lineno"> 53 </span><span class="attribute"> style</span>=<span class="value">"@style/search_pill"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_search.xml">../../src/main/res/layout/fragment_search.xml</a>:59</span>: <span class="message">Attribute <code>drawableTint</code> is only used in API level 23 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 56 </span> <span class="prefix">android:</span><span class="attribute">drawableStart</span>=<span class="value">"@drawable/ic_shortcuts"</span> | |
| <span class="lineno"> 57 </span> <span class="prefix">android:</span><span class="attribute">textColor</span>=<span class="value">"?attr/searchShortcutsTextColor"</span> | |
| <span class="lineno"> 58 </span> <span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"?attr/pillWrapperBackground"</span> | |
| <span class="caretline"><span class="lineno"> 59 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">drawableTint</span>=<span class="value">"?attr/searchShortcutsTextColor"</span></span>/> </span> | |
| <span class="lineno"> 60 </span> <span class="tag"></LinearLayout></span> | |
| <span class="lineno"> 61 </span><span class="tag"></androidx.constraintlayout.widget.ConstraintLayout></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:24</span>: <span class="message">Attribute <code>startY</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 21 </span> <span class="prefix">android:</span><span class="attribute">strokeColor</span>=<span class="value">"#00000000"</span>> | |
| <span class="lineno"> 22 </span> <span class="tag"><aapt:attr</span><span class="attribute"> name</span>=<span class="value">"android:fillColor"</span>> | |
| <span class="lineno"> 23 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="caretline"><span class="lineno"> 24 </span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"49"</span></span> </span> | |
| <span class="lineno"> 25 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"20.763313"</span> | |
| <span class="lineno"> 26 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"49"</span> | |
| <span class="lineno"> 27 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"9.27464"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:25</span>: <span class="message">Attribute <code>startX</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 22 </span> <span class="tag"><aapt:attr</span><span class="attribute"> name</span>=<span class="value">"android:fillColor"</span>> | |
| <span class="lineno"> 23 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="lineno"> 24 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"49"</span> | |
| <span class="caretline"><span class="lineno"> 25 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"20.763313"</span></span> </span> | |
| <span class="lineno"> 26 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"49"</span> | |
| <span class="lineno"> 27 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"9.27464"</span> | |
| <span class="lineno"> 28 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:26</span>: <span class="message">Attribute <code>endY</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 23 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="lineno"> 24 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"49"</span> | |
| <span class="lineno"> 25 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"20.763313"</span> | |
| <span class="caretline"><span class="lineno"> 26 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"49"</span></span> </span> | |
| <span class="lineno"> 27 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"9.27464"</span> | |
| <span class="lineno"> 28 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 29 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| </pre> | |
| <button class="mdl-button mdl-js-button mdl-button--primary" id="UnusedAttributeDivLink" onclick="reveal('UnusedAttributeDiv');" />+ 19 More Occurrences...</button> | |
| <div id="UnusedAttributeDiv" style="display: none"> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:27</span>: <span class="message">Attribute <code>endX</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 24 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"49"</span> | |
| <span class="lineno"> 25 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"20.763313"</span> | |
| <span class="lineno"> 26 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"49"</span> | |
| <span class="caretline"><span class="lineno"> 27 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"9.27464"</span></span> </span> | |
| <span class="lineno"> 28 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 29 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="lineno"> 30 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:29</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 26 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"49"</span> | |
| <span class="lineno"> 27 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"9.27464"</span> | |
| <span class="lineno"> 28 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="caretline"><span class="lineno"> 29 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> </span> | |
| <span class="lineno"> 30 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| <span class="lineno"> 31 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> | |
| <span class="lineno"> 32 </span> <span class="tag"></gradient></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:30</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 27 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"9.27464"</span> | |
| <span class="lineno"> 28 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 29 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="caretline"><span class="lineno"> 30 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> </span> | |
| <span class="lineno"> 31 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> | |
| <span class="lineno"> 32 </span> <span class="tag"></gradient></span> | |
| <span class="lineno"> 33 </span> <span class="tag"></aapt:attr></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:31</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 28 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 29 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="lineno"> 30 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| <span class="caretline"><span class="lineno"> 31 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> </span> | |
| <span class="lineno"> 32 </span> <span class="tag"></gradient></span> | |
| <span class="lineno"> 33 </span> <span class="tag"></aapt:attr></span> | |
| <span class="lineno"> 34 </span> <span class="tag"></path></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:48</span>: <span class="message">Attribute <code>startY</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 45 </span> <span class="prefix">android:</span><span class="attribute">strokeColor</span>=<span class="value">"#00000000"</span>> | |
| <span class="lineno"> 46 </span> <span class="tag"><aapt:attr</span><span class="attribute"> name</span>=<span class="value">"android:fillColor"</span>> | |
| <span class="lineno"> 47 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="caretline"><span class="lineno"> 48 </span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"46.1246"</span></span> </span> | |
| <span class="lineno"> 49 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"41.02018"</span> | |
| <span class="lineno"> 50 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"34.49148"</span> | |
| <span class="lineno"> 51 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"41.02018"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:49</span>: <span class="message">Attribute <code>startX</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 46 </span> <span class="tag"><aapt:attr</span><span class="attribute"> name</span>=<span class="value">"android:fillColor"</span>> | |
| <span class="lineno"> 47 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="lineno"> 48 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"46.1246"</span> | |
| <span class="caretline"><span class="lineno"> 49 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"41.02018"</span></span> </span> | |
| <span class="lineno"> 50 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"34.49148"</span> | |
| <span class="lineno"> 51 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"41.02018"</span> | |
| <span class="lineno"> 52 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:50</span>: <span class="message">Attribute <code>endY</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 47 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="lineno"> 48 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"46.1246"</span> | |
| <span class="lineno"> 49 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"41.02018"</span> | |
| <span class="caretline"><span class="lineno"> 50 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"34.49148"</span></span> </span> | |
| <span class="lineno"> 51 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"41.02018"</span> | |
| <span class="lineno"> 52 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 53 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:51</span>: <span class="message">Attribute <code>endX</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 48 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"46.1246"</span> | |
| <span class="lineno"> 49 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"41.02018"</span> | |
| <span class="lineno"> 50 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"34.49148"</span> | |
| <span class="caretline"><span class="lineno"> 51 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"41.02018"</span></span> </span> | |
| <span class="lineno"> 52 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 53 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="lineno"> 54 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:53</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 50 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"34.49148"</span> | |
| <span class="lineno"> 51 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"41.02018"</span> | |
| <span class="lineno"> 52 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="caretline"><span class="lineno"> 53 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> </span> | |
| <span class="lineno"> 54 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| <span class="lineno"> 55 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> | |
| <span class="lineno"> 56 </span> <span class="tag"></gradient></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:54</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 51 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"41.02018"</span> | |
| <span class="lineno"> 52 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 53 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="caretline"><span class="lineno"> 54 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> </span> | |
| <span class="lineno"> 55 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> | |
| <span class="lineno"> 56 </span> <span class="tag"></gradient></span> | |
| <span class="lineno"> 57 </span> <span class="tag"></aapt:attr></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:55</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 52 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 53 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="lineno"> 54 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| <span class="caretline"><span class="lineno"> 55 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> </span> | |
| <span class="lineno"> 56 </span> <span class="tag"></gradient></span> | |
| <span class="lineno"> 57 </span> <span class="tag"></aapt:attr></span> | |
| <span class="lineno"> 58 </span> <span class="tag"></path></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:66</span>: <span class="message">Attribute <code>startY</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 63 </span> <span class="prefix">android:</span><span class="attribute">strokeColor</span>=<span class="value">"#00000000"</span>> | |
| <span class="lineno"> 64 </span> <span class="tag"><aapt:attr</span><span class="attribute"> name</span>=<span class="value">"android:fillColor"</span>> | |
| <span class="lineno"> 65 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="caretline"><span class="lineno"> 66 </span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"21.0466"</span></span> </span> | |
| <span class="lineno"> 67 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"6.020179"</span> | |
| <span class="lineno"> 68 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"9.413482"</span> | |
| <span class="lineno"> 69 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"6.020179"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:67</span>: <span class="message">Attribute <code>startX</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 64 </span> <span class="tag"><aapt:attr</span><span class="attribute"> name</span>=<span class="value">"android:fillColor"</span>> | |
| <span class="lineno"> 65 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="lineno"> 66 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"21.0466"</span> | |
| <span class="caretline"><span class="lineno"> 67 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"6.020179"</span></span> </span> | |
| <span class="lineno"> 68 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"9.413482"</span> | |
| <span class="lineno"> 69 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"6.020179"</span> | |
| <span class="lineno"> 70 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:68</span>: <span class="message">Attribute <code>endY</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 65 </span> <span class="tag"><gradient</span><span class="attribute"> | |
| </span><span class="lineno"> 66 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"21.0466"</span> | |
| <span class="lineno"> 67 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"6.020179"</span> | |
| <span class="caretline"><span class="lineno"> 68 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"9.413482"</span></span> </span> | |
| <span class="lineno"> 69 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"6.020179"</span> | |
| <span class="lineno"> 70 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 71 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:69</span>: <span class="message">Attribute <code>endX</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 66 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">startY</span>=<span class="value">"21.0466"</span> | |
| <span class="lineno"> 67 </span> <span class="prefix">android:</span><span class="attribute">startX</span>=<span class="value">"6.020179"</span> | |
| <span class="lineno"> 68 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"9.413482"</span> | |
| <span class="caretline"><span class="lineno"> 69 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"6.020179"</span></span> </span> | |
| <span class="lineno"> 70 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 71 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="lineno"> 72 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:71</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 68 </span> <span class="prefix">android:</span><span class="attribute">endY</span>=<span class="value">"9.413482"</span> | |
| <span class="lineno"> 69 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"6.020179"</span> | |
| <span class="lineno"> 70 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="caretline"><span class="lineno"> 71 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> </span> | |
| <span class="lineno"> 72 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| <span class="lineno"> 73 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> | |
| <span class="lineno"> 74 </span> <span class="tag"></gradient></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:72</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 69 </span> <span class="prefix">android:</span><span class="attribute">endX</span>=<span class="value">"6.020179"</span> | |
| <span class="lineno"> 70 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 71 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="caretline"><span class="lineno"> 72 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> </span> | |
| <span class="lineno"> 73 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> | |
| <span class="lineno"> 74 </span> <span class="tag"></gradient></span> | |
| <span class="lineno"> 75 </span> <span class="tag"></aapt:attr></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_sessions_intro.xml">../../src/main/res/drawable/ic_sessions_intro.xml</a>:73</span>: <span class="message">Attribute <code>offset</code> is only used in API level 24 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 70 </span> <span class="prefix">android:</span><span class="attribute">type</span>=<span class="value">"linear"</span>> | |
| <span class="lineno"> 71 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#A30B1043"</span>/> | |
| <span class="lineno"> 72 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"0.40306628"</span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#510B1043"</span>/> | |
| <span class="caretline"><span class="lineno"> 73 </span> <span class="tag"><item</span><span class="attribute"> </span><span class="warning"><span class="prefix">android:</span><span class="attribute">offset</span>=<span class="value">"1"</span></span> <span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"#000B1043"</span>/> </span> | |
| <span class="lineno"> 74 </span> <span class="tag"></gradient></span> | |
| <span class="lineno"> 75 </span> <span class="tag"></aapt:attr></span> | |
| <span class="lineno"> 76 </span> <span class="tag"></path></span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/session_bottom_sheet.xml">../../src/main/res/layout/session_bottom_sheet.xml</a>:114</span>: <span class="message">Attribute <code>drawableTint</code> is only used in API level 23 and higher (current min is 21)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 111 </span> <span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"?android:attr/colorBackground"</span> | |
| <span class="lineno"> 112 </span> <span class="prefix">android:</span><span class="attribute">drawableStart</span>=<span class="value">"@drawable/ic_share"</span> | |
| <span class="lineno"> 113 </span> <span class="prefix">android:</span><span class="attribute">drawablePadding</span>=<span class="value">"14dp"</span> | |
| <span class="caretline"><span class="lineno"> 114 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">drawableTint</span>=<span class="value">"@color/icons_light_mode"</span></span> </span> | |
| <span class="lineno"> 115 </span> <span class="prefix">android:</span><span class="attribute">paddingStart</span>=<span class="value">"20dp"</span> | |
| <span class="lineno"> 116 </span> <span class="prefix">android:</span><span class="attribute">paddingTop</span>=<span class="value">"12dp"</span> | |
| <span class="lineno"> 117 </span> <span class="prefix">android:</span><span class="attribute">paddingBottom</span>=<span class="value">"12dp"</span></pre> | |
| </div> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationUnusedAttribute" style="display: none;"> | |
| This check finds attributes set in XML files that were introduced in a version newer than the oldest version targeted by your application (with the <code>minSdkVersion</code> attribute).<br/> | |
| <br/> | |
| This is not an error; the application will simply ignore the attribute. However, if the attribute is important to the appearance or functionality of your application, you should consider finding an alternative way to achieve the same result with only available attributes, and then you can optionally create a copy of the layout in a layout-vNN folder which will be used on API NN or higher where you can take advantage of the newer attribute.<br/> | |
| <br/> | |
| Note: This check does not only apply to attributes. For example, some tags can be unused too, such as the new <code><tag></code> element in layouts introduced in API 21.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "UnusedAttribute" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">UnusedAttribute</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Correctness</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 6/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationUnusedAttributeLink" onclick="reveal('explanationUnusedAttribute');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="UnusedAttributeCardLink" onclick="hideid('UnusedAttributeCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="VectorRaster"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="VectorRasterCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Vector Image Generation</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_launcher_background.xml">../../src/main/res/drawable/ic_launcher_background.xml</a>:11</span>: <span class="message">Resource references will not work correctly in images generated for this vector icon for API < 24; check generated icon to make sure it looks acceptable</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 8 </span> <span class="tag"><path</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">fillType</span>=<span class="value">"evenOdd"</span> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"M0,0h108v108h-108z"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><aapt:attr</span><span class="attribute"> name</span>=<span class="value">"android:fillColor"</span>> | |
| <span class="caretline"><span class="lineno"> 11 </span> <span class="tag"><solid</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"</span><span class="warning"><span class="value">@color/color_accent</span></span><span class="value">"</span>/> </span> | |
| <span class="lineno"> 12 </span> <span class="tag"></aapt:attr></span> | |
| <span class="lineno"> 13 </span> <span class="tag"></path></span> | |
| <span class="lineno"> 14 </span><span class="tag"></vector></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_share.xml">../../src/main/res/drawable/ic_share.xml</a>:13</span>: <span class="message">Resource references will not work correctly in images generated for this vector icon for API < 24; check generated icon to make sure it looks acceptable</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"M8.92,14.7338C8.1902,15.5131 7.1519,16 6,16C3.7909,16 2,14.2091 2,12C2,9.7909 3.7909,8 6,8C7.0609,8 8.0783,8.4214 8.8284,9.1716C8.86,9.2031 8.8909,9.2351 8.9213,9.2676L13.1206,6.9785C13.0418,6.6654 13,6.3376 13,6C13,3.7909 14.7909,2 17,2C19.2091,2 21,3.7909 21,6C21,8.2091 19.2091,10 17,10C15.8481,10 14.8098,9.5131 14.08,8.7338L9.879,11.0237C9.9587,11.3403 10,11.668 10,12C10,12.3376 9.9582,12.6654 9.8794,12.9785L14.0787,15.2675C14.8087,14.4875 15.8474,14 17,14C19.2091,14 21,15.7909 21,18C21,20.2091 19.2091,22 17,22C14.7909,22 13,20.2091 13,18C13,17.6631 13.0417,17.3358 13.1201,17.0232L8.92,14.7338ZM17,4C15.8954,4 15,4.8954 15,6C15,7.1046 15.8954,8 17,8C18.1046,8 19,7.1046 19,6C19,4.8954 18.1046,4 17,4ZM6,10C4.8954,10 4,10.8954 4,12C4,13.1046 4.8954,14 6,14C7.1046,14 8,13.1046 8,12C8,10.8954 7.1046,10 6,10ZM17,16C15.8954,16 15,16.8954 15,18C15,19.1046 15.8954,20 17,20C18.1046,20 19,19.1046 19,18C19,16.8954 18.1046,16 17,16Z"</span> | |
| <span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">strokeWidth</span>=<span class="value">"1"</span> | |
| <span class="caretline"><span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"</span><span class="warning"><span class="value">?attr/iconColor</span></span><span class="value">"</span> </span> | |
| <span class="lineno"> 14 </span> <span class="prefix">android:</span><span class="attribute">fillType</span>=<span class="value">"nonZero"</span> | |
| <span class="lineno"> 15 </span> <span class="prefix">android:</span><span class="attribute">strokeColor</span>=<span class="value">"#00000000"</span>/> | |
| <span class="lineno"> 16 </span><span class="tag"></vector></span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationVectorRaster" style="display: none;"> | |
| Vector icons require API 21 or API 24 depending on used features, but when <code>minSdkVersion</code> is less than 21 or 24 and Android Gradle plugin 1.4 or higher is used, a vector drawable placed in the <code>drawable</code> folder is automatically moved to <code>drawable-anydpi-v21</code> or <code>drawable-anydpi-v24</code> and bitmap images are generated for different screen resolutions for backwards compatibility.<br/> | |
| <br/> | |
| However, there are some limitations to this raster image generation, and this lint check flags elements and attributes that are not fully supported. You should manually check whether the generated output is acceptable for those older devices.<br/>To suppress this error, use the issue id "VectorRaster" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">VectorRaster</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Correctness</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 5/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationVectorRasterLink" onclick="reveal('explanationVectorRaster');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="VectorRasterCardLink" onclick="hideid('VectorRasterCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Correctness:Messages"></a> | |
| <a name="PluralsCandidate"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="PluralsCandidateCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Potential Plurals</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/values/strings.xml">../../src/main/res/values/strings.xml</a>:209</span>: <span class="message">Formatting %d followed by words ("sites"): This should probably be a plural rather than a string</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 206 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"session_item_delete"</span>>Delete<span class="tag"></string></span> | |
| <span class="lineno"> 207 </span> <span class="comment"><!-- Text to tell the user how many more tabs this session has. | |
| </span><span class="lineno"> 208 </span><span class="comment"> The first parameter is how many extra tabs the session has. --></span> | |
| <span class="caretline"><span class="lineno"> 209 </span> <span class="warning"><span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"session_items_more"</span>>%1$d sites…<span class="tag"></string></span></span> </span> | |
| <span class="lineno"> 210 </span> | |
| <span class="lineno"> 211 </span> <span class="comment"><!-- History --></span> | |
| <span class="lineno"> 212 </span> <span class="comment"><!-- Text for the button to clear all history --></span></pre> | |
| <span class="location"><a href="../../src/main/res/values/strings.xml">../../src/main/res/values/strings.xml</a>:218</span>: <span class="message">Formatting %d followed by words ("items"): This should probably be a plural rather than a string</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 215 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"history_delete_item"</span>>Delete<span class="tag"></string></span> | |
| <span class="lineno"> 216 </span> <span class="comment"><!-- Text for the button to clear selected history items. The first parameter | |
| </span><span class="lineno"> 217 </span><span class="comment"> is the number of items you have selected --></span> | |
| <span class="caretline"><span class="lineno"> 218 </span> <span class="warning"><span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"history_delete_some"</span>>Delete %1$d items<span class="tag"></string></span></span> </span> | |
| <span class="lineno"> 219 </span> | |
| <span class="lineno"> 220 </span> <span class="comment"><!-- Text displayed in a notification when the user enters full screen mode --></span> | |
| <span class="lineno"> 221 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"full_screen_notification"</span>>Entering full screen mode<span class="tag"></string></span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationPluralsCandidate" style="display: none;"> | |
| This lint check looks for potential errors in internationalization where you have translated a message which involves a quantity and it looks like other parts of the string may need grammatical changes.<br/> | |
| <br/> | |
| For example, rather than something like this:<br/> | |
| <string name="try_again">Try again in %d seconds.</string><br/> | |
| you should be using a plural:<br/> | |
| <plurals name="try_again"><br/> | |
| <item quantity="one">Try again in %d second</item><br/> | |
| <item quantity="other">Try again in %d seconds</item><br/> | |
| </plurals><br/> | |
| This will ensure that in other languages the right set of translations are provided for the different quantity classes.<br/> | |
| <br/> | |
| (This check depends on some heuristics, so it may not accurately determine whether a string really should be a quantity. You can use tools:ignore to filter out false positives.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/guide/topics/resources/string-resource.html#Plurals">http://developer.android.com/guide/topics/resources/string-resource.html#Plurals</a> | |
| </div>To suppress this error, use the issue id "PluralsCandidate" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">PluralsCandidate</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Messages</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Correctness</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 5/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationPluralsCandidateLink" onclick="reveal('explanationPluralsCandidate');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="PluralsCandidateCardLink" onclick="hideid('PluralsCandidateCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Security"></a> | |
| <a name="AllowBackup"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="AllowBackupCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">AllowBackup/FullBackupContent Problems</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/debug/AndroidManifest.xml">../../src/debug/AndroidManifest.xml</a>:6</span>: <span class="message">On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute <code>android:fullBackupContent</code> to specify an <code>@xml</code> resource which configures which files to backup. More info: <a href="https://developer.android.com/training/backup/autosyncapi.html">https://developer.android.com/training/backup/autosyncapi.html</a></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 3 </span> <span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span> | |
| <span class="lineno"> 4 </span> <span class="prefix">xmlns:</span><span class="attribute">tools</span>=<span class="value">"http://schemas.android.com/tools"</span>> | |
| <span class="lineno"> 5 </span> | |
| <span class="caretline"><span class="lineno"> 6 </span> <span class="tag"><</span><span class="warning"><span class="tag">application</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 7 </span><span class="attribute"> </span><span class="prefix">tools:</span><span class="attribute">replace</span>=<span class="value">"android:name"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">name</span>=<span class="value">"org.mozilla.fenix.DebugFenixApplication"</span>/> | |
| </pre> | |
| <span class="location"><a href="../../src/main/AndroidManifest.xml">../../src/main/AndroidManifest.xml</a>:16</span>: <span class="message">On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute <code>android:fullBackupContent</code> to specify an <code>@xml</code> resource which configures which files to backup. More info: <a href="https://developer.android.com/training/backup/autosyncapi.html">https://developer.android.com/training/backup/autosyncapi.html</a></span><br /><pre class="errorlines"> | |
| <span class="lineno"> 13 </span> <span class="comment"><!-- Needed to prompt the user to give permission to install a downloaded apk --></span> | |
| <span class="lineno"> 14 </span> <span class="tag"><uses-permission-sdk-23</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">name</span>=<span class="value">"android.permission.REQUEST_INSTALL_PACKAGES"</span> /> | |
| <span class="lineno"> 15 </span> | |
| <span class="caretline"><span class="lineno"> 16 </span> <span class="tag"><</span><span class="warning"><span class="tag">application</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 17 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">allowBackup</span>=<span class="value">"true"</span> | |
| <span class="lineno"> 18 </span> <span class="prefix">android:</span><span class="attribute">icon</span>=<span class="value">"@mipmap/ic_launcher"</span> | |
| <span class="lineno"> 19 </span> <span class="prefix">android:</span><span class="attribute">label</span>=<span class="value">"@string/app_name"</span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationAllowBackup" style="display: none;"> | |
| The <code>allowBackup</code> attribute determines if an application's data can be backed up and restored. It is documented at <a href="http://developer.android.com/reference/android/R.attr.html#allowBackup">http://developer.android.com/reference/android/R.attr.html#allowBackup</a><br/> | |
| <br/> | |
| By default, this flag is set to <code>true</code>. When this flag is set to <code>true</code>, application data can be backed up and restored by the user using <code>adb backup</code> and <code>adb restore</code>.<br/> | |
| <br/> | |
| This may have security consequences for an application. <code>adb backup</code> allows users who have enabled USB debugging to copy application data off of the device. Once backed up, all application data can be read by the user. <code>adb restore</code> allows creation of application data from a source specified by the user. Following a restore, applications should not assume that the data, file permissions, and directory permissions were created by the application itself.<br/> | |
| <br/> | |
| Setting <code>allowBackup="false"</code> opts an application out of both backup and restore.<br/> | |
| <br/> | |
| To fix this warning, decide whether your application should support backup, and explicitly set <code>android:allowBackup=(true|false)"</code>.<br/> | |
| <br/> | |
| If not set to false, and if targeting API 23 or later, lint will also warn that you should set <code>android:fullBackupContent</code> to configure auto backup.<br/><div class="moreinfo">More info: <ul><li><a href="https://developer.android.com/training/backup/autosyncapi.html">https://developer.android.com/training/backup/autosyncapi.html</a> | |
| <li><a href="http://developer.android.com/reference/android/R.attr.html#allowBackup">http://developer.android.com/reference/android/R.attr.html#allowBackup</a> | |
| </ul></div>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "AllowBackup" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">AllowBackup</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Security</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 3/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationAllowBackupLink" onclick="reveal('explanationAllowBackup');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="AllowBackupCardLink" onclick="hideid('AllowBackupCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Performance"></a> | |
| <a name="StaticFieldLeak"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="StaticFieldLeakCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Static Field Leaks</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/utils/Settings.kt">../../src/main/java/org/mozilla/fenix/utils/Settings.kt</a>:19</span>: <span class="message">Do not place Android context classes in static fields (static reference to <code>Settings</code> which has field <code>appContext</code> pointing to <code>Context</code>); this is a memory leak (and also breaks Instant Run)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 16 </span><span class="keyword">class</span> Settings private constructor(context: Context) { | |
| <span class="lineno"> 17 </span> | |
| <span class="lineno"> 18 </span> companion <span class="keyword">object</span> { | |
| <span class="caretline"><span class="lineno"> 19 </span> <span class="warning"><span class="keyword">var</span> instance: Settings? = <span class="keyword">null</span></span> </span> | |
| <span class="lineno"> 20 </span> | |
| <span class="lineno"> 21 </span> <span class="annotation">@JvmStatic</span> | |
| <span class="lineno"> 22 </span> <span class="annotation">@Synchronized</span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationStaticFieldLeak" style="display: none;"> | |
| A static field will leak contexts.<br/> | |
| <br/> | |
| Non-static inner classes have an implicit reference to their outer class. If that outer class is for example a <code>Fragment</code> or <code>Activity</code>, then this reference means that the long-running handler/loader/task will hold a reference to the activity which prevents it from getting garbage collected.<br/> | |
| <br/> | |
| Similarly, direct field references to activities and fragments from these longer running instances can cause leaks.<br/> | |
| <br/> | |
| ViewModel classes should never point to Views or non-application Contexts.<br/>To suppress this error, use the issue id "StaticFieldLeak" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">StaticFieldLeak</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Performance</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 6/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationStaticFieldLeakLink" onclick="reveal('explanationStaticFieldLeak');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="StaticFieldLeakCardLink" onclick="hideid('StaticFieldLeakCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="VectorPath"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="VectorPathCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Long vector paths</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_help.xml">../../src/main/res/drawable/ic_help.xml</a>:12</span>: <span class="message">Very long vector path (1043 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"24"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"?attr/iconColor"</span> | |
| <span class="caretline"><span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">M12,2C6.4772,2 2,6.4772 2,12C2,17.5228 6.4772,22 12,22C17.5228,22 22,17.5228 22,12C21.9939,6.4797 17.5203,2.0061 12,2ZM12,20C7.5817,20 4,16.4183 4,12C4,7.5817 7.5817,4 12,4C16.4183,4 20,7.5817 20,12C19.995,16.4162 16.4162,19.995 12,20ZM12,15.536C11.1125,15.536 10.393,16.2555 10.393,17.143C10.393,18.0305 11.1125,18.75 12,18.75C12.8875,18.75 13.607,18.0305 13.607,17.143C13.6073,16.7167 13.438,16.3078 13.1366,16.0064C12.8352,15.705 12.4263,15.5357 12,15.536ZM12,5.732C10.9986,5.6611 10.0158,6.0281 9.3059,6.7379C8.5961,7.4478 8.2291,8.4306 8.3,9.432C8.3,10.0533 8.8037,10.557 9.425,10.557C10.0463,10.557 10.55,10.0533 10.55,9.432C10.55,8.15 11.323,7.985 11.996,7.985C12.6417,7.9359 13.2391,8.3294 13.449,8.942C13.5665,9.486 13.2775,10.036 12.763,10.248C11.6251,10.8409 10.9001,12.0062 10.871,13.289L10.871,13.722C10.871,14.3433 11.3747,14.847 11.996,14.847C12.6173,14.847 13.121,14.3433 13.121,13.722L13.121,13.246C13.1776,12.7796 13.4749,12.3772 13.904,12.186C15.2962,11.4597 16.0072,9.8723 15.622,8.35C15.1528,6.7536 13.663,5.6768 12,5.732Z</span></span><span class="value">"</span></span> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">strokeWidth</span>=<span class="value">"1"</span> /> | |
| <span class="lineno"> 14 </span><span class="tag"></vector></span> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_language.xml">../../src/main/res/drawable/ic_language.xml</a>:12</span>: <span class="message">Very long vector path (2039 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"24"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"?attr/iconColor"</span> | |
| <span class="caretline"><span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">m9.8944,3.5528c-0.247,-0.494 -0.8477,-0.6942 -1.3416,-0.4472 -0.494,0.247 -0.6942,0.8477 -0.4472,1.3416l0.2764,0.5528h-5.382c-0.5523,0 -1,0.4477 -1,1 0,0.5523 0.4477,1 1,1h6.9797c0.0141,0.0003 0.0281,0.0003 0.0423,0h1.6451c-0.7152,2.1364 -1.7998,3.9404 -2.9531,5.4106 -0.6679,-0.6568 -1.3242,-1.5526 -1.7777,-2.7617 -0.1939,-0.5171 -0.7703,-0.7791 -1.2874,-0.5852 -0.5171,0.1939 -0.7791,0.7703 -0.5852,1.2874 0.5893,1.5715 1.4593,2.7316 2.3389,3.5735 -0.1204,0.1263 -0.2404,0.2491 -0.3596,0.3683 -0.9566,0.9566 -1.8526,1.6731 -2.5061,2.1484 -0.3264,0.2373 -0.5911,0.4137 -0.7712,0.5289 -0.09,0.0576 -0.1588,0.0999 -0.2034,0.1269l-0.0371,0.0221 -0.0114,0.0068 -0.0099,0.0058 -0.0012,0.0006c-0.4786,0.2744 -0.6447,0.8846 -0.3709,1.3637 0.274,0.4796 0.8849,0.6462 1.3644,0.3721l0.06,-0.0351 -0.0584,0.0343 0.0022,-0.0013 0.0063,-0.0037 0.0202,-0.0118c0.0168,-0.0098 0.0695,-0.0414 0.0695,-0.0414 0.0589,-0.0356 0.1425,-0.087 0.2478,-0.1544 0.2105,-0.1348 0.5083,-0.3334 0.8694,-0.5961 0.7216,-0.5248 1.7005,-1.3082 2.7439,-2.3516 0.1773,-0.1773 0.3567,-0.3624 0.5373,-0.5552 0.3924,0.2405 0.7462,0.4174 1.0292,0.5432 0.2008,0.0892 0.367,0.1532 0.4874,0.1961 0.0602,0.0214 0.1091,0.0377 0.1453,0.0492 0.0181,0.0058 0.033,0.0104 0.0446,0.0139l0.0148,0.0044 0.0055,0.0016 0.0023,0.0007 0.0019,0.0005c0.531,0.1518 1.0845,-0.1557 1.2362,-0.6868 0.1514,-0.5299 -0.1537,-1.082 -0.6827,-1.235l-0.0025,-0.0007 -0.0119,-0.0038c-0.0159,-0.0051 -0.0436,-0.0142 -0.082,-0.0279 -0.0769,-0.0274 -0.1958,-0.0728 -0.3466,-0.1399 -0.147,-0.0653 -0.3232,-0.1507 -0.5194,-0.2593 1.3691,-1.7529 2.6634,-3.955 3.4472,-6.6081h2.2364c0.5523,0 1,-0.4477 1,-1 0,-0.5523 -0.4477,-1 -1,-1h-2.9786c-0.0148,-0.0003 -0.0296,-0.0003 -0.0443,0h-2.3591zM18.6261,16h-3.2522l1.6261,-4.4025zM19.3649,18 L20.2558,20.4119c0.1722,0.4662 0.6898,0.7046 1.156,0.5324 0.4663,-0.1723 0.7047,-0.6898 0.5324,-1.1561l-3.6309,-9.8302c-0.4506,-1.2199 -2.176,-1.2199 -2.6266,0l-3.6309,9.8302c-0.1723,0.4663 0.0661,0.9838 0.5324,1.1561 0.4662,0.1722 0.9838,-0.0662 1.156,-0.5324l0.8909,-2.4119z</span></span><span class="value">"</span> /></span> | |
| <span class="lineno"> 13 </span><span class="tag"></vector></span> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_link.xml">../../src/main/res/drawable/ic_link.xml</a>:11</span>: <span class="message">Very long vector path (1112 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"20"</span> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"20"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="caretline"><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">M2.47,5.53L5.515,2.485C5.7829,2.2172 6.2171,2.2172 6.485,2.485L10.685,6.685C11.4609,5.7001 11.3815,4.2915 10.5,3.4L7.837,0.734C6.863,-0.2399 5.284,-0.2399 4.31,0.734L0.766,4.279C0.2984,4.7465 0.0356,5.3807 0.0356,6.042C0.0356,6.7033 0.2984,7.3375 0.766,7.805L3.426,10.466C4.3,11.3366 5.68,11.4354 6.669,10.698L2.47,6.5C2.3409,6.3716 2.2683,6.1971 2.2683,6.015C2.2683,5.8329 2.3409,5.6584 2.47,5.53ZM19.27,12.163L19.266,12.163C20.2383,13.137 20.2379,14.7145 19.265,15.688L15.72,19.232C15.2525,19.6996 14.6183,19.9624 13.957,19.9624C13.2957,19.9624 12.6615,19.6996 12.194,19.232L9.533,16.572C8.6621,15.6985 8.5633,14.3186 9.301,13.33L13.501,17.53C13.6293,17.6588 13.8037,17.7312 13.9855,17.7312C14.1673,17.7312 14.3417,17.6588 14.47,17.53L17.512,14.479C17.7798,14.2111 17.7798,13.7769 17.512,13.509L13.312,9.309C14.2998,8.53 15.7139,8.612 16.605,9.5L19.27,12.163ZM14.163,12.718C14.542,13.1104 14.5366,13.7341 14.1508,14.1198C13.7651,14.5056 13.1414,14.511 12.749,14.132L5.829,7.212C5.559,6.9632 5.4471,6.5864 5.5375,6.2306C5.6279,5.8747 5.906,5.597 6.262,5.5071C6.6179,5.4172 6.9946,5.5297 7.243,5.8L14.163,12.718Z</span></span><span class="value">"</span></span> | |
| <span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">strokeWidth</span>=<span class="value">"1"</span> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"#2B20C1"</span> | |
| <span class="lineno"> 14 </span> <span class="prefix">android:</span><span class="attribute">fillType</span>=<span class="value">"evenOdd"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_permission.xml">../../src/main/res/drawable/ic_permission.xml</a>:11</span>: <span class="message">Very long vector path (983 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"24"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="caretline"><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">m12,20h5c1.6569,0 3,-1.3431 3,-3v-10c0,-1.6568 -1.3431,-3 -3,-3h-5zM7,2h10c2.7614,0 5,2.2386 5,5v10c0,2.7614 -2.2386,5 -5,5h-10c-2.7614,0 -5,-2.2386 -5,-5v-10c0,-2.7614 2.2386,-5 5,-5zM6.2143,15c0.0152,0.0001 0.0304,-0.0006 0.0455,-0.0021 0.154,-0.0135 0.2941,-0.0945 0.3827,-0.2212l3.0064,-4.9671c0.155,-0.2364 0.094,-0.5531 -0.1375,-0.7151s-0.55,-0.1107 -0.7189,0.1159l-2.6493,4.4563 -0.9971,-0.9971c-0.2052,-0.1981 -0.5313,-0.1953 -0.733,0.0064 -0.2017,0.2017 -0.2045,0.5278 -0.0064,0.7329l1.4379,1.4379c0.098,0.0981 0.231,0.1532 0.3697,0.1532zM13.1464,9.8535c-0.1952,-0.1953 -0.1952,-0.5118 0,-0.7071 0.1953,-0.1953 0.5119,-0.1953 0.7072,0l2.1464,2.1465 2.1464,-2.1465c0.1953,-0.1953 0.5119,-0.1953 0.7072,0 0.1952,0.1953 0.1952,0.5118 0,0.7071l-2.1465,2.1465 2.1465,2.1465c0.1952,0.1952 0.1952,0.5118 0,0.7071 -0.1953,0.1952 -0.5119,0.1952 -0.7072,0l-2.1464,-2.1465 -2.1464,2.1465c-0.1953,0.1952 -0.5119,0.1952 -0.7072,0 -0.1952,-0.1953 -0.1952,-0.5119 0,-0.7071l2.1465,-2.1465z</span></span><span class="value">"</span></span> | |
| <span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"?attr/iconColor"</span> /> | |
| <span class="lineno"> 13 </span><span class="tag"></vector></span> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_qr.xml">../../src/main/res/drawable/ic_qr.xml</a>:12</span>: <span class="message">Very long vector path (985 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"18"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"?attr/iconColor"</span> | |
| <span class="caretline"><span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">M14.5,0C16.433,0 18,1.567 18,3.5L18,6C18,6.5523 17.5523,7 17,7C16.4477,7 16,6.5523 16,6L16,3.5C16,2.6716 15.3284,2 14.5,2L12,2C11.4477,2 11,1.5523 11,1C11,0.4477 11.4477,0 12,0L14.5,0ZM17,11C17.5523,11 18,11.4477 18,12L18,14.5C18,16.433 16.433,18 14.5,18L12,18C11.4477,18 11,17.5523 11,17C11,16.4477 11.4477,16 12,16L14.5,16C15.3284,16 16,15.3284 16,14.5L16,12C16,11.4477 16.4477,11 17,11ZM6,16C6.5523,16 7,16.4477 7,17C7,17.5523 6.5523,18 6,18L3.5,18C1.567,18 0,16.433 0,14.5L0,12C0,11.4477 0.4477,11 1,11C1.5523,11 2,11.4477 2,12L2,14.5C2,15.3284 2.6716,16 3.5,16L6,16ZM1,7C0.4477,7 0,6.5523 0,6L0,3.5C0,1.567 1.567,0 3.5,0L6,0C6.5523,0 7,0.4477 7,1C7,1.5523 6.5523,2 6,2L3.5,2C2.6716,2 2,2.6716 2,3.5L2,6C2,6.5523 1.5523,7 1,7ZM12,4L14,4L14,6L12,6L12,4ZM4,6L4,4L8,4L8,6L8,8L6,8L4,8L4,6ZM12,8L14,8L14,10L12,10L12,8ZM6,10L8,10L8,12L6,12L6,10ZM12,12L14,12L14,14L12,14L12,12ZM8,12L10,12L10,14L8,14L8,12ZM4,12L6,12L6,14L4,14L4,12ZM10,10L12,10L12,12L10,12L10,10ZM10,6L12,6L12,8L10,8L10,6Z</span></span><span class="value">"</span></span> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">strokeWidth</span>=<span class="value">"1"</span> /> | |
| <span class="lineno"> 14 </span><span class="tag"></vector></span> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_screenshots.xml">../../src/main/res/drawable/ic_screenshots.xml</a>:12</span>: <span class="message">Very long vector path (1014 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"24"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"?attr/iconColor"</span> | |
| <span class="caretline"><span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">M6,7.1707C7.1652,7.5825 8,8.6938 8,10C8,10.2312 7.9738,10.4563 7.9243,10.6725L10.4097,12.5843L14.9445,9.4447C16.0797,8.6588 17.6371,8.942 18.423,10.0772L7.9279,17.3431C7.9751,17.5545 8,17.7743 8,18C8,19.6569 6.6569,21 5,21C3.3431,21 2,19.6569 2,18C2,16.3431 3.3431,15 5,15C5.5103,15 5.9909,15.1274 6.4116,15.3522L8.2516,14.0783L6.4,12.654C5.9821,12.8749 5.5056,13 5,13C3.3431,13 2,11.6569 2,10C2,8.6938 2.8348,7.5825 4,7.1707L4,6L6,6L6,7.1707ZM6,2L6,4L4,4C4,2.8954 4.8954,2 6,2ZM8,2L10,2L10,4L8,4L8,2ZM12,2L14,2L14,4L12,4L12,2ZM16,2L18,2L18,4L16,4L16,2ZM20,2C21.1046,2 22,2.8954 22,4L20,4L20,2ZM20,6L22,6L22,8L20,8L20,6ZM20,10L22,10L22,12L20,12L20,10ZM20,14L22,14C22,15.1046 21.1046,16 20,16L20,14ZM13.648,15.0753L18.7621,19.0092C17.9203,20.1036 16.3507,20.3083 15.2563,19.4665L11.49,16.5693L13.648,15.0753ZM5,11C5.5523,11 6,10.5523 6,10C6,9.4477 5.5523,9 5,9C4.4477,9 4,9.4477 4,10C4,10.5523 4.4477,11 5,11ZM5,19C5.5523,19 6,18.5523 6,18C6,17.4477 5.5523,17 5,17C4.4477,17 4,17.4477 4,18C4,18.5523 4.4477,19 5,19Z</span></span><span class="value">"</span></span> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">strokeWidth</span>=<span class="value">"1"</span> /> | |
| <span class="lineno"> 14 </span><span class="tag"></vector></span> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_share.xml">../../src/main/res/drawable/ic_share.xml</a>:11</span>: <span class="message">Very long vector path (935 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"24"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="caretline"><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">M8.92,14.7338C8.1902,15.5131 7.1519,16 6,16C3.7909,16 2,14.2091 2,12C2,9.7909 3.7909,8 6,8C7.0609,8 8.0783,8.4214 8.8284,9.1716C8.86,9.2031 8.8909,9.2351 8.9213,9.2676L13.1206,6.9785C13.0418,6.6654 13,6.3376 13,6C13,3.7909 14.7909,2 17,2C19.2091,2 21,3.7909 21,6C21,8.2091 19.2091,10 17,10C15.8481,10 14.8098,9.5131 14.08,8.7338L9.879,11.0237C9.9587,11.3403 10,11.668 10,12C10,12.3376 9.9582,12.6654 9.8794,12.9785L14.0787,15.2675C14.8087,14.4875 15.8474,14 17,14C19.2091,14 21,15.7909 21,18C21,20.2091 19.2091,22 17,22C14.7909,22 13,20.2091 13,18C13,17.6631 13.0417,17.3358 13.1201,17.0232L8.92,14.7338ZM17,4C15.8954,4 15,4.8954 15,6C15,7.1046 15.8954,8 17,8C18.1046,8 19,7.1046 19,6C19,4.8954 18.1046,4 17,4ZM6,10C4.8954,10 4,10.8954 4,12C4,13.1046 4.8954,14 6,14C7.1046,14 8,13.1046 8,12C8,10.8954 7.1046,10 6,10ZM17,16C15.8954,16 15,16.8954 15,18C15,19.1046 15.8954,20 17,20C18.1046,20 19,19.1046 19,18C19,16.8954 18.1046,16 17,16Z</span></span><span class="value">"</span></span> | |
| <span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">strokeWidth</span>=<span class="value">"1"</span> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"?attr/iconColor"</span> | |
| <span class="lineno"> 14 </span> <span class="prefix">android:</span><span class="attribute">fillType</span>=<span class="value">"nonZero"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_shortcuts.xml">../../src/main/res/drawable/ic_shortcuts.xml</a>:12</span>: <span class="message">Very long vector path (1027 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">viewportHeight</span>=<span class="value">"18"</span>> | |
| <span class="lineno"> 10 </span> <span class="tag"><path</span><span class="attribute"> | |
| </span><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">fillColor</span>=<span class="value">"?attr/iconColor"</span> | |
| <span class="caretline"><span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">pathData</span>=<span class="value">"</span><span class="warning"><span class="value">M7.0127,9.1576C7.0127,10.7366 7.6987,11.6946 8.8427,11.6946C10.0177,11.6946 10.7477,10.7256 10.7477,9.1576C10.7477,7.5906 10.0177,6.6206 8.8527,6.6206C7.6987,6.6206 7.0127,7.5676 7.0127,9.1576M17.9997,8.0916C17.9997,11.5206 16.3777,13.7316 13.7207,13.7316C12.3697,13.7316 11.3357,13.0786 11.0957,12.0216L10.9437,12.0216C10.4967,13.1106 9.5827,13.6986 8.3197,13.6986C6.0547,13.6986 4.5407,11.8586 4.5407,9.0926C4.5407,6.4466 6.0327,4.6386 8.2107,4.6386C9.3867,4.6386 10.3667,5.2266 10.7917,6.1846L10.9437,6.1846L10.9437,4.8786L13.1547,4.8786L13.1547,10.7046C13.1547,11.4556 13.5027,11.9346 14.1887,11.9346C15.2557,11.9346 15.9967,10.5736 15.9967,8.2546C15.9967,4.2906 13.2627,1.7316 9.1367,1.7316C4.9437,1.7316 2.0037,4.7586 2.0037,9.1366C2.0037,13.7196 5.0637,16.3986 9.5497,16.3986C10.7147,16.3986 11.9017,16.2466 12.5227,16.0176L12.5227,17.7606C11.6737,18.0116 10.5627,18.1636 9.3867,18.1636C3.8767,18.1636 -0.0003,14.7116 -0.0003,9.0816C-0.0003,3.6806 3.7787,0.0006 9.2127,0.0006C14.3737,0.0006 17.9997,3.2446 17.9997,8.0916</span></span><span class="value">"</span></span> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">strokeWidth</span>=<span class="value">"1"</span> /> | |
| <span class="lineno"> 14 </span><span class="tag"></vector></span> | |
| </pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationVectorPath" style="display: none;"> | |
| Using long vector paths is bad for performance. There are several ways to make the <code>pathData</code> shorter:<br/> | |
| * Using less precision<br/> | |
| * Removing some minor details<br/> | |
| * Using the Android Studio vector conversion tool<br/> | |
| * Rasterizing the image (converting to PNG)<br/>To suppress this error, use the issue id "VectorPath" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">VectorPath</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Performance</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 5/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationVectorPathLink" onclick="reveal('explanationVectorPath');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="VectorPathCardLink" onclick="hideid('VectorPathCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="Overdraw"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="OverdrawCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Overdraw: Painting regions more than once</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_crash_reporter.xml">../../src/main/res/layout/fragment_crash_reporter.xml</a>:11</span>: <span class="message">Possible overdraw: Root element paints background <code>@color/photonGrey10</code> with a theme that also paints a background (inferred theme is <code>@style/LightTheme</code>)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 8 </span> <span class="prefix">xmlns:</span><span class="attribute">tools</span>=<span class="value">"http://schemas.android.com/tools"</span> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"match_parent"</span> | |
| <span class="lineno"> 10 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"match_parent"</span> | |
| <span class="caretline"><span class="lineno"> 11 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"@color/photonGrey10"</span></span>> </span> | |
| <span class="lineno"> 12 </span> | |
| <span class="lineno"> 13 </span> <span class="tag"><ImageView</span><span class="attribute"> | |
| </span><span class="lineno"> 14 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/crash_tab_image"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_search.xml">../../src/main/res/layout/fragment_search.xml</a>:12</span>: <span class="message">Possible overdraw: Root element paints background <code>?attr/searchBackground</code> with a theme that also paints a background (inferred theme is <code>@style/LightTheme</code>)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"match_parent"</span> | |
| <span class="lineno"> 10 </span> <span class="prefix">tools:</span><span class="attribute">context</span>=<span class="value">".search.SearchFragment"</span> | |
| <span class="lineno"> 11 </span> <span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/search_layout"</span> | |
| <span class="caretline"><span class="lineno"> 12 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"?attr/searchBackground"</span></span>> </span> | |
| <span class="lineno"> 13 </span> | |
| <span class="lineno"> 14 </span> <span class="tag"><androidx.constraintlayout.widget.ConstraintLayout</span><span class="attribute"> | |
| </span><span class="lineno"> 15 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/toolbar_wrapper"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/search_engine_radio_button.xml">../../src/main/res/layout/search_engine_radio_button.xml</a>:10</span>: <span class="message">Possible overdraw: Root element paints background <code>?android:selectableItemBackground</code> with a theme that also paints a background (inferred theme is <code>@style/LightTheme</code>)</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"match_parent"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"@dimen/search_engine_radio_button_height"</span> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">layout_gravity</span>=<span class="value">"start"</span> | |
| <span class="caretline"><span class="lineno"> 10 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"?android:selectableItemBackground"</span></span> </span> | |
| <span class="lineno"> 11 </span> <span class="prefix">android:</span><span class="attribute">button</span>=<span class="value">"@null"</span> | |
| <span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">drawableStart</span>=<span class="value">"@drawable/ic_close"</span> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">drawableEnd</span>=<span class="value">"?android:attr/listChoiceIndicatorSingle"</span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationOverdraw" style="display: none;"> | |
| If you set a background drawable on a root view, then you should use a custom theme where the theme background is null. Otherwise, the theme background will be painted first, only to have your custom background completely cover it; this is called "overdraw".<br/> | |
| <br/> | |
| NOTE: This detector relies on figuring out which layouts are associated with which activities based on scanning the Java code, and it's currently doing that using an inexact pattern matching algorithm. Therefore, it can incorrectly conclude which activity the layout is associated with and then wrongly complain that a background-theme is hidden.<br/> | |
| <br/> | |
| If you want your custom background on multiple pages, then you should consider making a custom theme with your custom background and just using that theme instead of a root element background.<br/> | |
| <br/> | |
| Of course it's possible that your custom drawable is translucent and you want it to be mixed with the background. However, you will get better performance if you pre-mix the background with your drawable and use that resulting image or color as a custom theme background instead.<br/>To suppress this error, use the issue id "Overdraw" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Overdraw</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Performance</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 3/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationOverdrawLink" onclick="reveal('explanationOverdraw');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="OverdrawCardLink" onclick="hideid('OverdrawCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="UnusedResources"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="UnusedResourcesCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Unused resources</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/values/colors.xml">../../src/main/res/values/colors.xml</a>:6</span>: <span class="message">The resource <code>R.color.color_primary</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="lineno"> 5 </span><span class="tag"><resources></span> | |
| <span class="caretline"><span class="lineno"> 6 </span> <span class="tag"><color</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"color_primary"</span></span>>#544CD9<span class="tag"></color></span> </span> | |
| <span class="lineno"> 7 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"color_primary_dark"</span>>#202340<span class="tag"></color></span> | |
| <span class="lineno"> 8 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"color_accent"</span>>#D81B60<span class="tag"></color></span> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/values/colors.xml">../../src/main/res/values/colors.xml</a>:26</span>: <span class="message">The resource <code>R.color.url_box_view</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 23 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"search_stroke_private"</span>>#2d2e5f<span class="tag"></color></span> | |
| <span class="lineno"> 24 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"search_text"</span>>#0C0C0D<span class="tag"></color></span> | |
| <span class="lineno"> 25 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"off_white"</span>>#f9f9fa<span class="tag"></color></span> | |
| <span class="caretline"><span class="lineno"> 26 </span> <span class="tag"><color</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"url_box_view"</span></span>>#E9E9ED<span class="tag"></color></span> </span> | |
| <span class="lineno"> 27 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"session_border_color"</span>>#592ACB<span class="tag"></color></span> | |
| <span class="lineno"> 28 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"save_session_button_color"</span>>#352F65<span class="tag"></color></span> | |
| <span class="lineno"> 29 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"light_mode_bottom_sheet_text_color"</span>>#232749<span class="tag"></color></span></pre> | |
| <span class="location"><a href="../../src/main/res/values/colors.xml">../../src/main/res/values/colors.xml</a>:42</span>: <span class="message">The resource <code>R.color.session_list_header</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 39 </span> | |
| <span class="lineno"> 40 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"session_list_empty_bg"</span>>#1A665BFD<span class="tag"></color></span> | |
| <span class="lineno"> 41 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"session_list_empty_fg"</span>>#544CD9<span class="tag"></color></span> | |
| <span class="caretline"><span class="lineno"> 42 </span> <span class="tag"><color</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"session_list_header"</span></span>>#6D6D6E<span class="tag"></color></span> </span> | |
| <span class="lineno"> 43 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"session_list_private_header"</span>>#4a4671<span class="tag"></color></span> | |
| <span class="lineno"> 44 </span> <span class="tag"><color</span><span class="attribute"> name</span>=<span class="value">"delete_session_button_background"</span>>#e5e5ea<span class="tag"></color></span> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/values/dimens.xml">../../src/main/res/values/dimens.xml</a>:10</span>: <span class="message">The resource <code>R.dimen.mozac_browser_menu_corner_radius</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 7 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"crash_reporter_close_tab_button_bottom_margin"</span>>24dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 8 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"glyph_button_height"</span>>48dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 9 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"glyph_button_width"</span>>48dp<span class="tag"></dimen></span> | |
| <span class="caretline"><span class="lineno"> 10 </span> <span class="tag"><dimen</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"mozac_browser_menu_corner_radius"</span></span>>14dp<span class="tag"></dimen></span> </span> | |
| <span class="lineno"> 11 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"toolbar_elevation"</span>>7dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 12 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"library_item_height"</span>>56dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 13 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"library_item_icon_height"</span>>48dp<span class="tag"></dimen></span></pre> | |
| <span class="location"><a href="../../src/main/res/values/dimens.xml">../../src/main/res/values/dimens.xml</a>:22</span>: <span class="message">The resource <code>R.dimen.radio_button_drawable_padding</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 19 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"tab_corner_radius"</span>>8dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 20 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"preference_icon_drawable_size"</span>>24dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 21 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"search_engine_radio_button_height"</span>>48dp<span class="tag"></dimen></span> | |
| <span class="caretline"><span class="lineno"> 22 </span> <span class="tag"><dimen</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"radio_button_drawable_padding"</span></span>>32dp<span class="tag"></dimen></span> </span> | |
| <span class="lineno"> 23 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"radio_button_padding_horizontal"</span>>16dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 24 </span> <span class="tag"><dimen</span><span class="attribute"> name</span>=<span class="value">"radio_button_padding_vertical"</span>>12dp<span class="tag"></dimen></span> | |
| <span class="lineno"> 25 </span><span class="tag"></resources></span></pre> | |
| <button class="mdl-button mdl-js-button mdl-button--primary" id="UnusedResourcesDivLink" onclick="reveal('UnusedResourcesDiv');" />+ 14 More Occurrences...</button> | |
| <div id="UnusedResourcesDiv" style="display: none"> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_bookmark_filled.xml">../../src/main/res/drawable/ic_bookmark_filled.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.ic_bookmark_filled</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><vector</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">width</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">height</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_download.xml">../../src/main/res/drawable/ic_download.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.ic_download</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><vector</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">width</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">height</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_history.xml">../../src/main/res/drawable/ic_history.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.ic_history</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><vector</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">width</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">height</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_home.xml">../../src/main/res/drawable/ic_home.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.ic_home</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><vector</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">width</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">height</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_screenshots.xml">../../src/main/res/drawable/ic_screenshots.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.ic_screenshots</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><vector</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">width</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">height</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_send.xml">../../src/main/res/drawable/ic_send.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.ic_send</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><vector</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">width</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">height</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_session_restore.xml">../../src/main/res/drawable/ic_session_restore.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.ic_session_restore</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><vector</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">width</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">height</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">viewportWidth</span>=<span class="value">"24"</span></pre> | |
| <span class="location"><a href="../../src/main/res/values/preference_keys.xml">../../src/main/res/values/preference_keys.xml</a>:21</span>: <span class="message">The resource <code>R.string.pref_key_theme</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 18 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"pref_key_account"</span> <span class="attribute">translatable</span>=<span class="value">"false"</span>>pref_key_account<span class="tag"></string></span> | |
| <span class="lineno"> 19 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"pref_key_sign_in"</span> <span class="attribute">translatable</span>=<span class="value">"false"</span>>pref_key_sign_in<span class="tag"></string></span> | |
| <span class="lineno"> 20 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"pref_key_private_mode"</span> <span class="attribute">translatable</span>=<span class="value">"false"</span>>pref_key_private_mode<span class="tag"></string></span> | |
| <span class="caretline"><span class="lineno"> 21 </span> <span class="tag"><string</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"pref_key_theme"</span></span> <span class="attribute">translatable</span>=<span class="value">"false"</span>>pref_key_theme<span class="tag"></string></span> </span> | |
| <span class="lineno"> 22 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"pref_key_leakcanary"</span> <span class="attribute">translatable</span>=<span class="value">"false"</span>>pref_key_leakcanary<span class="tag"></string></span> | |
| <span class="lineno"> 23 </span> | |
| <span class="lineno"> 24 </span> <span class="comment"><!-- Data Choices --></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/session_background.xml">../../src/main/res/drawable/session_background.xml</a>:6</span>: <span class="message">The resource <code>R.drawable.session_background</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="lineno"> 5 </span> | |
| <span class="caretline"><span class="lineno"> 6 </span><span class="warning"><span class="tag"><shape</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span> <span class="prefix">android:</span><span class="attribute">shape</span>=<span class="value">"rectangle"</span> ></span> </span> | |
| <span class="lineno"> 7 </span> <span class="tag"><solid</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"@color/photonGrey40"</span> /> | |
| <span class="lineno"> 8 </span> <span class="tag"><corners</span><span class="attribute"> | |
| </span><span class="lineno"> 9 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">bottomLeftRadius</span>=<span class="value">"8dp"</span></pre> | |
| <span class="location"><a href="../../src/main/res/values/strings.xml">../../src/main/res/values/strings.xml</a>:27</span>: <span class="message">The resource <code>R.string.private_browsing_delete_session</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 24 </span> <span class="comment"><!-- Explanation for private browsing displayed to users on home view when they first enable private mode --></span> | |
| <span class="lineno"> 25 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"private_browsing_explanation"</span>>Fenix clears your search and browsing history when you close your private session. While this doesn\'t make you anonymous to websites or your internet service provider, it makes it easier to keep what you do online private from anyone else who uses this device.\n\nCommon myths about private browsing<span class="tag"></string></span> | |
| <span class="lineno"> 26 </span> <span class="comment"><!-- Delete session button to erase your history in a private session --></span> | |
| <span class="caretline"><span class="lineno"> 27 </span> <span class="tag"><string</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"private_browsing_delete_session"</span></span>>Delete session<span class="tag"></string></span> </span> | |
| <span class="lineno"> 28 </span> | |
| <span class="lineno"> 29 </span> <span class="comment"><!-- Browser Fragment --></span> | |
| <span class="lineno"> 30 </span> <span class="comment"><!-- Content description (not visible, for screen readers etc.): Navigate home --></span></pre> | |
| <span class="location"><a href="../../src/main/res/values/strings.xml">../../src/main/res/values/strings.xml</a>:75</span>: <span class="message">The resource <code>R.string.settings</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 72 </span> | |
| <span class="lineno"> 73 </span> <span class="comment"><!-- Settings Fragment --></span> | |
| <span class="lineno"> 74 </span> <span class="comment"><!-- Title for the settings page--></span> | |
| <span class="caretline"><span class="lineno"> 75 </span> <span class="tag"><string</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"settings"</span></span>>Settings<span class="tag"></string></span> </span> | |
| <span class="lineno"> 76 </span> | |
| <span class="lineno"> 77 </span> <span class="comment"><!-- Preferences --></span> | |
| <span class="lineno"> 78 </span> <span class="comment"><!-- Preference category for basic settings --></span></pre> | |
| <span class="location"><a href="../../src/main/res/values/strings.xml">../../src/main/res/values/strings.xml</a>:206</span>: <span class="message">The resource <code>R.string.session_item_delete</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 203 </span> <span class="comment"><!-- Text for the button to delete a session --></span> | |
| <span class="lineno"> 204 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"session_delete"</span>>Delete Session<span class="tag"></string></span> | |
| <span class="lineno"> 205 </span> <span class="comment"><!-- Text for the button to delete a single session --></span> | |
| <span class="caretline"><span class="lineno"> 206 </span> <span class="tag"><string</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"session_item_delete"</span></span>>Delete<span class="tag"></string></span> </span> | |
| <span class="lineno"> 207 </span> <span class="comment"><!-- Text to tell the user how many more tabs this session has. | |
| </span><span class="lineno"> 208 </span><span class="comment"> The first parameter is how many extra tabs the session has. --></span> | |
| <span class="lineno"> 209 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"session_items_more"</span>>%1$d sites…<span class="tag"></string></span></pre> | |
| <span class="location"><a href="../../src/main/res/values/strings.xml">../../src/main/res/values/strings.xml</a>:209</span>: <span class="message">The resource <code>R.string.session_items_more</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 206 </span> <span class="tag"><string</span><span class="attribute"> name</span>=<span class="value">"session_item_delete"</span>>Delete<span class="tag"></string></span> | |
| <span class="lineno"> 207 </span> <span class="comment"><!-- Text to tell the user how many more tabs this session has. | |
| </span><span class="lineno"> 208 </span><span class="comment"> The first parameter is how many extra tabs the session has. --></span> | |
| <span class="caretline"><span class="lineno"> 209 </span> <span class="tag"><string</span><span class="attribute"> </span><span class="warning"><span class="attribute">name</span>=<span class="value">"session_items_more"</span></span>>%1$d sites…<span class="tag"></string></span> </span> | |
| <span class="lineno"> 210 </span> | |
| <span class="lineno"> 211 </span> <span class="comment"><!-- History --></span> | |
| <span class="lineno"> 212 </span> <span class="comment"><!-- Text for the button to clear all history --></span></pre> | |
| <span class="location"><a href="../../src/main/res/drawable/url_background.xml">../../src/main/res/drawable/url_background.xml</a>:5</span>: <span class="message">The resource <code>R.drawable.url_background</code> appears to be unused</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 2 </span><span class="comment"><!-- This Source Code Form is subject to the terms of the Mozilla Public | |
| </span><span class="lineno"> 3 </span><span class="comment"> - License, v. 2.0. If a copy of the MPL was not distributed with this | |
| </span><span class="lineno"> 4 </span><span class="comment"> - file, You can obtain one at http://mozilla.org/MPL/2.0/. --></span> | |
| <span class="caretline"><span class="lineno"> 5 </span><span class="warning"><span class="tag"><shape</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span>></span> </span> | |
| <span class="lineno"> 6 </span> <span class="tag"><solid</span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">color</span>=<span class="value">"@color/url_box_view"</span> /> | |
| <span class="lineno"> 7 </span> | |
| <span class="lineno"> 8 </span> <span class="tag"><corners</span></pre> | |
| </div> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationUnusedResources" style="display: none;"> | |
| Unused resources make applications larger and slow down builds.<br/> | |
| <br/> | |
| The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead.<br/> | |
| <br/> | |
| You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests=true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests=true.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "UnusedResources" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">UnusedResources</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Performance</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 3/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationUnusedResourcesLink" onclick="reveal('explanationUnusedResources');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="UnusedResourcesCardLink" onclick="hideid('UnusedResourcesCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="UselessParent"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="UselessParentCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Useless parent layout</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_home.xml">../../src/main/res/layout/fragment_home.xml</a>:106</span>: <span class="message">This <code>LinearLayout</code> layout or its <code>LinearLayout</code> parent is possibly useless</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 103 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span> | |
| <span class="lineno"> 104 </span> <span class="prefix">android:</span><span class="attribute">orientation</span>=<span class="value">"vertical"</span> | |
| <span class="lineno"> 105 </span> <span class="prefix">android:</span><span class="attribute">descendantFocusability</span>=<span class="value">"blocksDescendants"</span>> | |
| <span class="caretline"><span class="lineno"> 106 </span> <span class="tag"><</span><span class="warning"><span class="tag">LinearLayout</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 107 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/private_session_description_wrapper"</span> | |
| <span class="lineno"> 108 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"match_parent"</span> | |
| <span class="lineno"> 109 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationUselessParent" style="display: none;"> | |
| A layout with children that has no siblings, is not a scrollview or a root layout, and does not have a background, can be removed and have its children moved directly into the parent for a flatter and more efficient layout hierarchy.<br/>To suppress this error, use the issue id "UselessParent" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">UselessParent</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Performance</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 2/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationUselessParentLink" onclick="reveal('explanationUselessParent');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="UselessParentCardLink" onclick="hideid('UselessParentCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="UnusedNamespace"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="UnusedNamespaceCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Unused namespace</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_home.xml">../../src/main/res/layout/fragment_home.xml</a>:113</span>: <span class="message">Unused namespace declaration xmlns:android; already declared on the root element</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 110 </span> <span class="prefix">android:</span><span class="attribute">layout_margin</span>=<span class="value">"16dp"</span> | |
| <span class="lineno"> 111 </span> <span class="prefix">android:</span><span class="attribute">orientation</span>=<span class="value">"vertical"</span> | |
| <span class="lineno"> 112 </span> <span class="prefix">android:</span><span class="attribute">visibility</span>=<span class="value">"gone"</span>> | |
| <span class="caretline"><span class="lineno"> 113 </span> <span class="tag"><TextView</span><span class="attribute"> </span><span class="warning"><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span></span> </span> | |
| <span class="lineno"> 114 </span> <span class="prefix">android:</span><span class="attribute">textAppearance</span>=<span class="value">"@style/TextAppearance.MaterialComponents.Headline6"</span> | |
| <span class="lineno"> 115 </span> <span class="prefix">android:</span><span class="attribute">textColor</span>=<span class="value">"?attr/toolbarTextColor"</span> | |
| <span class="lineno"> 116 </span> <span class="prefix">android:</span><span class="attribute">text</span>=<span class="value">"@string/private_browsing_title"</span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationUnusedNamespace" style="display: none;"> | |
| Unused namespace declarations take up space and require processing that is not necessary<br/>To suppress this error, use the issue id "UnusedNamespace" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">UnusedNamespace</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Performance</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 1/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationUnusedNamespaceLink" onclick="reveal('explanationUnusedNamespace');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="UnusedNamespaceCardLink" onclick="hideid('UnusedNamespaceCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Usability:Icons"></a> | |
| <a name="IconLocation"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="IconLocationCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Image defined in density-independent drawable folder</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/drawable/ic_error_session_crashed.png">../../src/main/res/drawable/ic_error_session_crashed.png</a></span>: <img class="embedimage" align="right" src="../../src/main/res/drawable/ic_error_session_crashed.png" /><span class="message">Found bitmap drawable <code>res/drawable/ic_error_session_crashed.png</code> in densityless folder</span><br clear="right"/> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationIconLocation" style="display: none;"> | |
| The res/drawable folder is intended for density-independent graphics such as shapes defined in XML. For bitmaps, move it to <code>drawable-mdpi</code> and consider providing higher and lower resolution versions in <code>drawable-ldpi</code>, <code>drawable-hdpi</code> and <code>drawable-xhdpi</code>. If the icon <b>really</b> is density independent (for example a solid color) you can place it in <code>drawable-nodpi</code>.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/guide/practices/screens_support.html">http://developer.android.com/guide/practices/screens_support.html</a> | |
| </div>To suppress this error, use the issue id "IconLocation" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">IconLocation</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Icons</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Usability</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 5/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationIconLocationLink" onclick="reveal('explanationIconLocation');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="IconLocationCardLink" onclick="hideid('IconLocationCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="IconDensities"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="IconDensitiesCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Icon densities validation</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/drawable-hdpi">../../src/main/res/drawable-hdpi</a></span>: <span class="message">Missing the following drawables in <code>drawable-hdpi</code>: ic_logo_wordmark_white.png (found in drawable-xxxhdpi)</span><br /> | |
| <span class="location"><a href="../../src/main/res/drawable-mdpi">../../src/main/res/drawable-mdpi</a></span>: <span class="message">Missing the following drawables in <code>drawable-mdpi</code>: ic_logo_wordmark_white.png (found in drawable-xxxhdpi)</span><br /> | |
| <span class="location"><a href="../../src/main/res/drawable-xhdpi">../../src/main/res/drawable-xhdpi</a></span>: <span class="message">Missing the following drawables in <code>drawable-xhdpi</code>: ic_logo_wordmark_white.png (found in drawable-xxxhdpi)</span><br /> | |
| <span class="location"><a href="../../src/main/res/drawable-xxhdpi">../../src/main/res/drawable-xxhdpi</a></span>: <span class="message">Missing the following drawables in <code>drawable-xxhdpi</code>: ic_logo_wordmark_white.png (found in drawable-xxxhdpi)</span><br /> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationIconDensities" style="display: none;"> | |
| Icons will look best if a custom version is provided for each of the major screen density classes (low, medium, high, extra high). This lint check identifies icons which do not have complete coverage across the densities.<br/> | |
| <br/> | |
| Low density is not really used much anymore, so this check ignores the ldpi density. To force lint to include it, set the environment variable <code>ANDROID_LINT_INCLUDE_LDPI=true</code>. For more information on current density usage, see <a href="http://developer.android.com/resources/dashboard/screens.html">http://developer.android.com/resources/dashboard/screens.html</a><br/><div class="moreinfo">More info: <a href="http://developer.android.com/guide/practices/screens_support.html">http://developer.android.com/guide/practices/screens_support.html</a> | |
| </div>To suppress this error, use the issue id "IconDensities" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">IconDensities</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Icons</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Usability</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 4/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationIconDensitiesLink" onclick="reveal('explanationIconDensities');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="IconDensitiesCardLink" onclick="hideid('IconDensitiesCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Usability"></a> | |
| <a name="GoogleAppIndexingWarning"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="GoogleAppIndexingWarningCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Missing support for Firebase App Indexing</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/debug/AndroidManifest.xml">../../src/debug/AndroidManifest.xml</a>:6</span>: <span class="message">App is not indexable by Google Search; consider adding at least one Activity with an ACTION-VIEW intent filter. See issue explanation for more details.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 3 </span> <span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span> | |
| <span class="lineno"> 4 </span> <span class="prefix">xmlns:</span><span class="attribute">tools</span>=<span class="value">"http://schemas.android.com/tools"</span>> | |
| <span class="lineno"> 5 </span> | |
| <span class="caretline"><span class="lineno"> 6 </span> <span class="warning"><span class="tag"><application</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 7 </span><span class="attribute"> </span><span class="prefix">tools:</span><span class="attribute">replace</span>=<span class="value">"android:name"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">name</span>=<span class="value">"org.mozilla.fenix.DebugFenixApplication"</span>/> | |
| </pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationGoogleAppIndexingWarning" style="display: none;"> | |
| Adds URLs to get your app into the Google index, to get installs and traffic to your app from Google Search.<br/><div class="moreinfo">More info: <a href="https://g.co/AppIndexing/AndroidStudio">https://g.co/AppIndexing/AndroidStudio</a> | |
| </div>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "GoogleAppIndexingWarning" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">GoogleAppIndexingWarning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Usability</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 5/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationGoogleAppIndexingWarningLink" onclick="reveal('explanationGoogleAppIndexingWarning');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="GoogleAppIndexingWarningCardLink" onclick="hideid('GoogleAppIndexingWarningCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="AlwaysShowAction"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="AlwaysShowActionCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Usage of showAsAction=always</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/menu/library_menu.xml">../../src/main/res/menu/library_menu.xml</a>:13</span>: <span class="message">Prefer "<code>ifRoom</code>" instead of "<code>always</code>"</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 10 </span> <span class="prefix">android:</span><span class="attribute">icon</span>=<span class="value">"@drawable/ic_search"</span> | |
| <span class="lineno"> 11 </span> <span class="prefix">android:</span><span class="attribute">iconTint</span>=<span class="value">"?attr/iconColor"</span> | |
| <span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">title</span>=<span class="value">"@string/library_search"</span> | |
| <span class="caretline"><span class="lineno"> 13 </span> <span class="warning"><span class="prefix">app:</span><span class="attribute">showAsAction</span>=<span class="value">"always"</span></span> </span> | |
| <span class="lineno"> 14 </span> <span class="prefix">tools:</span><span class="attribute">targetApi</span>=<span class="value">"o"</span> /> | |
| <span class="lineno"> 15 </span> <span class="tag"><item</span><span class="attribute"> | |
| </span><span class="lineno"> 16 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/libraryClose"</span></pre> | |
| <ul></ul><button id="Location1DivLink" onclick="reveal('Location1Div');" />+ 1 Additional Locations...</button> | |
| <div id="Location1Div" style="display: none"> | |
| Additional locations: <ul> | |
| <li> <span class="location"><a href="../../src/main/res/menu/library_menu.xml">../../src/main/res/menu/library_menu.xml</a>:20</span> | |
| </ul> | |
| </div><br/><br/> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationAlwaysShowAction" style="display: none;"> | |
| Using <code>showAsAction="always"</code> in menu XML, or <code>MenuItem.SHOW_AS_ACTION_ALWAYS</code> in Java code is usually a deviation from the user interface style guide.Use <code>ifRoom</code> or the corresponding <code>MenuItem.SHOW_AS_ACTION_IF_ROOM</code> instead.<br/> | |
| <br/> | |
| If <code>always</code> is used sparingly there are usually no problems and behavior is roughly equivalent to <code>ifRoom</code> but with preference over other <code>ifRoom</code> items. Using it more than twice in the same menu is a bad idea.<br/> | |
| <br/> | |
| This check looks for menu XML files that contain more than two <code>always</code> actions, or some <code>always</code> actions and no <code>ifRoom</code> actions. In Java code, it looks for projects that contain references to <code>MenuItem.SHOW_AS_ACTION_ALWAYS</code> and no references to <code>MenuItem.SHOW_AS_ACTION_IF_ROOM</code>.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/design/patterns/actionbar.html">http://developer.android.com/design/patterns/actionbar.html</a> | |
| </div>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "AlwaysShowAction" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">AlwaysShowAction</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Usability</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 3/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationAlwaysShowActionLink" onclick="reveal('explanationAlwaysShowAction');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="AlwaysShowActionCardLink" onclick="hideid('AlwaysShowActionCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Accessibility"></a> | |
| <a name="ContentDescription"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="ContentDescriptionCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Image without contentDescription</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_crash_reporter.xml">../../src/main/res/layout/fragment_crash_reporter.xml</a>:13</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 10 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"match_parent"</span> | |
| <span class="lineno"> 11 </span> <span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"@color/photonGrey10"</span>> | |
| <span class="lineno"> 12 </span> | |
| <span class="caretline"><span class="lineno"> 13 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 14 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/crash_tab_image"</span> | |
| <span class="lineno"> 15 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"0dp"</span> | |
| <span class="lineno"> 16 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"0dp"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/fragment_home.xml">../../src/main/res/layout/fragment_home.xml</a>:40</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 37 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintEnd_toStartOf</span>=<span class="value">"@id/menuButton"</span> | |
| <span class="lineno"> 38 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintTop_toTopOf</span>=<span class="value">"@id/menuButton"</span> /> | |
| <span class="lineno"> 39 </span> | |
| <span class="caretline"><span class="lineno"> 40 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 41 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/wordmark"</span> | |
| <span class="lineno"> 42 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"wrap_content"</span> | |
| <span class="lineno"> 43 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/history_list_item.xml">../../src/main/res/layout/history_list_item.xml</a>:23</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 20 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintStart_toStartOf</span>=<span class="value">"parent"</span> | |
| <span class="lineno"> 21 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintTop_toTopOf</span>=<span class="value">"@id/history_title"</span> /> | |
| <span class="lineno"> 22 </span> | |
| <span class="caretline"><span class="lineno"> 23 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 24 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/history_favicon"</span> | |
| <span class="lineno"> 25 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"@dimen/history_favicon_width_height"</span> | |
| <span class="lineno"> 26 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"@dimen/history_favicon_width_height"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/library_list_item.xml">../../src/main/res/layout/library_list_item.xml</a>:12</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 9 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"@dimen/library_item_height"</span> | |
| <span class="lineno"> 10 </span> <span class="prefix">tools:</span><span class="attribute">parentTag</span>=<span class="value">"androidx.constraintlayout.widget.ConstraintLayout"</span>> | |
| <span class="lineno"> 11 </span> | |
| <span class="caretline"><span class="lineno"> 12 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 13 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/libraryIcon"</span> | |
| <span class="lineno"> 14 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"@dimen/library_item_icon_height"</span> | |
| <span class="lineno"> 15 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"@dimen/library_item_icon_height"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/session_item.xml">../../src/main/res/layout/session_item.xml</a>:21</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 18 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span> | |
| <span class="lineno"> 19 </span> <span class="prefix">android:</span><span class="attribute">paddingBottom</span>=<span class="value">"@dimen/session_card_padding"</span>> | |
| <span class="lineno"> 20 </span> | |
| <span class="caretline"><span class="lineno"> 21 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 22 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/session_card_thumbnail"</span> | |
| <span class="lineno"> 23 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"wrap_content"</span> | |
| <span class="lineno"> 24 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span></pre> | |
| <button class="mdl-button mdl-js-button mdl-button--primary" id="ContentDescriptionDivLink" onclick="reveal('ContentDescriptionDiv');" />+ 4 More Occurrences...</button> | |
| <div id="ContentDescriptionDiv" style="display: none"> | |
| <span class="location"><a href="../../src/main/res/layout/session_item.xml">../../src/main/res/layout/session_item.xml</a>:69</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 66 </span> <span class="prefix">app:</span><span class="attribute">barrierDirection</span>=<span class="value">"bottom"</span> | |
| <span class="lineno"> 67 </span> <span class="prefix">app:</span><span class="attribute">constraint_referenced_ids</span>=<span class="value">"session_card_thumbnail,session_card_extras"</span> /> | |
| <span class="lineno"> 68 </span> | |
| <span class="caretline"><span class="lineno"> 69 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageButton</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 70 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/session_card_overflow_button"</span> | |
| <span class="lineno"> 71 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"@dimen/glyph_button_width"</span> | |
| <span class="lineno"> 72 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"@dimen/glyph_button_height"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/session_list_empty.xml">../../src/main/res/layout/session_list_empty.xml</a>:13</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 10 </span> <span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"@drawable/session_list_empty_bg"</span> | |
| <span class="lineno"> 11 </span> <span class="prefix">android:</span><span class="attribute">padding</span>=<span class="value">"16dp"</span>> | |
| <span class="lineno"> 12 </span> | |
| <span class="caretline"><span class="lineno"> 13 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 14 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/imageView"</span> | |
| <span class="lineno"> 15 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"wrap_content"</span> | |
| <span class="lineno"> 16 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/sign_in_preference.xml">../../src/main/res/layout/sign_in_preference.xml</a>:16</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 13 </span> <span class="prefix">android:</span><span class="attribute">elevation</span>=<span class="value">"4dp"</span> | |
| <span class="lineno"> 14 </span> <span class="prefix">android:</span><span class="attribute">padding</span>=<span class="value">"16dp"</span>> | |
| <span class="lineno"> 15 </span> | |
| <span class="caretline"><span class="lineno"> 16 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 17 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/imageView"</span> | |
| <span class="lineno"> 18 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"44dp"</span> | |
| <span class="lineno"> 19 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"60dp"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/tab_list_row.xml">../../src/main/res/layout/tab_list_row.xml</a>:58</span>: <span class="message">Missing <code>contentDescription</code> attribute on image</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 55 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintEnd_toEndOf</span>=<span class="value">"parent"</span> | |
| <span class="lineno"> 56 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintTop_toTopOf</span>=<span class="value">"@id/text_url"</span> /> | |
| <span class="lineno"> 57 </span> | |
| <span class="caretline"><span class="lineno"> 58 </span> <span class="tag"><</span><span class="warning"><span class="tag">ImageView</span></span> </span><span class="attribute"> | |
| </span><span class="lineno"> 59 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/tab_background"</span> | |
| <span class="lineno"> 60 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"0dp"</span> | |
| <span class="lineno"> 61 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"100dp"</span></pre> | |
| </div> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationContentDescription" style="display: none;"> | |
| Non-textual widgets like ImageViews and ImageButtons should use the <code>contentDescription</code> attribute to specify a textual description of the widget such that screen readers and other accessibility tools can adequately describe the user interface.<br/> | |
| <br/> | |
| Note that elements in application screens that are purely decorative and do not provide any content or enable a user action should not have accessibility content descriptions. In this case, just suppress the lint warning with a tools:ignore="ContentDescription" attribute.<br/> | |
| <br/> | |
| Note that for text fields, you should not set both the <code>hint</code> and the <code>contentDescription</code> attributes since the hint will never be shown. Just set the <code>hint</code>. See <a href="http://developer.android.com/guide/topics/ui/accessibility/checklist.html#special-cases">http://developer.android.com/guide/topics/ui/accessibility/checklist.html#special-cases</a>.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "ContentDescription" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">ContentDescription</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Accessibility</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 3/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationContentDescriptionLink" onclick="reveal('explanationContentDescription');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="ContentDescriptionCardLink" onclick="hideid('ContentDescriptionCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Internationalization"></a> | |
| <a name="SetTextI18n"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="SetTextI18nCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">TextView Internationalization</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/java/org/mozilla/fenix/home/sessions/SessionsAdapter.kt">../../src/main/java/org/mozilla/fenix/home/sessions/SessionsAdapter.kt</a>:79</span>: <span class="message">String literal in <code>setText</code> can not be translated. Use Android resources instead.</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 76 </span> | |
| <span class="lineno"> 77 </span> override <span class="keyword">fun</span> onBindViewHolder(holder: RecyclerView.ViewHolder, position: Int) { | |
| <span class="lineno"> 78 </span> <span class="keyword">when</span> (holder) { | |
| <span class="caretline"><span class="lineno"> 79 </span> <span class="keyword">is</span> HeaderViewHolder -> holder.headerText.text = <span class="string">"</span><span class="warning"><span class="string">Today</span></span><span class="string">"</span> </span> | |
| <span class="lineno"> 80 </span> <span class="keyword">is</span> SessionItemViewHolder -> holder.bind(state.items[position - <span class="number">1</span>]) | |
| <span class="lineno"> 81 </span> } | |
| <span class="lineno"> 82 </span> } | |
| </pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationSetTextI18n" style="display: none;"> | |
| When calling <code>TextView#setText</code><br/> | |
| * Never call <code>Number#toString()</code> to format numbers; it will not handle fraction separators and locale-specific digits properly. Consider using <code>String#format</code> with proper format specifications (<code>%d</code> or <code>%f</code>) instead.<br/> | |
| * Do not pass a string literal (e.g. "Hello") to display text. Hardcoded text can not be properly translated to other languages. Consider using Android resource strings instead.<br/> | |
| * Do not build messages by concatenating text chunks. Such messages can not be properly translated.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/guide/topics/resources/localization.html">http://developer.android.com/guide/topics/resources/localization.html</a> | |
| </div>To suppress this error, use the issue id "SetTextI18n" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">SetTextI18n</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Internationalization</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 6/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationSetTextI18nLink" onclick="reveal('explanationSetTextI18n');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="SetTextI18nCardLink" onclick="hideid('SetTextI18nCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section><a name="HardcodedText"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="HardcodedTextCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Hardcoded text</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/layout/sign_in_preference.xml">../../src/main/res/layout/sign_in_preference.xml</a>:34</span>: <span class="message">Hardcoded string "Title", should use <code>@string</code> resource</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 31 </span> <span class="prefix">android:</span><span class="attribute">ellipsize</span>=<span class="value">"none"</span> | |
| <span class="lineno"> 32 </span> <span class="prefix">android:</span><span class="attribute">scrollHorizontally</span>=<span class="value">"false"</span> | |
| <span class="lineno"> 33 </span> <span class="prefix">android:</span><span class="attribute">singleLine</span>=<span class="value">"true"</span> | |
| <span class="caretline"><span class="lineno"> 34 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">text</span>=<span class="value">"Title"</span></span> </span> | |
| <span class="lineno"> 35 </span> <span class="prefix">android:</span><span class="attribute">textAppearance</span>=<span class="value">"?android:attr/textAppearanceMedium"</span> | |
| <span class="lineno"> 36 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintBottom_toTopOf</span>=<span class="value">"@android:id/summary"</span> | |
| <span class="lineno"> 37 </span> <span class="prefix">app:</span><span class="attribute">layout_constraintEnd_toEndOf</span>=<span class="value">"parent"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/sign_in_preference.xml">../../src/main/res/layout/sign_in_preference.xml</a>:50</span>: <span class="message">Hardcoded string "Summary", should use <code>@string</code> resource</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 47 </span> <span class="prefix">android:</span><span class="attribute">layout_marginBottom</span>=<span class="value">"8dp"</span> | |
| <span class="lineno"> 48 </span> <span class="prefix">android:</span><span class="attribute">ellipsize</span>=<span class="value">"none"</span> | |
| <span class="lineno"> 49 </span> <span class="prefix">android:</span><span class="attribute">scrollHorizontally</span>=<span class="value">"false"</span> | |
| <span class="caretline"><span class="lineno"> 50 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">text</span>=<span class="value">"Summary"</span></span> </span> | |
| <span class="lineno"> 51 </span> <span class="prefix">android:</span><span class="attribute">textAppearance</span>=<span class="value">"?android:attr/textAppearanceSmall"</span> | |
| <span class="lineno"> 52 </span> <span class="prefix">android:</span><span class="attribute">textColor</span>=<span class="value">"?android:attr/textColorSecondary"</span> | |
| <span class="lineno"> 53 </span> <span class="prefix">android:</span><span class="attribute">textSize</span>=<span class="value">"16sp"</span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationHardcodedText" style="display: none;"> | |
| Hardcoding text attributes directly in layout files is bad for several reasons:<br/> | |
| <br/> | |
| * When creating configuration variations (for example for landscape or portrait) you have to repeat the actual text (and keep it up to date when making changes)<br/> | |
| <br/> | |
| * The application cannot be translated to other languages by just adding new translations for existing string resources.<br/> | |
| <br/> | |
| There are quickfixes to automatically extract this hardcoded string into a resource lookup.<br/>To suppress this error, use the issue id "HardcodedText" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">HardcodedText</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Internationalization</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 5/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationHardcodedTextLink" onclick="reveal('explanationHardcodedText');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="HardcodedTextCardLink" onclick="hideid('HardcodedTextCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="Internationalization:Bidirectional Text"></a> | |
| <a name="RtlSymmetry"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="RtlSymmetryCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Padding and margin symmetry</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| <div class="issue"> | |
| <div class="warningslist"> | |
| <span class="location"><a href="../../src/main/res/layout/history_header.xml">../../src/main/res/layout/history_header.xml</a>:9</span>: <span class="message">When you define <code>paddingStart</code> you should probably also define <code>paddingEnd</code> for right-to-left symmetry</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 6 </span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"match_parent"</span> | |
| <span class="lineno"> 8 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span> | |
| <span class="caretline"><span class="lineno"> 9 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">paddingStart</span></span>=<span class="value">"20dp"</span> </span> | |
| <span class="lineno"> 10 </span> <span class="prefix">android:</span><span class="attribute">layout_marginTop</span>=<span class="value">"24dp"</span> | |
| <span class="lineno"> 11 </span> <span class="prefix">android:</span><span class="attribute">layout_marginBottom</span>=<span class="value">"24dp"</span>> | |
| </pre> | |
| <span class="location"><a href="../../src/main/res/layout/history_list_item.xml">../../src/main/res/layout/history_list_item.xml</a>:13</span>: <span class="message">When you define <code>paddingStart</code> you should probably also define <code>paddingEnd</code> for right-to-left symmetry</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 10 </span> <span class="prefix">android:</span><span class="attribute">clickable</span>=<span class="value">"true"</span> | |
| <span class="lineno"> 11 </span> <span class="prefix">android:</span><span class="attribute">focusable</span>=<span class="value">"true"</span> | |
| <span class="lineno"> 12 </span> <span class="prefix">android:</span><span class="attribute">padding</span>=<span class="value">"4dp"</span> | |
| <span class="caretline"><span class="lineno"> 13 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">paddingStart</span></span>=<span class="value">"20dp"</span>> </span> | |
| <span class="lineno"> 14 </span> | |
| <span class="lineno"> 15 </span> <span class="tag"><CheckBox</span><span class="attribute"> | |
| </span><span class="lineno"> 16 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">id</span>=<span class="value">"@+id/should_remove_checkbox"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/layout_url_backround.xml">../../src/main/res/layout/layout_url_backround.xml</a>:8</span>: <span class="message">When you define <code>paddingStart</code> you should probably also define <code>paddingEnd</code> for right-to-left symmetry</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 5 </span><span class="tag"><FrameLayout</span><span class="attribute"> </span><span class="prefix">xmlns:</span><span class="attribute">android</span>=<span class="value">"http://schemas.android.com/apk/res/android"</span> | |
| <span class="lineno"> 6 </span> <span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"wrap_content"</span> | |
| <span class="lineno"> 7 </span> <span class="prefix">android:</span><span class="attribute">layout_height</span>=<span class="value">"wrap_content"</span> | |
| <span class="caretline"><span class="lineno"> 8 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">paddingStart</span></span>=<span class="value">"8dp"</span>> </span> | |
| <span class="lineno"> 9 </span> | |
| <span class="lineno"> 10 </span> <span class="tag"><View</span><span class="attribute"> | |
| </span><span class="lineno"> 11 </span><span class="attribute"> </span><span class="prefix">android:</span><span class="attribute">layout_width</span>=<span class="value">"wrap_content"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/session_bottom_sheet.xml">../../src/main/res/layout/session_bottom_sheet.xml</a>:80</span>: <span class="message">When you define <code>paddingStart</code> you should probably also define <code>paddingEnd</code> for right-to-left symmetry</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 77 </span> <span class="prefix">android:</span><span class="attribute">drawableStart</span>=<span class="value">"@drawable/ic_delete"</span> | |
| <span class="lineno"> 78 </span> <span class="prefix">android:</span><span class="attribute">drawablePadding</span>=<span class="value">"14dp"</span> | |
| <span class="lineno"> 79 </span> <span class="prefix">android:</span><span class="attribute">drawableTint</span>=<span class="value">"@color/photonRed60"</span> | |
| <span class="caretline"><span class="lineno"> 80 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">paddingStart</span></span>=<span class="value">"20dp"</span> </span> | |
| <span class="lineno"> 81 </span> <span class="prefix">android:</span><span class="attribute">paddingTop</span>=<span class="value">"12dp"</span> | |
| <span class="lineno"> 82 </span> <span class="prefix">android:</span><span class="attribute">paddingBottom</span>=<span class="value">"12dp"</span> | |
| <span class="lineno"> 83 </span> <span class="prefix">android:</span><span class="attribute">text</span>=<span class="value">"@string/current_session_delete"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/session_bottom_sheet.xml">../../src/main/res/layout/session_bottom_sheet.xml</a>:100</span>: <span class="message">When you define <code>paddingStart</code> you should probably also define <code>paddingEnd</code> for right-to-left symmetry</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 97 </span> <span class="prefix">android:</span><span class="attribute">background</span>=<span class="value">"?android:attr/colorBackground"</span> | |
| <span class="lineno"> 98 </span> <span class="prefix">android:</span><span class="attribute">drawableStart</span>=<span class="value">"@drawable/ic_archive"</span> | |
| <span class="lineno"> 99 </span> <span class="prefix">android:</span><span class="attribute">drawablePadding</span>=<span class="value">"14dp"</span> | |
| <span class="caretline"><span class="lineno"> 100 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">paddingStart</span></span>=<span class="value">"20dp"</span> </span> | |
| <span class="lineno"> 101 </span> <span class="prefix">android:</span><span class="attribute">paddingTop</span>=<span class="value">"12dp"</span> | |
| <span class="lineno"> 102 </span> <span class="prefix">android:</span><span class="attribute">paddingBottom</span>=<span class="value">"12dp"</span> | |
| <span class="lineno"> 103 </span> <span class="prefix">android:</span><span class="attribute">text</span>=<span class="value">"@string/current_session_save"</span></pre> | |
| <span class="location"><a href="../../src/main/res/layout/session_bottom_sheet.xml">../../src/main/res/layout/session_bottom_sheet.xml</a>:115</span>: <span class="message">When you define <code>paddingStart</code> you should probably also define <code>paddingEnd</code> for right-to-left symmetry</span><br /><pre class="errorlines"> | |
| <span class="lineno"> 112 </span> <span class="prefix">android:</span><span class="attribute">drawableStart</span>=<span class="value">"@drawable/ic_share"</span> | |
| <span class="lineno"> 113 </span> <span class="prefix">android:</span><span class="attribute">drawablePadding</span>=<span class="value">"14dp"</span> | |
| <span class="lineno"> 114 </span> <span class="prefix">android:</span><span class="attribute">drawableTint</span>=<span class="value">"@color/icons_light_mode"</span> | |
| <span class="caretline"><span class="lineno"> 115 </span> <span class="warning"><span class="prefix">android:</span><span class="attribute">paddingStart</span></span>=<span class="value">"20dp"</span> </span> | |
| <span class="lineno"> 116 </span> <span class="prefix">android:</span><span class="attribute">paddingTop</span>=<span class="value">"12dp"</span> | |
| <span class="lineno"> 117 </span> <span class="prefix">android:</span><span class="attribute">paddingBottom</span>=<span class="value">"12dp"</span> | |
| <span class="lineno"> 118 </span> <span class="prefix">android:</span><span class="attribute">text</span>=<span class="value">"@string/current_session_share"</span></pre> | |
| </div> | |
| <div class="metadata"><div class="explanation" id="explanationRtlSymmetry" style="display: none;"> | |
| If you specify padding or margin on the left side of a layout, you should probably also specify padding on the right side (and vice versa) for right-to-left layout symmetry.<br/>To suppress this error, use the issue id "RtlSymmetry" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="chips"> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">RtlSymmetry</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Bidirectional Text</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Internationalization</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Warning</span> | |
| </span> | |
| <span class="mdl-chip"> | |
| <span class="mdl-chip__text">Priority 6/10</span> | |
| </span> | |
| </div> | |
| </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationRtlSymmetryLink" onclick="reveal('explanationRtlSymmetry');"> | |
| Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="RtlSymmetryCardLink" onclick="hideid('RtlSymmetryCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="MissingIssues"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="MissingIssuesCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Disabled Checks</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| One or more issues were not run by lint, either | |
| because the check is not enabled by default, or because | |
| it was disabled with a command line flag or via one or | |
| more <code>lint.xml</code> configuration files in the project directories. | |
| <div id="SuppressedIssues" style="display: none;"><br/><br/><div class="issue"> | |
| <div class="id">AppLinksAutoVerifyError<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Ensures that app links are correctly set and associated with website.<br/><div class="moreinfo">More info: <a href="https://g.co/appindexing/applinks">https://g.co/appindexing/applinks</a> | |
| </div>To suppress this error, use the issue id "AppLinksAutoVerifyError" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">AppLinksAutoVerifyWarning<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Ensures that app links are correctly set and associated with website.<br/><div class="moreinfo">More info: <a href="https://g.co/appindexing/applinks">https://g.co/appindexing/applinks</a> | |
| </div>To suppress this error, use the issue id "AppLinksAutoVerifyWarning" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">BackButton<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| According to the Android Design Guide,<br/> | |
| <br/> | |
| "Other platforms use an explicit back button with label to allow the user to navigate up the application's hierarchy. Instead, Android uses the main action bar's app icon for hierarchical navigation and the navigation bar's back button for temporal navigation."<br/> | |
| This check is not very sophisticated (it just looks for buttons with the label "Back"), so it is disabled by default to not trigger on common scenarios like pairs of Back/Next buttons to paginate through screens.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/design/patterns/pure-android.html">http://developer.android.com/design/patterns/pure-android.html</a> | |
| </div>To suppress this error, use the issue id "BackButton" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">ConvertToWebp<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| The WebP format is typically more compact than PNG and JPEG. As of Android 4.2.1 it supports transparency and lossless conversion as well. Note that there is a quickfix in the IDE which lets you perform conversion.<br/> | |
| <br/> | |
| Launcher icons must be in the PNG format.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "ConvertToWebp" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">DalvikOverride<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| The Dalvik virtual machine will treat a package private method in one class as overriding a package private method in its super class, even if they are in separate packages.<br/> | |
| <br/> | |
| If you really did intend for this method to override the other, make the method <code>protected</code> instead.<br/> | |
| <br/> | |
| If you did <b>not</b> intend the override, consider making the method private, or changing its name or signature.<br/> | |
| <br/> | |
| Note that this check is disabled be default, because ART (the successor to Dalvik) no longer has this behavior.<br/>To suppress this error, use the issue id "DalvikOverride" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">DuplicateStrings<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Duplicate strings can make applications larger unnecessarily.<br/> | |
| <br/> | |
| This lint check looks for duplicate strings, including differences for strings where the only difference is in capitalization. Title casing and all uppercase can all be adjusted in the layout or in code.<br/><div class="moreinfo">More info: <a href="https://developer.android.com/reference/android/widget/TextView.html#attr_android:inputType">https://developer.android.com/reference/android/widget/TextView.html#attr_android:inputType</a> | |
| </div>To suppress this error, use the issue id "DuplicateStrings" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">EasterEgg<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| An "easter egg" is code deliberately hidden in the code, both from potential users and even from other developers. This lint check looks for code which looks like it may be hidden from sight.<br/>To suppress this error, use the issue id "EasterEgg" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">FieldGetter<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Accessing a field within the class that defines a getter for that field is at least 3 times faster than calling the getter. For simple getters that do nothing other than return the field, you might want to just reference the local field directly instead.<br/> | |
| <br/> | |
| <b>NOTE</b>: As of Android 2.3 (Gingerbread), this optimization is performed automatically by Dalvik, so there is no need to change your code; this is only relevant if you are targeting older versions of Android.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/guide/practices/design/performance.html#internal_get_set">http://developer.android.com/guide/practices/design/performance.html#internal_get_set</a> | |
| </div>To suppress this error, use the issue id "FieldGetter" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">GoogleAppIndexingApiWarning<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Adds URLs to get your app into the Google index, to get installs and traffic to your app from Google Search.<br/><div class="moreinfo">More info: <a href="https://g.co/AppIndexing/AndroidStudio">https://g.co/AppIndexing/AndroidStudio</a> | |
| </div>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "GoogleAppIndexingApiWarning" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">IconExpectedSize<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| There are predefined sizes (for each density) for launcher icons. You should follow these conventions to make sure your icons fit in with the overall look of the platform.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/design/style/iconography.html">http://developer.android.com/design/style/iconography.html</a> | |
| </div>To suppress this error, use the issue id "IconExpectedSize" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">KotlinPropertyAccess<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| For a method to be represented as a property in Kotlin, strict “bean”-style prefixing must be used.<br/> | |
| <br/> | |
| Accessor methods require a ‘get’ prefix or for boolean-returning methods an ‘is’ prefix can be used.<br/><div class="moreinfo">More info: <a href="https://android.github.io/kotlin-guides/interop.html#property-prefixes">https://android.github.io/kotlin-guides/interop.html#property-prefixes</a> | |
| </div>To suppress this error, use the issue id "KotlinPropertyAccess" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">LambdaLast<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| To improve calling this code from Kotlin,<br/> | |
| parameter types eligible for SAM conversion should be last.<br/><div class="moreinfo">More info: <a href="https://android.github.io/kotlin-guides/interop.html#lambda-parameters-last">https://android.github.io/kotlin-guides/interop.html#lambda-parameters-last</a> | |
| </div>To suppress this error, use the issue id "LambdaLast" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">LogConditional<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| The BuildConfig class (available in Tools 17) provides a constant, "DEBUG", which indicates whether the code is being built in release mode or in debug mode. In release mode, you typically want to strip out all the logging calls. Since the compiler will automatically remove all code which is inside a "if (false)" check, surrounding your logging calls with a check for BuildConfig.DEBUG is a good idea.<br/> | |
| <br/> | |
| If you <b>really</b> intend for the logging to be present in release mode, you can suppress this warning with a @SuppressLint annotation for the intentional logging calls.<br/>To suppress this error, use the issue id "LogConditional" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">MangledCRLF<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| On Windows, line endings are typically recorded as carriage return plus newline: \r\n.<br/> | |
| <br/> | |
| This detector looks for invalid line endings with repeated carriage return characters (without newlines). Previous versions of the ADT plugin could accidentally introduce these into the file, and when editing the file, the editor could produce confusing visual artifacts.<br/><div class="moreinfo">More info: <a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=375421">https://bugs.eclipse.org/bugs/show_bug.cgi?id=375421</a> | |
| </div>To suppress this error, use the issue id "MangledCRLF" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">MinSdkTooLow<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| The value of the <code>minSdkVersion</code> property is too low and can be incremented without noticeably reducing the number of supported devices.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "MinSdkTooLow" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">MissingRegistered<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| If a class is referenced in the manifest or in a layout file, it must also exist in the project (or in one of the libraries included by the project. This check helps uncover typos in registration names, or attempts to rename or move classes without updating the manifest file properly.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/guide/topics/manifest/manifest-intro.html">http://developer.android.com/guide/topics/manifest/manifest-intro.html</a> | |
| </div>To suppress this error, use the issue id "MissingRegistered" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">NegativeMargin<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Margin values should be positive. Negative values are generally a sign that you are making assumptions about views surrounding the current one, or may be tempted to turn off child clipping to allow a view to escape its parent. Turning off child clipping to do this not only leads to poor graphical performance, it also results in wrong touch event handling since touch events are based strictly on a chain of parent-rect hit tests. Finally, making assumptions about the size of strings can lead to localization problems.<br/>To suppress this error, use the issue id "NegativeMargin" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">NewerVersionAvailable<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| This detector checks with a central repository to see if there are newer versions available for the dependencies used by this project. This is similar to the <code>GradleDependency</code> check, which checks for newer versions available in the Android SDK tools and libraries, but this works with any MavenCentral dependency, and connects to the library every time, which makes it more flexible but also <b>much</b> slower.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "NewerVersionAvailable" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">NoHardKeywords<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Do not use Kotlin’s hard keywords as the name of methods or fields.<br/> | |
| These require the use of backticks to escape when calling from Kotlin.<br/> | |
| Soft keywords, modifier keywords, and special identifiers are allowed.<br/> | |
| <br/> | |
| For example, Mockito’s <code>when</code> function requires backticks when used from Kotlin:<br/> | |
| <br/> | |
| val callable = Mockito.mock(Callable::class.java)<br/> | |
| Mockito.`when`(callable.call()).thenReturn(/* … */)<br/><div class="moreinfo">More info: <a href="https://android.github.io/kotlin-guides/interop.html#no-hard-keywords">https://android.github.io/kotlin-guides/interop.html#no-hard-keywords</a> | |
| </div>To suppress this error, use the issue id "NoHardKeywords" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">PermissionImpliesUnsupportedChromeOsHardware<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| The <code><uses-permission></code> element should not require a permission that implies an unsupported Chrome OS hardware feature. Google Play assumes that certain hardware related permissions indicate that the underlying hardware features are required by default. To fix the issue, consider declaring the corresponding uses-feature element with <code>required="false"</code> attribute.<br/><div class="moreinfo">More info: <a href="https://developer.android.com/topic/arc/manifest.html#implied-features">https://developer.android.com/topic/arc/manifest.html#implied-features</a> | |
| </div>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "PermissionImpliesUnsupportedChromeOsHardware" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">Registered<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Activities, services and content providers should be registered in the <code>AndroidManifest.xml</code> file using <code><activity></code>, <code><service></code> and <code><provider></code> tags.<br/> | |
| <br/> | |
| If your activity is simply a parent class intended to be subclassed by other "real" activities, make it an abstract class.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/guide/topics/manifest/manifest-intro.html">http://developer.android.com/guide/topics/manifest/manifest-intro.html</a> | |
| </div>To suppress this error, use the issue id "Registered" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">RequiredSize<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| All views must specify an explicit <code>layout_width</code> and <code>layout_height</code> attribute. There is a runtime check for this, so if you fail to specify a size, an exception is thrown at runtime.<br/> | |
| <br/> | |
| It's possible to specify these widths via styles as well. GridLayout, as a special case, does not require you to specify a size.<br/>To suppress this error, use the issue id "RequiredSize" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">SelectableText<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| If a <code><TextView></code> is used to display data, the user might want to copy that data and paste it elsewhere. To allow this, the <code><TextView></code> should specify <code>android:textIsSelectable="true"</code>.<br/> | |
| <br/> | |
| This lint check looks for TextViews which are likely to be displaying data: views whose text is set dynamically. This value will be ignored on platforms older than API 11, so it is okay to set it regardless of your <code>minSdkVersion</code>.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "SelectableText" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">StopShip<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Using the comment <code>// STOPSHIP</code> can be used to flag code that is incomplete but checked in. This comment marker can be used to indicate that the code should not be shipped until the issue is addressed, and lint will look for these. In Gradle projects, this is only checked for non-debug (release) builds.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "StopShip" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">SyntheticAccessor<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| A private inner class which is accessed from the outer class will force the compiler to insert a synthetic accessor; this means that you are causing extra overhead. This is not important in small projects, but is important for large apps running up against the 64K method handle limit, and especially for <b>libraries</b> where you want to make sure your library is as small as possible for the cases where your library is used in an app running up against the 64K limit.<br/>To suppress this error, use the issue id "SyntheticAccessor" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">TypographyQuotes<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Straight single quotes and double quotes, when used as a pair, can be replaced by "curvy quotes" (or directional quotes). This can make the text more readable.<br/> | |
| <br/> | |
| Note that you should never use grave accents and apostrophes to quote, `like this'.<br/> | |
| <br/> | |
| (Also note that you should not use curvy quotes for code fragments.)<br/><div class="moreinfo">More info: <a href="http://en.wikipedia.org/wiki/Quotation_mark">http://en.wikipedia.org/wiki/Quotation_mark</a> | |
| </div>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "TypographyQuotes" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">UnknownNullness<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| To improve referencing this code from Kotlin, consider adding<br/> | |
| explicit nullness information here with either <code>@NonNull</code> or <code>@Nullable</code>.<br/> | |
| <br/> | |
| You can set the environment variable<br/> | |
| <code>ANDROID_LINT_NULLNESS_IGNORE_DEPRECATED=true</code><br/> | |
| if you want lint to ignore classes and members that have been annotated with<br/> | |
| <code>@Deprecated</code>.<br/><div class="moreinfo">More info: <a href="https://android.github.io/kotlin-guides/interop.html#nullability-annotations">https://android.github.io/kotlin-guides/interop.html#nullability-annotations</a> | |
| </div>To suppress this error, use the issue id "UnknownNullness" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">UnpackedNativeCode<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| This app loads native libraries using <code>System.loadLibrary()</code>.<br/> | |
| <br/> | |
| Consider adding <code>android:extractNativeLibs="false"</code> to the <code><application></code> tag in AndroidManifest.xml. Starting with Android 6.0, this will make installation faster, the app will take up less space on the device and updates will have smaller download sizes.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "UnpackedNativeCode" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">UnsupportedChromeOsHardware<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| The <code><uses-feature></code> element should not require this unsupported Chrome OS hardware feature. Any uses-feature not explicitly marked with <code>required="false"</code> is necessary on the device to be installed on. Ensure that any features that might prevent it from being installed on a Chrome OS device are reviewed and marked as not required in the manifest.<br/><div class="moreinfo">More info: <a href="https://developer.android.com/topic/arc/manifest.html#incompat-entries">https://developer.android.com/topic/arc/manifest.html#incompat-entries</a> | |
| </div>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "UnsupportedChromeOsHardware" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">UnusedIds<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| This resource id definition appears not to be needed since it is not referenced from anywhere. Having id definitions, even if unused, is not necessarily a bad idea since they make working on layouts and menus easier, so there is not a strong reason to delete these.<br/> | |
| <br/> | |
| The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead.<br/> | |
| <br/> | |
| You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests=true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests=true.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br> | |
| To suppress this error, use the issue id "UnusedIds" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| <div class="issue"> | |
| <div class="id">WrongThreadInterprocedural<div class="issueSeparator"></div> | |
| </div> | |
| <div class="metadata">Disabled By: Default<br/> | |
| <div class="explanation"> | |
| Searches for interprocedural call paths that violate thread annotations in the program. Tracks the flow of instantiated types and lambda expressions to increase accuracy across method boundaries.<br/><div class="moreinfo">More info: <a href="https://developer.android.com/guide/components/processes-and-threads.html#Threads">https://developer.android.com/guide/components/processes-and-threads.html#Threads</a> | |
| </div>To suppress this error, use the issue id "WrongThreadInterprocedural" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/> | |
| <br/></div> | |
| </div> | |
| </div> | |
| </div> </div> | |
| <div class="mdl-card__actions mdl-card--border"> | |
| <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="SuppressedIssuesLink" onclick="reveal('SuppressedIssues');"> | |
| List Missing Issues</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="MissingIssuesCardLink" onclick="hideid('MissingIssuesCard');"> | |
| Dismiss</button> </div> | |
| </div> | |
| </section> | |
| <a name="SuppressInfo"></a> | |
| <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="SuppressCard" style="display: block;"> | |
| <div class="mdl-card mdl-cell mdl-cell--12-col"> | |
| <div class="mdl-card__title"> | |
| <h2 class="mdl-card__title-text">Suppressing Warnings and Errors</h2> | |
| </div> | |
| <div class="mdl-card__supporting-text"> | |
| Lint errors can be suppressed in a variety of ways:<br/> | |
| <br/> | |
| 1. With a <code>@SuppressLint</code> annotation in the Java code<br/> | |
| 2. With a <code>tools:ignore</code> attribute in the XML file<br/> | |
| 3. With a //noinspection comment in the source code<br/> | |
| 4. With ignore flags specified in the <code>build.gradle</code> file, as explained below<br/> | |
| 5. With a <code>lint.xml</code> configuration file in the project<br/> | |
| 6. With a <code>lint.xml</code> configuration file passed to lint via the --config flag<br/> | |
| 7. With the --ignore flag passed to lint.<br/> | |
| <br/> | |
| To suppress a lint warning with an annotation, add a <code>@SuppressLint("id")</code> annotation on the class, method or variable declaration closest to the warning instance you want to disable. The id can be one or more issue id's, such as <code>"UnusedResources"</code> or <code>{"UnusedResources","UnusedIds"}</code>, or it can be <code>"all"</code> to suppress all lint warnings in the given scope.<br/> | |
| <br/> | |
| To suppress a lint warning with a comment, add a <code>//noinspection id</code> comment on the line before the statement with the error.<br/> | |
| <br/> | |
| To suppress a lint warning in an XML file, add a <code>tools:ignore="id"</code> attribute on the element containing the error, or one of its surrounding elements. You also need to define the namespace for the tools prefix on the root element in your document, next to the <code>xmlns:android</code> declaration:<br/> | |
| <code>xmlns:tools="http://schemas.android.com/tools"</code><br/> | |
| <br/> | |
| To suppress a lint warning in a <code>build.gradle</code> file, add a section like this:<br/> | |
| <br/> | |
| android {<br/> | |
| lintOptions {<br/> | |
| disable 'TypographyFractions','TypographyQuotes'<br/> | |
| }<br/> | |
| }<br/> | |
| <br/> | |
| Here we specify a comma separated list of issue id's after the disable command. You can also use <code>warning</code> or <code>error</code> instead of <code>disable</code> to change the severity of issues.<br/> | |
| <br/> | |
| To suppress lint warnings with a configuration XML file, create a file named <code>lint.xml</code> and place it at the root directory of the module in which it applies.<br/> | |
| <br/> | |
| The format of the <code>lint.xml</code> file is something like the following:<br/> | |
| <br/> | |
| <?xml version="1.0" encoding="UTF-8"?><br/> | |
| <lint><br/> | |
| <!-- Ignore everything in the test source set --><br/> | |
| <issue id="all"><br/> | |
| <ignore path="*/test/*" /><br/> | |
| </issue><br/> | |
| <br/> | |
| <!-- Disable this given check in this project --><br/> | |
| <issue id="IconMissingDensityFolder" severity="ignore" /><br/> | |
| <br/> | |
| <!-- Ignore the ObsoleteLayoutParam issue in the given files --><br/> | |
| <issue id="ObsoleteLayoutParam"><br/> | |
| <ignore path="res/layout/activation.xml" /><br/> | |
| <ignore path="res/layout-xlarge/activation.xml" /><br/> | |
| <ignore regexp="(foo|bar).java" /><br/> | |
| </issue><br/> | |
| <br/> | |
| <!-- Ignore the UselessLeaf issue in the given file --><br/> | |
| <issue id="UselessLeaf"><br/> | |
| <ignore path="res/layout/main.xml" /><br/> | |
| </issue><br/> | |
| <br/> | |
| <!-- Change the severity of hardcoded strings to "error" --><br/> | |
| <issue id="HardcodedText" severity="error" /><br/> | |
| </lint><br/> | |
| <br/> | |
| To suppress lint checks from the command line, pass the --ignore flag with a comma separated list of ids to be suppressed, such as:<br/> | |
| <code>$ lint --ignore UnusedResources,UselessLeaf /my/project/path</code><br/> | |
| <br/> | |
| For more information, see <a href="http://g.co/androidstudio/suppressing-lint-warnings">http://g.co/androidstudio/suppressing-lint-warnings</a><br/> | |
| </div> | |
| </div> | |
| </section> </div> | |
| </main> | |
| </div> | |
| </body> | |
| </html> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment