Created
August 8, 2011 15:22
-
-
Save cowboy/1131946 to your computer and use it in GitHub Desktop.
Object.toType
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// See http://javascriptweblog.wordpress.com/2011/08/08/fixing-the-javascript-typeof-operator/ | |
(function(global) { | |
// Maintain a map of already-encountered types for super-fast lookups. This | |
// serves the dual purpose of being an object from which to use the function | |
// Object.prototype.toString for retrieving an object's [[Class]]. | |
var types = {}; | |
// Return a useful value based on a passed object's [[Class]] (when possible). | |
Object.toType = function(obj) { | |
var key; | |
// If the object is null, return "Null" (IE <= 8) | |
return obj === null ? "Null" | |
// If the object is undefined, return "Undefined" (IE <= 8) | |
: obj == null ? "Undefined" | |
// If the object is the global object, return "Global" | |
: obj === global ? "Global" | |
// Otherwise return the XXXXX part of the full [object XXXXX] value, from | |
// cache if possible. | |
: types[key = types.toString.call(obj)] || (types[key] = key.slice(8, -1)); | |
}; | |
}(this)); |
The code is wicked - it's the comment...
```
// If the object is undefined, return "Null" (IE <= 8)
```
should say
// If the object is undefined, return "Undefined" (IE <= 8)
…On Aug 9, 2011, at 5:11, ***@***.*** wrote:
@angus-c why is it wrong? If `obj === null` then obj is `null`. If that check fails, if `obj == null` then obj must be `undefined`.
##
Reply to this email directly or view it on GitHub:
https://gist.github.com/1131946
@angus-c hahaha thanks, fixed! I think I need more sleep.
I know this is ancient code, but for anyone stumbling on this today (mid 2014), note that PhantomJS currently returns "DomWindow" for both undefined and null (it's a known bug, but still)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@angus-c why is it wrong? If
obj === null
then obj isnull
. If that check fails, ifobj == null
then obj must beundefined
.