Our tests for pg_upgrade is its own travesty:
- It takes no control over its input: let's upgrade whatever is left in the cluster. That means we really don't know how or what we are testing.
- It relies on comparing two dumps (one before upgrade, one after upgrade) and asserting that they are verbatim identical. Philosophically speaking, this is sufficient not necessary. Practically, this is wrong.