Created
April 16, 2016 03:27
-
-
Save dakcarto/f399e7333c228618cae5062331f70c91 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/python/core/conversions.sip b/python/core/conversions.sip | |
| index 8fcf789..d64171f 100644 | |
| --- a/python/core/conversions.sip | |
| +++ b/python/core/conversions.sip | |
| @@ -680,11 +680,6 @@ template<TYPE> | |
| PyObject *kobj, *tobj, *kobj2, *tobj2; | |
| Py_ssize_t i = 0; | |
| - //TODO: it works using SIP | |
| -#if (SIP_VERSION >= 0x041200) | |
| - const sipMappedType* qmap2 = sipFindMappedType("QMap<int, TYPE>"); | |
| -#endif | |
| - | |
| // Check the type if that is all that is required. | |
| if (sipIsErr == NULL) | |
| { | |
| @@ -696,17 +691,12 @@ template<TYPE> | |
| if (!PyDict_Check(tobj)) | |
| return 0; | |
| -#if (SIP_VERSION >= 0x041200) | |
| - if (!sipCanConvertToMappedType(tobj, qmap2, SIP_NOT_NONE)) | |
| - return 0; | |
| -#else | |
| Py_ssize_t j = 0; | |
| while (PyDict_Next(tobj, &j, &kobj2, &tobj2)) | |
| { | |
| if (!sipCanConvertToType(tobj2, sipType_TYPE, SIP_NOT_NONE)) | |
| return 0; | |
| } | |
| -#endif | |
| } | |
| return 1; | |
| } | |
| @@ -717,24 +707,6 @@ template<TYPE> | |
| { | |
| qint64 k = PyLong_AsLongLong(kobj); | |
| -#if (SIP_VERSION >= 0x041200) | |
| - // TODO: search for the minimum SIP version this code works on, it works | |
| - // on SIP 4.13.3 (GS). See #else to know why the version check is needed. | |
| - | |
| - int state; | |
| - | |
| - TYPE* t = reinterpret_cast<TYPE*>(sipConvertToMappedType(tobj, qmap2, sipTransferObj,SIP_NOT_NONE,&state,sipIsErr)); | |
| - | |
| - if (*sipIsErr) | |
| - { | |
| - sipReleaseMappedType(t, qmap2, state); | |
| - delete qm; | |
| - return 0; | |
| - } | |
| - | |
| - qm.insert(k, *t); | |
| - sipReleaseMappedType(t, qmap2, state); | |
| -#else | |
| // using sipConvertToMappedType to convert directly to QMap<int, TYPE> doesn't work | |
| // and ends with a segfault | |
| @@ -759,7 +731,6 @@ template<TYPE> | |
| sipReleaseType(t2, sipType_TYPE, state); | |
| } | |
| qm->insert(k, qm2); | |
| -#endif | |
| } | |
| *sipCppPtr = qm; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment