daleyjem

Github Rulesets, Codeowners, and Merge Queue

In order to bypass codeowner requirements when you have merge queue enabled, you need to jump through a few hoops. This is especially useful when you're in a repo with thousands of files, and 20+ teams, each with codeownership. I'm an admin, so I don't want to get approval just because I enabled a new eslint rule, and autofixed tons of files. However, if I simply admin merge, I don't get the benefit of having merge queue to catch race conditions... the PR goes directly into the target branch.

The following is the next best workaround. It's not the most ideal thing in the world, but what do you want from me?

daleyjem

It doesn't make sense upon initial description reading, but there is a use case for it... Updating a package.json dependency to use a caret without getting the latest semver match.

I'm currently working on a very large project, in which we would like to enforce exact version matches across all child workspace package.json files.

Understand that when I say child workspace packages, you mustn't assume this project is a monorepo that publishes its packages. It uses yarn workspaces simply for the benefit of doing non-relative-path imports:

import { thing } from 'internal-package-a'
// vs

daleyjem

Deep Imports

Description

A "deep import" is simply an ESM import that goes deeper than the package root:

import thingA from 'my-package-name/src/components/thingA'
import thingB from '@my-namespace/my-package-name/src/components/thingA'

daleyjem

const axios = require('axios')

const userToken = '<user token>'
const devToken = '<dev token>'

/**
 * Gets a distinct array of the artists in a user's playlists
 * @param {string} devToken The Apple-issued JWT developer token
 * @param {string} userToken The returned Apple `musickit.authorize()` user token
 */

daleyjem

import { NgModule } from '@angular/core';
import { ServerModule } from '@angular/platform-server';
import { AppModule } from './app.module';
import { AppComponent } from './app.component';

@NgModule({
  imports: [
    ServerModule,
    AppModule
  ],

daleyjem

LESS/SASS Guidelines

Structure. Structure. Structure

Make sure structure is organized and created in such a way that accommodates a large project by properly categorizing and modularizing folders and files. It’s better to feel that you’re over-engineering at the beginning, and restructure “down” later, than to assume a minimal set-up up front, simply for the sake of expediency.

Bad:

> less
	*all-of-the-files.less

daleyjem

/**
 * Veeva ClickStream tracking class.
 * 
 * Author: Jeremy Daley
 * Liscence: MIT
 */

ClickStream.prototype.virtualInterval   = -1;
ClickStream.prototype.calls             = []; // Queued calls
ClickStream.prototype.debug             = false;

daleyjem

Git commands

Note: Always make sure you're in the project root when doing git commands, or else it won't see the .gitignore file and try to track files that should be ignored.

To reset your files back to the last commit:

git reset --hard HEAD

To create and checkout a new branch:

daleyjem

/**
 * Evalutes a given expression by taking in a hash of variables as input values.
 * ${variable} denotes a variable assigned in the hash.
 * 
 * Example:
 * 		{{eval "${a} + ${b}" a=1 b=2}}
 * 			= 3
 */
module.exports.register = function(Handlebars, options) {
	Handlebars.registerHelper('eval', function(expr, options) {

daleyjem

$(function(){
	/** Constants **/
	var ATTRIBUTE_PREFIX = 'track';
	var ATTRIBUTE_EVENT_TYPE = "event-type"
	var RESERVED_ATTRIBUTES = [
		'events',	// Reserved for Omniture
		'eventType', // Reserved for client-side event type
		'linkType',	// Reserved for Omniture
		'vars' // Reserved for Omniture
	];