Skip to content

Instantly share code, notes, and snippets.

@danbogd
Created September 27, 2018 10:58
Show Gist options
  • Save danbogd/135d0fefc26dfd65cac8aba4591795a3 to your computer and use it in GitHub Desktop.
Save danbogd/135d0fefc26dfd65cac8aba4591795a3 to your computer and use it in GitHub Desktop.

Talenta Audit Report.

1. Summary

This document is a security audit report performed by danbogd, where Talenta has been reviewed.

2. In scope

3. Findings

2 issues were reported including:

  • 1 low severity issues.

  • 1 minor remark.

3.1. Known Issues of ERC20 Standard.

Severity: low

Description

Description ERC20 Tokens have some well-known issues (listed bellow), This is just a reminder for the contract developers.

Approve + transferFrom mechanism allows double Withdrawal attack. Lack of transaction handling. The above mentioned issues are well documented, a basic search can help to get more information.

3.2. Extra checking.

Severity: minor

Description

Extra checking in 33 line of BasicToken contract. SafeMath library checks it anyway.

Code snippet

    require(_value <= balances[msg.sender]);
    

Recommendation

This line may be deleted.

4. Conclusion

No critical vulnerabilities were detected,but we highly recommend to complete this bugs before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment