Skip to content

Instantly share code, notes, and snippets.

@danbogd
Created January 25, 2019 09:51
Show Gist options
  • Select an option

  • Save danbogd/1aaf46e9da30774a1dea2edbe6f2c581 to your computer and use it in GitHub Desktop.

Select an option

Save danbogd/1aaf46e9da30774a1dea2edbe6f2c581 to your computer and use it in GitHub Desktop.

Cryptoprofile audit report.

1. Summary

This document is a security audit report performed by danbogd, where Cryptoprofile has been reviewed.

2. In scope

3. Findings

In total, 2 issues were reported including:

  • 1 low severity issues.
  • 1 minor observation.

No critical security issues were found.

3.1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

3.2. Deprecated method.

Severity: minor observation

Description

The function () payable { revert(); } was a pattern used to prevent implicit acceptance of ether in Solidity versions older than 0.4.0, but today this is unneeded.

4. Conclusion

The review did not show any critical issues, some of low severity issues were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment