This document is a security audit report performed by danbogd, where GreatBritishPoundToken has been reviewed.
In total, 4 issues were reported including:
- 2 low severity issues.
- 2 minor observation
No critical security issues were found.
Transfer & transferFrom, approve functions do not prevent from sending tokens to address 0x0.
Add zero address checking
-
It is possible to double withdrawal attack. More details here.
-
Changing an allowance with approve and approveAndCall brings the risk that someone may use both the old and the new allowance by unfortunate transaction ordering.
The function () payable { revert(); } was a pattern used to prevent implicit acceptance of ether in Solidity versions older than 0.4.0, but today this is unneeded.
The contracts use solidity version 0.4.24. It is suggested to use the latest version and fix all compiler warnings that arise.
No critical vulnerabilities were detected,but we highly recommend to complete this bugs before use.