Skip to content

Instantly share code, notes, and snippets.

@danbogd
Created December 28, 2018 10:12
Show Gist options
  • Select an option

  • Save danbogd/25039ed731cbf9b736ff0185457c42e2 to your computer and use it in GitHub Desktop.

Select an option

Save danbogd/25039ed731cbf9b736ff0185457c42e2 to your computer and use it in GitHub Desktop.

GreatBritishPoundToken.

1. Summary

This document is a security audit report performed by danbogd, where GreatBritishPoundToken has been reviewed.

2. In scope

3. Findings

In total, 4 issues were reported including:

  • 2 low severity issues.
  • 2 minor observation

No critical security issues were found.

3.1. No checking for zero address.

Severity: low

Description

Transfer & transferFrom, approve functions do not prevent from sending tokens to address 0x0.

Recommendation

Add zero address checking

3.2. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Changing an allowance with approve and approveAndCall brings the risk that someone may use both the old and the new allowance by unfortunate transaction ordering.

3.3. Deprecated method.

Severity: minor observation

Description

The function () payable { revert(); } was a pattern used to prevent implicit acceptance of ether in Solidity versions older than 0.4.0, but today this is unneeded.

3.4. Consider using latest version of solidity.

Severity: minor observation

Description

The contracts use solidity version 0.4.24. It is suggested to use the latest version and fix all compiler warnings that arise.

4. Conclusion

No critical vulnerabilities were detected,but we highly recommend to complete this bugs before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment