btcexproICO_audit_report.md

btcex.pro ICO audit report.

1. Summary

This document is a security audit report performed by danbogd, where btcex.pro ICO has been reviewed.

2. In scope

• BXC.sol github commit hash d878fea326892f8136d90c31f792618828715601.

3. Findings

In total, 3 issues were reported including:

• 1 low severity issues.
• 2 minor observation.

No critical security issues were found.

3.1. Known vulnerabilities of ERC-20 token

Severity: low

Description

1. It is possible to double withdrawal attack. More details here.

2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

3.2. Consider using latest version of solidity.

Severity: minor observation

Description

The contracts use solidity version 0.4.24. It is suggested to use the latest version and fix all compiler warnings that arise.

3.3. Deprecated method.

Severity: minor observation

Description

The function () payable { revert(); } was a pattern used to prevent implicit acceptance of ether in Solidity versions older than 0.4.0, but today this is unneeded.

4. Conclusion

The review did not show any critical issues, some of low severity issues were found.