Skip to content

Instantly share code, notes, and snippets.

@danbogd

danbogd/ETH_ERC223standardimplementation_audit_report.md

Created July 7, 2019 15:06
Show Gist options
  • Save danbogd/f61fb5bde827796f9321add85596fd02 to your computer and use it in GitHub Desktop.
Save danbogd/f61fb5bde827796f9321add85596fd02 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ETH_ERC223standardimplementation_audit_report.md

ERC223 standard implementation for openzeppelinaudit report.

1. Summary

This document is a security audit report performed by danbogd, where ERC223 standard implementation for openzeppelin has been reviewed.

2. In scope

Сommit hash .

3. Findings

In total, 2 issues were reported including:

  • 1 medium severity issues
  • 0 low severity issues
  • 0 owner privileges (ability of owner to manipulate contract, may be risky for investors)..
  • 1 notes.

No critical security issues were found.

3.1. Typo.

Severity: low/medium

Description

Put a semicolon at the end of transfer function.

Code snippet

https://github.com/Sparke2/openzeppelin-solidity/blob/07e92b9a90c31381e512d0bf5e72934ef2daf02d/contracts/token/ERC223/IERC223.sol#L35

3.2. Extra code.

Severity: note

Description

Functions of this file (address.sol) is not used in this contract.

Code snippet

https://github.com/Sparke2/openzeppelin-solidity/blob/07e92b9a90c31381e512d0bf5e72934ef2daf02d/contracts/token/ERC223/ERC223.sol#L6

Recommendation

This line may be deleted.

4. Conclusion

The review did not show any critical issues, one medium or low severity issue was found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment