Skip to content

Instantly share code, notes, and snippets.

@danbogd
Created June 26, 2019 12:02
Show Gist options
  • Select an option

  • Save danbogd/f8349f1ea508980c5ade033056ea36b0 to your computer and use it in GitHub Desktop.

Select an option

Save danbogd/f8349f1ea508980c5ade033056ea36b0 to your computer and use it in GitHub Desktop.

IoTeX audit report.

1. Summary

This document is a security audit report performed by danbogd, where IoTeX has been reviewed.

2. In scope

Сommit hash 13b1b1053529effce653deabfec427b70800eb42.

3. Findings

In total, 2 issues were reported including:

  • 0 medium severity issues
  • 1 low severity issues
  • 1 owner privileges (ability of owner to manipulate contract, may be risky for investors)..
  • 0 notes.

No critical security issues were found.

3.1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

3.2. Owner Privileges

Severity: owner previliges

Description

Contract owner allow himself to:

to pause functions of contract (transfer, transferFrom, approve, increaseApproval, decreaseApproval) here.

4. Conclusion

The review did not show any critical issues, some of low severity issues were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment