tic-tac-to challenge

tic_tac_to.rb

def winner?(board)
  @match = false

  def check(type)
    @match = true if type.uniq.length == 1 && !type.include?(" ")
  end

  board.each do |row|
    check(row)
  end

  board.transpose.each do |col|
    check(col)
  end

  diag1, diag2 = board.map.with_index { |row, i| [row[i], row[- i - 1]] }.transpose

  check(diag1)
  check(diag2)

  @match
end

Line 8:

(horizontal == "xxx" || horizontal == "ooo") ? h_match = true : false

This is the same as:

h_match = horizontal == "xxx" || horizontal == "ooo"

horizontal == "xxx" || horizontal == "ooo" is already going to return true or false.

Line 18:

return true if h_match || v_match || d_match || d_match_2 else false

is the same as

return h_match || v_match || d_match || d_match_2

The result of that is already going to be true or false.

Which is also going to be returned implicitly since it's the last return value in the method Which means you don't have to explicitly write return

I wasn't able to get your line 8 suggestion implemented. It just won't work no matter how I play with it in the editor. Thanks for the other tips though. I simplified the code just a bit more, although launchcop is still giving is 8/7 for complexity (down from 11/7).