Snippet of BAD2viewPanel.js

BAD2viewPanel.js

// ViewPanel class
function ViewPanel(content, script) {
  this.panel = Panel({
    width: sp.prefs['width'],
    height: sp.prefs['height'],
    contentURL: data.url(content),
    contentScriptFile: data.url(script)
  });
 
  // Moved inside the class, better than fighting with closures again
  function onWidthChange() {
    this.panel.width = sp.prefs['width'];
  }

  function onHeightChange() {
    this.panel.height = sp.prefs['height'];
  }

  // listeners on the prefs change
  sp.on('width', onWidthChange);
  sp.on('height', onHeightChange);
}
 
// Use more closures
function getWidth() {
  return this.panel.width;
}

function getHeight() {
  return this.panel.height;
}

function setWidth(width) {
  this.panel.width = width;
}

function setHeight(height) {
  this.panel.height = height;
}

function getPanel() {
  return this.panel;
}

ViewPanel.prototype.getWidth = getWidth;
ViewPanel.prototype.getHeight = getHeight;
ViewPanel.prototype.setWidth = setWidth;
ViewPanel.prototype.setHeight = setHeight;
ViewPanel.prototype.getPanel = getPanel;
 
exports.ViewPanel = ViewPanel;