Skip to content

Instantly share code, notes, and snippets.

@darobin
Last active August 23, 2017 10:52
Show Gist options
  • Save darobin/d8bda9acdd7facf931c7 to your computer and use it in GitHub Desktop.
Save darobin/d8bda9acdd7facf931c7 to your computer and use it in GitHub Desktop.
// from the brilliant mind of sb
var _catch = Promise.prototype.catch;
Promise.prototype.catch = function () {
return _catch.call(this, function (err) { setTimeout(function () { throw(err); }, 0); });
}
@RangerMauve
Copy link

But... it doesn't actually invoke the callback for .catch....

@darobin
Copy link
Author

darobin commented Feb 12, 2016

Isn't that the point? :)

@greim
Copy link

greim commented Feb 12, 2016

This is like fixing your TV by throwing out the third story window.

@darobin
Copy link
Author

darobin commented Feb 12, 2016

@greim Funny you would say that, that is exactly how I fixed my TV!

@geirman
Copy link

geirman commented Feb 13, 2016

I'm missing the point, can someone give the 4th grader's explanation of what problem this solves and how?

@moimikey
Copy link

seems straight forward to me? monkey patching catch to throw caught errors asynchronously to be queued and looped back onto the call stack vs being potentially swallowed?

@moimikey
Copy link

oh hm. throwing inside catch continues the chain with a rejected promise -> unterminated chain -> swallows errors.

@moimikey
Copy link

okay. i get it then. so the setTimeout helps to unswallow subsequent errors in the chain, because when you setTimeout, it's async, so it gets popped back onto the call stack again after it gets queued, going through the event loop, and back onto the call stack with an intact stack trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment