Can change for 60:
- state->recvbuf = static_cast<char*>(JS_malloc(...))
- tmp = static_cast<char*>(JS_realloc(...))
Questions:
- Changes to request scoping?
Can change for 60:
- JS_BeginRequest/JSAutoRequest, are we missing a JS_EndRequest?
- Move AutoStableStringChars to shorten diffs?
- Can alias args->scripts[i] to shorten diff
- Replace JS_THIS_OBJECT with some form of GET_THIS
Questions:
- Added a sawNewline in couch_readline?
- exc_state.restore() is likely not needed? Unless we want to clobber on purpose? (JS_EncodeStringToUTF8)
Can change for 60:
- Move AutoExceptionState from couch_print to js_to_string
- tmp = static_cast<char*>(JS_realloc(...))
- tmp = static_cast<char*>(JS_realloc(...))
- str = string_to_js(cx, std::string(tmp, byteslen)) <- byteslen and off by one?
- Check definition of JSFunctionSpec*