Last active
December 14, 2019 08:28
-
-
Save dennislwm/d4ab42bb000ca8ddf711b8a439e92423 to your computer and use it in GitHub Desktop.
Specs for Github Commits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template: | |
Summarize the change in less than 50 characters | |
Because: | |
- Explain the reasons you made this change | |
- Make a new bullet for each reason | |
- Each line should be under 72 characters | |
Explain exactly what was done in this commit with more depth than the | |
50 character subject line. Remember to wrap at 72 characters! | |
Include any additional notes, relevant links, or co-authors. | |
Example: | |
Refactor the coupon UI | |
Because: | |
- The old UI code is fairly slow | |
- There were a few unused dependencies | |
- The old UI has aged poorly | |
I thought it was necessary to remove some of the old coupon UI code. | |
Unfortunately, it has aged pretty poorly, and I think this refactor makes | |
the code much easier to support in the long-run. Primarily, this commit | |
improves the performance of the coupon component. It also removes some | |
unused dependencies. | |
These changes should resolve issue #1337. | |
This commit removed the left-pad dependency, so please stop using it! | |
Co-authored-by: nspinazz89 <[email protected]> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment