Skip to content

Instantly share code, notes, and snippets.

@devmop
Last active December 27, 2015 15:59
Show Gist options
  • Save devmop/7351503 to your computer and use it in GitHub Desktop.
Save devmop/7351503 to your computer and use it in GitHub Desktop.
Feign bug
import javax.inject.Named;
import org.junit.Test;
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertThat;
import com.google.mockwebserver.MockResponse;
import com.google.mockwebserver.MockWebServer;
import com.google.mockwebserver.RecordedRequest;
import feign.Feign;
import feign.Headers;
import feign.RequestLine;
import feign.gson.GsonDecoder;
import feign.gson.GsonEncoder;
public class BrokenTest {
private interface TestInterface {
@RequestLine("GET /broken?name={broken}")
@Headers("Custom-Header: {Custom-Header}")
String get(@Named("broken") String broken, @Named("Custom-Header") String header);
}
@Test
public void showBreakageWithDefaultEncoder() throws Exception {
MockWebServer server = new MockWebServer();
server.enqueue(new MockResponse().setBody("response"));
server.play();
TestInterface testInterface = Feign.builder().target(TestInterface.class, "http://localhost:8080");
testInterface.get("broken", "header");
}
@Test
public void showBreakageWithGson() throws Exception {
MockWebServer server = new MockWebServer();
server.enqueue(new MockResponse().setBody("response"));
server.play();
TestInterface testInterface = Feign.builder().decoder(new GsonDecoder())
.encoder(new GsonEncoder()).target(TestInterface.class, "http://localhost:" + server.getPort());
testInterface.get("broken", "header");
RecordedRequest request = server.takeRequest();
assertThat(request.getHeader("Custom-Header"), is("header"));
assertThat(request.getRequestLine(), is("GET /broken?name=broken"));
}
}
showBreakageWithDefaultEncoder:
feign.codec.EncodeException: class java.util.LinkedHashMap is not a type supported by this encoder.
at feign.codec.Encoder$Default.encode(Encoder.java:80)
at feign.ReflectiveFeign$BuildFormEncodedTemplateFromArgs.resolve(ReflectiveFeign.java:207)
at feign.ReflectiveFeign$BuildTemplateByResolvingArgs.apply(ReflectiveFeign.java:183)
at feign.MethodHandler$SynchronousMethodHandler.invoke(MethodHandler.java:101)
at feign.ReflectiveFeign$FeignInvocationHandler.invoke(ReflectiveFeign.java:87)
at feign.$Proxy8.get(Unknown Source)
at feign.BrokenTest.showBreakageWithDefaultEncoder(BrokenTest.java:38)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:77)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:195)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:63)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
showBreakageWithGson:
Expected: is "GET /broken?name=broken"
but: was "POST /broken HTTP/1.1"
@svanscho
Copy link

Has this been fixed already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment