Skip to content

Instantly share code, notes, and snippets.

@dewey92
Created February 23, 2018 14:31
Show Gist options
  • Select an option

  • Save dewey92/1101f0c083bad06e108c42c242056fba to your computer and use it in GitHub Desktop.

Select an option

Save dewey92/1101f0c083bad06e108c42c242056fba to your computer and use it in GitHub Desktop.
Entry Challange

Write some application with messy code and file structures. This messy app

is:

  1. Inconsistent in naming convention
  2. Baking business logic into one big function
  3. Using quite a number of Imperative Programming styles
  4. ...

handle:

  1. Side effects (hitting API, sending email after registering, etc)
  2. Business logic (i.e calculating discount like in order app)
  3. Saving to database
  4. (TODO challenging feature, like displaying search result but show an "interlude component" every 5 items for 3 times)

And the candidate is required to review the code and make improvements however he wants.

Metrics:

  1. SRP
  2. Folder/file structure
  3. Abstraction?
  4. Consistent code style

Points to take:

  1. It's fun. Good developers are always hungry for improvements
  2. See how well he does the code review: does he give contructive feedbacks? It's about Team Player, Coach, and Communication attitude
  3. Asking "why do you recommend that change?" can tell us how reasonable his approach is (Strong background)
  4. At the same time, from the changes he commits, we can know how Structured/Organized and Clean he is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment