Skip to content

Instantly share code, notes, and snippets.

@dlenski
Last active September 23, 2024 16:10
Show Gist options
  • Save dlenski/e598197774666d440503d5168eefed31 to your computer and use it in GitHub Desktop.
Save dlenski/e598197774666d440503d5168eefed31 to your computer and use it in GitHub Desktop.
Bookmarklet to copy current page title as a rich-text formatted link
@dlenski
Copy link
Author

dlenski commented Sep 4, 2024

I found changing those nulls on line 4 to empty strings ("") stop the crashing and make it work for me again.

Interesting, thanks @skehlet. It crashes the tab??

Per those docs, should the second parameter (target) be set to "_blank" rather than ""?

I've updated it accordingly. Does that work for you?

@skehlet
Copy link

skehlet commented Sep 5, 2024

Interesting, thanks @skehlet. It crashes the tab??

It does! The whole application actually. Only in the last version or two however.

Per those docs, should the second parameter (target) be set to "_blank" rather than ""?

I've updated it accordingly. Does that work for you?

Yes, "_blank" is working great! Tested your updated version above exactly and it's working great on Brave
Version 1.69.162 Chromium: 128.0.6613.120 (Official Build) (arm64).

Edit: and verified without this change, it still crashes, even on today's update! ☠️

Thanks again!

@dlenski
Copy link
Author

dlenski commented Sep 5, 2024

Interesting, thanks @skehlet. It crashes the tab??

It does! The whole application actually. Only in the last version or two however.

Welp, good to know that there's an easy remotely-exploitable snippet of JavaScript that will crash https://github.com/brave/brave-browser 😝

(^attn @brave, if it hasn't been reported already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment