Skip to content

Instantly share code, notes, and snippets.

@dleonard00
Last active May 22, 2018 14:18
Show Gist options
  • Save dleonard00/4d75604e600401fceeee9dcd957d4ba8 to your computer and use it in GitHub Desktop.
Save dleonard00/4d75604e600401fceeee9dcd957d4ba8 to your computer and use it in GitHub Desktop.
Notes for swap changes
Peer should implement a send method. (as a p2p/Protocol msg Type)
Swap should be a protocol (p2p/Protocol) that the peer implements.
Swap protocol should have 2 messages (payment request, and payment)
Eliminate the 'proto' interface e.g. `self.proto.Pay(-self.balance, promise)`
This next section basically is to say, don't let the cheqbook deployment and interface logic get in the way of the developement of implementing Swap.
Leave cheque book deployment alone.
Could draft how to simplify the cheqbook.
A simplified version of the cheqbook will be deployed.
Stripping the code of all dependancy on the cheqbook contract so that it doesnt interfear for now.
Just refactoring the payments and swap protocol.
@dleonard00
Copy link
Author

@zelig instructed me to turn these notes into issues. ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment