Patch for Harbor 2.8.2's install script to support systemd

harbor-2.8.2-install-support-systemd.patch

diff -uNr harbor.orig/install.sh harbor/install.sh
--- harbor.orig/install.sh	2023-06-02 11:46:12.000000000 +0000
+++ harbor/install.sh	2023-07-26 18:04:48.666624099 +0000
@@ -19,6 +19,8 @@
 with_clair=$false
 # trivy is not enabled by default
 with_trivy=$false
+# assume no systemd for now
+have_systemd=$false

 # flag to using docker compose v1 or v2, default would using v1 docker-compose
 DOCKER_COMPOSE=docker-compose
@@ -90,7 +92,38 @@
 fi
 echo ""

-h2 "[Step $item]: starting Harbor ..."
+if [ -d /etc/systemd ]
+then
+    have_systemd=true
+    h2 "[Step $item]: installing Harbor systemd service ..."; let item+=1
+
+    cat >/etc/systemd/system/harbor.service <<EOF
+[Unit]
+Description=Harbor Cloud Native Registry
+Documentation=https://goharbor.io
+After=docker.service
+Requires=docker.service
+
+[Service]
+Type=simple
+Restart=on-failure
+RestartSec=5
+ExecStart=${DOCKER_COMPOSE} -f ${workdir}/docker-compose.yml up
+ExecStop=${DOCKER_COMPOSE} -f ${workdir}/docker-compose.yml down -v
+ExecStopPost=${DOCKER_COMPOSE} -f ${workdir}/docker-compose.yml rm -f
+
+[Install]
+WantedBy=multi-user.target
+EOF
+
+    note "Reloading systemd unit files ..."
+    systemctl daemon-reload
+
+    note "Setting Harbor to start on boot ..."
+    systemctl enable harbor
+fi
+
+h2 "[Step $item]: starting Harbor ..."; let item+=1
 if [ $with_notary ]
 then
     warn "
@@ -99,6 +132,11 @@
     Please see discussion here for more details. https://github.com/goharbor/harbor/discussions/16612"
 fi

-$DOCKER_COMPOSE up -d
+if [ $have_systemd ]
+then
+    systemctl start harbor
+else
+    $DOCKER_COMPOSE up -d
+fi

 success $"----Harbor has been installed and started successfully.----"

To use, copy to harbor.patch (or whatever, but that's the filename I'm using in the example), then:

# unpack harbor 2.8.2
tar xfz harbor-online-installer-v2.8.2.tgz

# patch it
patch -p0 < harbor.patch

# run install.sh as you normally would (don't forget to create harbor.yml first)
cd harbor
sudo ./install.sh <options>

Might work on earlier versions, will not work on later versions as there are changes to the install script that cause the patch to fail. I've submitted a PR to add this to the install script moving forward, but if that's not accepted, the changes shown here should still work, you'll just have to patch the file manually.

Hi,
nice work. Maybe you shoud use the existing systemd Unit file:
https://github.com/goharbor/harbor/blob/main/tools/systemd/harbor.service

With relative path, something like that,
regards Philipp

Thanks @ffppmm, it is indeed based on that but fixes the broken docker compose call, replacing it with the variable set earlier in the script, and uses the path in place for the installation. So for me I unpack Harbor in /opt/harbor-<version>, symlink from /opt/harbor, and run the install script from /opt/harbor so that's the working directory and it'll be a tad smoother to upgrade as I won't then have to update the unit file.