Skip to content

Instantly share code, notes, and snippets.

@dossy
Last active December 24, 2015 13:13
Show Gist options
  • Save dossy/4ef304006a735f17eadc to your computer and use it in GitHub Desktop.
Save dossy/4ef304006a735f17eadc to your computer and use it in GitHub Desktop.
Linux SSD notes

Linux SSD notes


commit 80c825f2facf71acf7e605f2ac555cf7fde14cc4
Author: Martin K. Petersen <[email protected]>
Date:   Wed Jul 22 07:57:12 2015 -0400

    block: Do a full clone when splitting discard bios
    
    commit f3f5da624e0a891c34d8cd513c57f1d9b0c7dadc upstream.
    
    This fixes a data corruption bug when using discard on top of MD linear,
    raid0 and raid10 personalities.
    
    Commit 20d0189b1012 "block: Introduce new bio_split()" permits sharing
    the bio_vec between the two resulting bios. That is fine for read/write
    requests where the bio_vec is immutable. For discards, however, we need
    to be able to attach a payload and update the bio_vec so the page can
    get mapped to a scatterlist entry. Therefore the bio_vec can not be
    shared when splitting discards and we must do a full clone.
    
    Signed-off-by: Martin K. Petersen <[email protected]>
    Reported-by: Seunguk Shin <[email protected]>
    Tested-by: Seunguk Shin <[email protected]>
    Cc: Seunguk Shin <[email protected]>
    Cc: Jens Axboe <[email protected]>
    Cc: Kent Overstreet <[email protected]>
    Reviewed-by: Christoph Hellwig <[email protected]>
    Signed-off-by: Jens Axboe <[email protected]>
    Signed-off-by: Greg Kroah-Hartman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment