Created
May 24, 2019 21:09
-
-
Save dreamstarter/ab3dfb3b19b8f3b4a3c3d8dc99797918 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[link to jira ticket] | |
Description of change | |
Please provide a description of the change here. Include links where the change can be viewed, and how the reviewer should proceed with manual testing, or inspecting visual changes. | |
Checklist | |
[ ] I have performed a self-review of my own code | |
[ ] I have commented my code, particularly in hard-to-understand areas | |
[ ] I have made corresponding changes to the documentation | |
[ ] My changes generate no new warnings or errors. | |
[ ] I have added tests that prove my change is effective or that my feature works. | |
[ ] New and existing unit tests pass locally with my changes. | |
[ ] After running npm run lint and npm run test locally, both pass. | |
[ ] I have re-based this branch from the develop branch. | |
NOTE: these things are not required to open a PR and can be done afterwards. But should be completed before tagging any reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment