Created
December 26, 2018 16:58
-
-
Save dwbuiten/2ff46490675c728f1b0932e7d40fb5df to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| General: | |
| * I assume enum vals are guaranteed by rust/c stuff? | |
| * You need to document how to call the send/recieve and how to drain them, etc. How to loop properly, and if they can be called concurrently, etc. | |
| line 43: No alt-ref / invisible? Or "multiple" if bundled? Does it matter? I'm not sure. | |
| line 85: Mention allocation maybe? Does instatiation imply allocation? I'm legitimately not sure. | |
| line 88/98/etc: Are configs and contexts reference counted? It's really weird to "unref" a config or context to me... Don't you just free it? If they /are/ reference counted... to what end? | |
| line 132: I assume this is a number that is set by the user and propagated through to RaFrame as | |
| line 141: I know it's mentioned in the documentation for RaConfig, but it should probably have some comment. | |
| line 156: Typo? Also shouldn't it be 0 == success, < 0 == fail? | |
| line 160: comment needed | |
| line 198: Typo, also mention "in bytes"? | |
| line 210: What does this mean? I don't know what producing a frame from the encoding contexts means, or why it has to be "from the encoding context" instead of just allocated. Is it because it needs the state from the context to determine subsampling, etc.? | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment