Skip to content

Instantly share code, notes, and snippets.

@egh
Forked from diiq/pull_request.md
Last active September 15, 2015 20:51
Show Gist options
  • Save egh/8dc36a960b1aedf4355e to your computer and use it in GitHub Desktop.
Save egh/8dc36a960b1aedf4355e to your computer and use it in GitHub Desktop.
Pull Request Template

name: pr

key: pr

--

Link to story: https://www.pivotaltracker.com/story/show/$1

What this PR does:

${2:Explain in a few sentences what functionality changed, and how.}

${3:Can your changes be seen by a user? Then add a screenshot. Is it an interaction? Perhaps a recording.}

Notes

${4:Are there any surprises? Anything that was particularly difficult, or clever, or made you nervous, and should get particular attention during review? Call it out.}

${5:Don't forget to add the needs-review label when you're ready!}


For the reviewer:

Reviewer tasks (author, please merge this PR when all tasks are complete):

  • I ran the code locally
  • I performed a 5 minute walkthrough of the site looking for oddities
  • I skimmed the code; it makes sense
  • I read the code; it looks good
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment