Created
July 10, 2019 16:35
-
-
Save eklitzke/97dc94021b7c0d527c364714063c49bc to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| irc/accounts.go:366:10: Error return value of `tx.Set` is not checked (errcheck) | |
| tx.Set(accountKey, "1", setOptions) | |
| ^ | |
| irc/accounts.go:367:10: Error return value of `tx.Set` is not checked (errcheck) | |
| tx.Set(accountNameKey, account, setOptions) | |
| ^ | |
| irc/accounts.go:368:10: Error return value of `tx.Set` is not checked (errcheck) | |
| tx.Set(registeredTimeKey, registeredTimeStr, setOptions) | |
| ^ | |
| irc/accounts.go:384:16: Error return value of `am.Unregister` is not checked (errcheck) | |
| am.Unregister(casefoldedAccount) | |
| ^ | |
| irc/accounts.go:564:13: Error return value of `tx.Delete` is not checked (errcheck) | |
| tx.Delete(verificationCodeKey) | |
| ^ | |
| irc/accounts.go:575:18: Error return value of `json.Unmarshal` is not checked (errcheck) | |
| json.Unmarshal([]byte(raw.Credentials), &creds) | |
| ^ | |
| irc/accounts.go:773:22: Error return value of `am.server.store.View` is not checked (errcheck) | |
| am.server.store.View(func(tx *buntdb.Tx) error { | |
| ^ | |
| irc/accounts.go:871:38: Error return value of `am.server.channels.SetUnregistered` is not checked (errcheck) | |
| am.server.channels.SetUnregistered(channelName, casefoldedAccount) | |
| ^ | |
| irc/accounts.go:883:24: Error return value of `am.server.store.Update` is not checked (errcheck) | |
| am.server.store.Update(func(tx *buntdb.Tx) error { | |
| ^ | |
| irc/accounts.go:884:12: Error return value of `tx.Delete` is not checked (errcheck) | |
| tx.Delete(accountKey) | |
| ^ | |
| irc/accounts.go:886:12: Error return value of `tx.Delete` is not checked (errcheck) | |
| tx.Delete(accountNameKey) | |
| ^ | |
| irc/accounts.go:909:26: Error return value of `am.server.store.Update` is not checked (errcheck) | |
| am.server.store.Update(func(tx *buntdb.Tx) error { | |
| ^ | |
| irc/accounts.go:966:22: Error return value of `am.server.store.View` is not checked (errcheck) | |
| am.server.store.View(func(tx *buntdb.Tx) error { | |
| ^ | |
| irc/accounts.go:1380:15: Error return value of `friend.Send` is not checked (errcheck) | |
| friend.Send(nil, client.NickMaskString(), "ACCOUNT", "*") | |
| ^ | |
| irc/channel.go:225:23: Error return value of `channel.performWrite` is not checked (errcheck) | |
| channel.performWrite(0) | |
| ^ | |
| irc/channel.go:602:35: Error return value of `session.sendFromClientInternal` is not checked (errcheck) | |
| session.sendFromClientInternal(false, message.Time, message.Msgid, details.nickMask, details.accountName, nil, "JOIN", chname, details.accountName, details.realname) | |
| ^ | |
| irc/channel.go:604:35: Error return value of `session.sendFromClientInternal` is not checked (errcheck) | |
| session.sendFromClientInternal(false, message.Time, message.Msgid, details.nickMask, details.accountName, nil, "JOIN", chname) | |
| ^ | |
| irc/channel.go:607:17: Error return value of `session.Send` is not checked (errcheck) | |
| session.Send(nil, client.server.name, "MODE", chname, modestr, details.nick) | |
| ^ | |
| irc/channel.go:683:16: Error return value of `sessionRb.Send` is not checked (errcheck) | |
| sessionRb.Send(false) | |
| ^ | |
| irc/channel.go:700:32: Error return value of `member.sendFromClientInternal` is not checked (errcheck) | |
| member.sendFromClientInternal(false, splitMessage.Time, splitMessage.Msgid, details.nickMask, details.accountName, nil, "PART", chname, message) | |
| ^ | |
| irc/channel.go:705:34: Error return value of `session.sendFromClientInternal` is not checked (errcheck) | |
| session.sendFromClientInternal(false, splitMessage.Time, splitMessage.Msgid, details.nickMask, details.accountName, nil, "PART", chname, message) | |
| ^ | |
| irc/channel.go:753:17: Error return value of `session.Send` is not checked (errcheck) | |
| session.Send(nil, details.nickMask, "JOIN", chname, details.accountName, details.realname) | |
| ^ | |
| irc/channel.go:755:17: Error return value of `session.Send` is not checked (errcheck) | |
| session.Send(nil, details.nickMask, "JOIN", chname) | |
| ^ | |
| irc/channel.go:773:9: Error return value of `rb.Send` is not checked (errcheck) | |
| rb.Send(true) | |
| ^ | |
| irc/channel.go:784:9: Error return value of `rb.Send` is not checked (errcheck) | |
| rb.Send(true) | |
| ^ | |
| irc/channel.go:1207:14: Error return value of `invitee.Send` is not checked (errcheck) | |
| invitee.Send(nil, inviter.NickMaskString(), "INVITE", tnick, chname) | |
| ^ | |
| irc/channelmanager.go:222:17: Error return value of `channel.Store` is not checked (errcheck) | |
| channel.Store(IncludeAllChannelAttrs) | |
| ^ | |
| irc/channelmanager.go:225:36: Error return value of `cm.server.channelRegistry.Delete` is not checked (errcheck) | |
| cm.server.channelRegistry.Delete(info) | |
| ^ | |
| irc/channelreg.go:113:23: Error return value of `reg.server.store.View` is not checked (errcheck) | |
| reg.server.store.View(func(tx *buntdb.Tx) error { | |
| ^ | |
| irc/channelreg.go:138:25: Error return value of `reg.server.store.Update` is not checked (errcheck) | |
| reg.server.store.Update(func(tx *buntdb.Tx) error { | |
| ^ | |
| irc/channelreg.go:219:25: Error return value of `reg.server.store.Update` is not checked (errcheck) | |
| reg.server.store.Update(func(tx *buntdb.Tx) error { | |
| ^ | |
| irc/chanserv.go:201:15: Error return value of `member.Send` is not checked (errcheck) | |
| member.Send(nil, fmt.Sprintf("ChanServ!services@%s", client.server.name), "MODE", args...) | |
| ^ | |
| irc/chanserv.go:253:15: Error return value of `member.Send` is not checked (errcheck) | |
| member.Send(nil, fmt.Sprintf("ChanServ!services@%s", client.server.name), "MODE", args...) | |
| ^ | |
| irc/chanserv.go:297:33: Error return value of `server.channels.SetUnregistered` is not checked (errcheck) | |
| server.channels.SetUnregistered(channelKey, founder) | |
| ^ | |
| irc/client.go:207:18: Error return value of `conn.Conn.Write` is not checked (errcheck) | |
| conn.Conn.Write([]byte(fmt.Sprintf(errorMsg, banMsg))) | |
| ^ | |
| irc/client.go:442:16: Error return value of `client.Send` is not checked (errcheck) | |
| client.Send(nil, client.server.name, ERR_UNKNOWNERROR, "*", client.t("You have sent too many registration messages")) | |
| ^ | |
| irc/client.go:489:10: Error return value of `rb.Send` is not checked (errcheck) | |
| rb.Send(true) | |
| ^ | |
| irc/client.go:614:19: Error return value of `fSession.Send` is not checked (errcheck) | |
| fSession.Send(nil, oldNickmask, "RESUMED", hostname, "ok") | |
| ^ | |
| irc/client.go:616:19: Error return value of `fSession.Send` is not checked (errcheck) | |
| fSession.Send(nil, oldNickmask, "RESUMED", hostname, timestampString) | |
| ^ | |
| irc/client.go:618:19: Error return value of `fSession.Send` is not checked (errcheck) | |
| fSession.Send(nil, oldNickmask, "RESUMED", hostname) | |
| ^ | |
| irc/client.go:824:33: Error return value of `fClient.sendFromClientInternal` is not checked (errcheck) | |
| fClient.sendFromClientInternal(false, time.Time{}, "", oldNickMask, client.AccountName(), nil, "CHGHOST", username, vhost) | |
| ^ | |
| irc/client.go:1089:30: Error return value of `client.server.clients.Remove` is not checked (errcheck) | |
| client.server.clients.Remove(client) | |
| ^ | |
| irc/client.go:1121:32: Error return value of `friend.sendFromClientInternal` is not checked (errcheck) | |
| friend.sendFromClientInternal(false, splitQuitMessage.Time, splitQuitMessage.Msgid, details.nickMask, details.accountName, nil, "QUIT", quitMessage) | |
| ^ | |
| irc/client.go:1206:32: Error return value of `session.socket.BlockingWrite` is not checked (errcheck) | |
| session.socket.BlockingWrite(line) | |
| ^ | |
| irc/client.go:1208:24: Error return value of `session.socket.Write` is not checked (errcheck) | |
| session.socket.Write(line) | |
| ^ | |
| irc/client.go:1259:13: Error return value of `client.Send` is not checked (errcheck) | |
| client.Send(nil, client.server.name, "NOTICE", client.Nick(), text) | |
| ^ | |
| irc/client_lookup_set.go:189:24: Error return value of `clients.removeInternal` is not checked (errcheck) | |
| clients.removeInternal(client) | |
| ^ | |
| irc/commands.go:26:14: Error return value of `client.Send` is not checked (errcheck) | |
| client.Send(nil, server.name, ERR_NOTREGISTERED, "*", client.t("You need to register before you can use that command")) | |
| ^ | |
| irc/config.go:725:17: Error return value of `config.loadMOTD` is not checked (errcheck) | |
| config.loadMOTD() | |
| ^ | |
| irc/connection_limits/throttler_test.go:76:23: Error return value of `throttler.ApplyConfig` is not checked (errcheck) | |
| throttler.ApplyConfig(config) | |
| ^ | |
| irc/history/history.go:16:2: `uninitializedItem` is unused (deadcode) | |
| uninitializedItem ItemType = iota | |
| ^ | |
| irc/client.go:586:3: ineffectual assignment to `oldestLostMessage` (ineffassign) | |
| oldestLostMessage = lastDiscarded | |
| ^ | |
| irc/fakelag_test.go:98:2: ineffectual assignment to `slept` (ineffassign) | |
| slept, duration = mt.lastSleep() | |
| ^ | |
| irc/fakelag_test.go:109:2: ineffectual assignment to `slept` (ineffassign) | |
| slept, duration = mt.lastSleep() | |
| ^ | |
| irc/utils/args_test.go:21:2: ineffectual assignment to `val` (ineffassign) | |
| val, err = StringToBool("default") | |
| ^ | |
| irc/connection_limits/throttler_test.go:95:2: S1021: should merge variable declaration with assignment on next line (gosimple) | |
| var err error | |
| ^ | |
| irc/connection_limits/throttler_test.go:110:2: S1021: should merge variable declaration with assignment on next line (gosimple) | |
| var err error | |
| ^ | |
| irc/handlers.go:2350:67: SA1006: printf-style function with dynamic first argument and no further arguments should use print-style function instead (staticcheck) | |
| targetRb.Add(nil, targetPrefix, "PART", oldName, fmt.Sprintf(mcl.t("Channel renamed"))) | |
| ^ | |
| irc/hostserv.go:195:28: SA1006: printf-style function with dynamic first argument and no further arguments should use print-style function instead (staticcheck) | |
| hsNotice(rb, fmt.Sprintf(client.t("Your vhost request will be reviewed by an administrator"))) | |
| ^ | |
| irc/hostserv.go:230:29: SA1006: printf-style function with dynamic first argument and no further arguments should use print-style function instead (staticcheck) | |
| hsNotice(rb, fmt.Sprintf(client.t("This vhost is currently disabled, but can be enabled with /HS ON"))) | |
| ^ | |
| irc/mkcerts/certs.go:26:8: SA4006: this value of `err` is never used (staticcheck) | |
| priv, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader) | |
| ^ | |
| irc/modes/modes_test.go:91:2: SA4006: this value of `set` is never used (staticcheck) | |
| set := NewModeSet() | |
| ^ | |
| irc/utils/bitset.go:25:2: S1021: should merge variable declaration with assignment on next line (gosimple) | |
| var mask uint32 | |
| ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment