webrocket.js

var Picomachine = require('picomachine');
var WebSocket = require('websocket-client').WebSocket;

var WebRocket = function(key, options) {
  this.key = key;
  this.options = options || {};
  this.connection = new WebRocket.Connection;
};

WebRocket.prototype = {
  connect: function() {},
  disconnect: function() {},
};

WebRocket.Socket = WebSocket;

WebRocket.Connection = function(url) {
  var initialState = 'disconnected';
  var self = this;

  this.url = url;
  this.machine = new Picomachine(initialState);
  this.state = initialState;
  this.on = this.machine.on;

  this.machine.transitionsFor['connect']     = {disconnected: 'connecting'};
  this.machine.transitionsFor['connected']   = {connecting: 'connected'};
  this.machine.transitionsFor['forbid']      = {connecting: 'forbidden', connected: 'forbidden'};
  this.machine.transitionsFor['unavailable'] = {connecting: 'unavailable', connected: 'unavailable'};
  this.machine.transitionsFor['disconnect']  = {connect: 'disconnected', connecting: 'disconnected'};

  this.machine.on('any', function() { self.state = this.state; });

  this.machine.on('connected', function() {
    console.log('connected');
  });

  this.machine.on('connecting', function() {
    var machine = this;

    this.socket = new WebRocket.Socket(self.url);
    this.socket.onopen = function() {
      machine.trigger('connected');
    };
    this.socket.onerror = function() {
      machine.trigger("unavailable");
    }
  });
};

WebRocket.Connection.prototype = {
  connect: function() {
    this.machine.trigger('connect');
  }
};

WebRocket.Channel = function() {};

module.exports = WebRocket;

imho you try to destroy a house of cards with a big berta cannon... javascript still sucks at performance, so i would rather avoid any external stuff, especially state machine managers. Btw, i personally don't like (to overuse) fsm, because i think that any kind of stateful systems can be represented with less magic, more explicit, understandable and efficient way... Example:

connect: function() {
    this.machine.trigger('connect');
}

My first thought... what the fuck is machine, second... where the fuck is it defined?... last... porque Maria!?

connect: function() {
    this.socket = new WebRocket.Socket(self.url);
    this.socket.onopen = this.onOpen;
    this.socket.onerror = this.onError;
}

Don't get me wrong, i don't think that state machines sucks, it's good to eg. draw a state machine on the paper or keep stuff documented - but it's not always benefit to implement it. One more thing i think, is that at many points this client will be tricky (eg, authenticated access to part of the channs and guest access to other part), and dealing with state machine may force you to do workarounds from it, in that case what's the purpose of using it?

Besides, there's a pusher client, and old rocket client, both working fine, let's reuse them as much as we can to deliver it quickly. Yes, i know i'm an asshole :)

Oh, i looked at picomachine's code... really "pico" and neat :)

Ok

…

On Jan 3, 2012, at 22:54, Chris ***@***.*** wrote: imho you try to destroy a house of cards with a big berta cannon... javascript still sucks at performance, so i would rather avoid any external stuff, especially state machine managers. Btw, i personally don't like (to overuse) fsm, because i think that any kind of stateful systems can be represented with less magic, more explicit, understandable and efficient way... Example: connect: function() { this.machine.trigger('connect'); } My first thought... what the fuck is machine, second... where the fuck is it defined?... last... porque Maria!? connect: function() { this.socket = new WebRocket.Socket(self.url); this.socket.onopen = this.onOpen; this.socket.onerror = this.onError; } Don't get me wrong, i don't think that state machines sucks, it's good to eg. draw a state machine on the paper or keep stuff documented - but it's not always benefit to implement it. One more thing i think, is that at many points this client will be tricky (eg, authenticated access to part of the channs and guest access to other part), and dealing with state machine may force you to do workarounds from it, in that case what's the purpose of using it? Besides, there's a pusher client, and old rocket client, both working fine, let's reuse them as much as we can to deliver it quickly. Yes, i know i'm an asshole :) Oh, i looked at picomachine's code... really "pico" and neat :) --- Reply to this email directly or view it on GitHub: https://gist.github.com/1557287

I like state machines.

I don't know about JS performance problems. But if that code works, I would just use it until its performance proves to be a problem. Just THEN I would change it for something else.