Skip to content

Instantly share code, notes, and snippets.

@emmajane
Last active August 29, 2015 14:02
Show Gist options
  • Save emmajane/11c34d231e0d822cbf18 to your computer and use it in GitHub Desktop.
Save emmajane/11c34d231e0d822cbf18 to your computer and use it in GitHub Desktop.
Review Culture

Depending on the size of your project, you probably have a variation on one of following types of review processes (or maybe a combination of several).

  1. Peer Review. We are all equals and equally able to review code and accept it to the project. We learn from one-another and do our best work when we know our peers will be judging it later.
  2. Automated Gatekeeper. Our code has test coverage. We trust our tests and only submit work we know will pass a comprehensive test suite. Typically we ask for a second opinion before the code is pushed into the test suite (for automated deployment).
  3. Consensus Shepherd. Our community of coders is vigilent, and opinionated. We require consensus from interested parties before code can be marked as "reviewed by the community". We may also have a testbot which is part of our community, making it easier for human coders to know when a suggested change meets minimum standards.
  4. Benevolent Dictator. My code, my way. You are welcome to submit your suggestions, but I will review, or have my lieutenants review, your work with a fine toothcomb. I enjoy finding your mistakes and rejecting your work. Only perfection is good enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment