Skip to content

Instantly share code, notes, and snippets.

@ericakfranz

ericakfranz/defer-parsing-js-optinmonster.php

Last active February 11, 2019 02:34
Show Gist options
  • Save ericakfranz/025e1fb3e07c24a49d30 to your computer and use it in GitHub Desktop.
Save ericakfranz/025e1fb3e07c24a49d30 to your computer and use it in GitHub Desktop.
Download ZIP
Defer Parsing of JavaScripts for WordPress
Raw
defer-parsing-js-optinmonster.php
//* Defer parsing of JavaScripts, but exclude OptinMonster!
function defer_parsing_of_js ( $url ) {
if ( FALSE === strpos( $url, '.js' ) ) return $url;
if ( strpos( $url, 'jquery.js' ) || strpos( $url, 'optinmonster' ) ) return $url;
return "$url' defer='defer";
}
add_filter( 'clean_url', 'defer_parsing_of_js', 11, 1 );
Raw
defer-parsing-js.php
//* Defer parsing of JavaScripts
function defer_parsing_of_js ( $url ) {
if ( FALSE === strpos( $url, '.js' ) ) return $url;
if ( strpos( $url, 'jquery.js' ) ) return $url;
return "$url' defer='defer";
}
add_filter( 'clean_url', 'defer_parsing_of_js', 11, 1 );
@ronezone
Copy link

@TechMagy,

if (!(is_admin() )) {

The above line prevents problems with certain plugins when logged-in to the WP Dashboard (admin interface.) If the user viewing the website is logged-in to the admin interface, there's no need to defer. This code is important to include; especially for novice users who, for instance, don't understand why they're excluding 'jquery.js.' Without this code, novices can get locked out of their site.

function defer_parsing_of_js ( $url ) {
if ( FALSE === strpos( $url, '.js' ) ) return $url;
if ( strpos( $url, 'jquery.js' ) ) return $url;
// return "$url' defer ";
return "$url' defer onload='";

I suspect the above line evolved from an invalid post that resulted in malformed HTML, an unmatched single-quote, (return "$url' defer ";,) which caused the defer attribute to be ignored... inserting the onload=' matched the single-quotes and fixed the defer issue, but I believe the 'onload' attribute is completely unnecessary, and the correct line is return "$url' defer='defer";.

}
add_filter( 'clean_url', 'defer_parsing_of_js', 11, 1 );
}

I would be curious to hear if others here can see any issues with this code, or it being added to functions.php

I've been noticing an increasing number of bloggers appear to be copying 'solutions' from other web sites and posting them as their own; often without testing. This is a sad trend, which has resulted in garbage bubbling-up to the top of Google SERP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment