aussetg

... answer said require line and column. So implement that. Need maybe not touch LSP output normalization in lspPositionToExternal/diagnostic snapshots.

Implementation: modify positions.ts externalPositionToLsp to strict. Maybe rename? The function currently from service. It can return undefined if invalid. But error messages say "requires 1-based line and character". It should not floor floats. It should require Number.isInteger and >=1. For column, if not number returns undefined. Should we default column=1? The old allowed missing char. But "Require column >=1". So no default. This affects codeActions with missing char; okay. We'll update error messages maybe "line and column" not character. Since service methods named character param. But tool uses column alias. In hintForError accepts both. Could leave "character" for legacy? Could make "line and column". But service is generic LSP method; parameter called character. However user-facing contract says column. We could use "line and column" in errors for 

Birch-san

#!/usr/bin/env bash

# Licensed by author Alex Birch under CC BY-SA 4.0
# https://creativecommons.org/licenses/by-sa/4.0/

# Example input:
# ./make_portable.sh mycoolbinary
# where mycoolbinary is a mach-o object file
# (for example an executable binary or a .dylib)
#

vbatts

#!/bin/sh

t_dir="$HOME/tmp"

mkdir -p ${t_dir}
pushd ${t_dir}

for url in \
    ftp://ftp.ruby-lang.org/pub/ruby/ruby-1.9.3-p194.tar.bz2 \
    http://openssl.org/source/openssl-1.0.1c.tar.gz