Created
December 18, 2012 21:15
-
-
Save ericf/4332080 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // How would we implement lazy consensus on Pull Requests? | |
| function canMerge(pr) { | |
| var reviews = YUI.get('reviewers'); | |
| if (reviews.whoObject().length) { | |
| return false; | |
| } | |
| if (reviewers.haveSignedOff().length || | |
| (Date().now() - pr.get('time')) > 1000 * 60 * 60 * 72) { | |
| return true; | |
| } | |
| return false; | |
| } | |
| // OR: | |
| function canMerge(pr) { | |
| var reviews = YUI.get('reviewers'); | |
| if (reviews.whoObject().length) { | |
| return false; | |
| } | |
| if (reviewers.haveSignedOff().length && | |
| (Date().now() - pr.get('time')) > 1000 * 60 * 60 * 72) { | |
| return true; | |
| } | |
| return false; | |
| } | |
| // The difference is whether we always wait the 72 hours, | |
| // or something is good to merge once Dav signs off. | |
| // | |
| // (Don't nit-pick the business days vs. non-bussiness days :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment