Skip to content

Instantly share code, notes, and snippets.

@ericf
Created December 18, 2012 21:15
Show Gist options
  • Select an option

  • Save ericf/4332080 to your computer and use it in GitHub Desktop.

Select an option

Save ericf/4332080 to your computer and use it in GitHub Desktop.
// How would we implement lazy consensus on Pull Requests?
function canMerge(pr) {
var reviews = YUI.get('reviewers');
if (reviews.whoObject().length) {
return false;
}
if (reviewers.haveSignedOff().length ||
(Date().now() - pr.get('time')) > 1000 * 60 * 60 * 72) {
return true;
}
return false;
}
// OR:
function canMerge(pr) {
var reviews = YUI.get('reviewers');
if (reviews.whoObject().length) {
return false;
}
if (reviewers.haveSignedOff().length &&
(Date().now() - pr.get('time')) > 1000 * 60 * 60 * 72) {
return true;
}
return false;
}
// The difference is whether we always wait the 72 hours,
// or something is good to merge once Dav signs off.
//
// (Don't nit-pick the business days vs. non-bussiness days :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment