Skip to content

Instantly share code, notes, and snippets.

@ericfode
Created December 28, 2013 07:56
Show Gist options
  • Save ericfode/8157139 to your computer and use it in GitHub Desktop.
Save ericfode/8157139 to your computer and use it in GitHub Desktop.
At /home/eric/src/globe/src/globe/events.clj:44:
Consider using:
(when-not (< (e-tic event) (:tic world)) event)
instead of:
(if (< (e-tic event) (:tic world)) nil event)
At /home/eric/src/globe/src/globe/events.clj:68:
Consider using:
(neg? amount)
instead of:
(< amount 0)
At /home/eric/src/globe/src/globe/events.clj:91:
Consider using:
(seq forwarded)
instead of:
(not (empty? forwarded))
At /home/eric/src/globe/src/globe/world.clj:84:
Consider using:
(add-node (remove-node old-loc id) new-loc id)
instead of:
(-> (remove-node old-loc id) (add-node new-loc id))
At /home/eric/src/globe/src/globe/world.clj:116:
Consider using:
(assoc-obj (move-node world old-loc new-loc id) id :location new-loc)
instead of:
(-> (move-node world old-loc new-loc id)
(assoc-obj id :location new-loc))
At /home/eric/src/globe/src/globe/world.clj:122:
Consider using:
(remove-node (dissoc-in world [:state :world-objects id]) loc id)
instead of:
(-> (dissoc-in world [:state :world-objects id]) (remove-node loc id))
At /home/eric/src/globe/src/globe/world.clj:140:
Consider using:
(update-in world [?key] inc)
instead of:
(assoc world :tic (inc (:tic world)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment