Skip to content

Instantly share code, notes, and snippets.

@eriknelson
Last active June 13, 2018 21:16
Show Gist options
  • Save eriknelson/1f723d7419358167bb1d78ac040b9103 to your computer and use it in GitHub Desktop.
Save eriknelson/1f723d7419358167bb1d78ac040b9103 to your computer and use it in GitHub Desktop.
Goals:
* Instance provision/deprovision PR by 6/20
[6/11]
Introduction, setup. Being able to build after Docker CE. Met with Paul and solidified gameplan.
[6/12]
Picking up where prior instance ref work left off. Using prov-nsc branch,
working our way through reconcileServiceInstance add. Trying to create the
provision request so that we can send the request off to the broker.
Meeting Carolyn to discuss her concerns with instance ref PR 2022
Issue is in plan_reference(), string and format functions are supposed to handle
the intelligence of just handing back the name, and right now if its namespaced,
they'll just print back nothing and that's a problem.
Add logic to String and Format to make sure they return the correct value
when the instance is namespaced.
Completed a buildable reconcileServiceInstanceAdd with Jesus. Plan is to
pair through pollServiceInstance to complete instance provisioning of ns types
and then split between:
reconcileServiceInstanceUpdate and reconcileServiceInstanceDelete
[6/13]
Received a lot of feedback from Carolyn on instance ref PR, going to work with
her this morning to try to get that accepted. Jesus will start on the
pollServiceInstance method. Planning to sync back up with him and pair after
hopefully getting the instance ref PR merged.
Carolyn finished her review, addressed feedback and fixed tests after a number
of log text updates. Pushed and expecting an LGTM.
@jmrodri
Copy link

jmrodri commented Jun 13, 2018

[6/13]
pollServiceInstance finished and tests updated, tests were green

ok      github.com/kubernetes-incubator/service-catalog/cmd/svcat       (cached)                                           
ok      github.com/kubernetes-incubator/service-catalog/cmd/svcat/output        (cached)                                   
ok      github.com/kubernetes-incubator/service-catalog/cmd/svcat/parameters    (cached)                                   
ok      github.com/kubernetes-incubator/service-catalog/contrib/cmd/user-broker (cached)                                   
ok      github.com/kubernetes-incubator/service-catalog/contrib/pkg/brokerapi/openservicebroker (cached)                   
ok      github.com/kubernetes-incubator/service-catalog/contrib/pkg/broker/server       (cached)                           
ok      github.com/kubernetes-incubator/service-catalog/contrib/pkg/broker/user_provided/controller     (cached)           
ok      github.com/kubernetes-incubator/service-catalog/pkg/api/meta    (cached)                                           
ok      github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog (cached)                                   
ok      github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog/v1beta1 (cached)                           
ok      github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog/validation      (cached)                   
ok      github.com/kubernetes-incubator/service-catalog/pkg/apis/settings/validation    (cached)                           
ok      github.com/kubernetes-incubator/service-catalog/pkg/controller  2.504s                                             
ok      github.com/kubernetes-incubator/service-catalog/pkg/filter      (cached)                                           
ok      github.com/kubernetes-incubator/service-catalog/pkg/hyperkube   (cached)                                           
ok      github.com/kubernetes-incubator/service-catalog/pkg/pretty      (cached)                                           
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/binding     (cached)                   
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/clusterservicebroker        (cached)   
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/clusterserviceclass (cached)           
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/instance    (cached)                   
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/rest        (cached)                   
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/server      (cached)                   
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/servicebroker       (cached)           
ok      github.com/kubernetes-incubator/service-catalog/pkg/registry/servicecatalog/serviceclass        (cached)           
ok      github.com/kubernetes-incubator/service-catalog/pkg/rest/core/fake      (cached)                                   
ok      github.com/kubernetes-incubator/service-catalog/pkg/svcat/service-catalog       (cached)                           
ok      github.com/kubernetes-incubator/service-catalog/plugin/pkg/admission/broker/authsarcheck        (cached)           
ok      github.com/kubernetes-incubator/service-catalog/plugin/pkg/admission/namespace/lifecycle        (cached)           
ok      github.com/kubernetes-incubator/service-catalog/plugin/pkg/admission/servicebindings/lifecycle  (cached)           
ok      github.com/kubernetes-incubator/service-catalog/plugin/pkg/admission/serviceplan/changevalidator        (cached)   
ok      github.com/kubernetes-incubator/service-catalog/plugin/pkg/admission/serviceplan/defaultserviceplan     (cached)   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment