ansible-lint using contra-env-setup [ari/master]

contra-env-setup-linter.txt

$ ansible-lint playbooks/setup.yml
WARNING: Couldn't open /home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/roles/prereqs/tasks/install_virtual_reqs.yml - No such file or directory
WARNING: Couldn't open /home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/query_setup_cluster.yml - No such file or directory
[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/cleanup/tasks/cleanup.yml:5
Task/Handler: Stop minishift if running

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/cleanup/tasks/cleanup.yml:5
Task/Handler: Stop minishift if running

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/cleanup/tasks/cleanup.yml:9
Task/Handler: Delete minishift profile {{ profile }}

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/cleanup/tasks/cleanup.yml:9
Task/Handler: Delete minishift profile {{ profile }}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/init_minishift.yml:3
Task/Handler: Initialization of minishift cluster with profile {{ profile }}

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/init_minishift.yml:3
Task/Handler: Initialization of minishift cluster with profile {{ profile }}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/init_minishift.yml:10
Task/Handler: Stop the cluster

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/init_minishift.yml:10
Task/Handler: Stop the cluster

[ANSIBLE0006] curl used in place of get_url or uri module
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/install_minishift_bin.yml:4
Task/Handler: Query for minishift compressed binary

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/install_minishift_bin.yml:4
Task/Handler: Query for minishift compressed binary

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/install_minishift_bin.yml:25
Task/Handler: Copy minishift version files to {{ minishift_dest_dir }}/minishift/

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/main.yml:15
Task/Handler: Set minishift disk-size {{ disk_size }}

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/main.yml:15
Task/Handler: Set minishift disk-size {{ disk_size }}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/main.yml:18
Task/Handler: Set minishift disk-size {{ memory }}

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/main.yml:18
Task/Handler: Set minishift disk-size {{ memory }}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/main.yml:28
Task/Handler: Check if the minishift profile exists

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/set_minishift_path.yml:10
Task/Handler: Source {{ ansible_env.HOME }}/.bashrc

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/minishift/tasks/set_minishift_path.yml:10
Task/Handler: Source {{ ansible_env.HOME }}/.bashrc

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/add_scc.yml:5
Task/Handler: Login to the Openshift cluster as an admin

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/add_scc.yml:5
Task/Handler: Login to the Openshift cluster as an admin

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/add_scc.yml:8
Task/Handler: Check contra-env-setup scc name from the yaml file

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/add_scc.yml:12
Task/Handler: Check {{ scc_file.stdout }} name exists from querying the cluster

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/add_scc.yml:22
Task/Handler: Create the {{ scc_name_file.stdout }} security context constraints

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/add_scc.yml:26
Task/Handler: Update the {{ scc_name_file.stdout }} security context constraints

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/build_new_app.yml:2
Task/Handler: {{ container_config_name }} :: Imagestream and buildconfig do not exist. Creating...

[ANSIBLE0011] All tasks should be named
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/build_new_app.yml:28
Task/Handler: set_fact __file__=/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/build_new_app.yml build_success=True __line__=28

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/get_set_project.yml:4
Task/Handler: Query to see if project is already present

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/get_set_project.yml:9
Task/Handler: Create project/namespace in the openshift cluster

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/get_set_project.yml:13
Task/Handler: add-role-to-user

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/get_set_project.yml:13
Task/Handler: add-role-to-user

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/login_to_cluster.yml:3
Task/Handler: Login to the Openshift cluster

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/login_to_cluster.yml:3
Task/Handler: Login to the Openshift cluster

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/login_to_cluster.yml:3
Task/Handler: Login to the Openshift cluster

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/login_to_cluster.yml:3
Task/Handler: Login to the Openshift cluster

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/main.yml:14
Task/Handler: Get the cluster Server URL for project {{ project }}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/set_oc_client.yml:3
Task/Handler: Determine the oc client is for profile {{ profile}}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/set_oc_client.yml:7
Task/Handler: Update the path with the oc client

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/set_oc_client.yml:7
Task/Handler: Update the path with the oc client

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/set_oc_client.yml:16
Task/Handler: Source {{ ansible_env.HOME }}/.bashrc

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/set_oc_client.yml:16
Task/Handler: Source {{ ansible_env.HOME }}/.bashrc

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_containers.yml:17
Task/Handler: Check that templates are valid

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_containers.yml:17
Task/Handler: Check that templates are valid

[ANSIBLE0011] All tasks should be named
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:2
Task/Handler: set_fact __file__=/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml __line__=2 params=[]

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:5
Task/Handler: Cleanup any failed containers on the cluster

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:9
Task/Handler: {{ container_config_name }} :: Get template name from the yaml file

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:16
Task/Handler: {{ container_config_name }} :: Get template name from querying the cluster

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:24
Task/Handler: {{ container_config_name }} :: Updating buildconfig {{ template_name }}

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:28
Task/Handler: {{ container_config_name }} :: Creating buildconfig {{ template_name }}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:33
Task/Handler: {{ container_config_name }} :: Get imagestream name from the yaml file

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:37
Task/Handler: {{ container_config_name }} :: Get imagestream from querying the cluster

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:50
Task/Handler: {{ container_config_name }} :: Get buildconfig name from the yaml file

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:54
Task/Handler: {{ container_config_name }} :: Get buildconfig from querying the cluster

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:66
Task/Handler: {{ container_config_name }} :: Check if the template being loaded contains the parameter...

[ANSIBLE0011] All tasks should be named
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:72
Task/Handler: set_fact __file__=/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml __line__=72 params={{ params | default([]) }} + [ '-p {{ item.item.key }}={{ item.item.val }}' ]

[ANSIBLE0011] All tasks should be named
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:77
Task/Handler: set_fact __file__=/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml build_success=False __line__=77

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/setup_os_templates.yml:87
Task/Handler: {{ container_config_name }} :: Imagestream and buildconfig do not exist. Creating...

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/start_mcluster.yml:5
Task/Handler: Check if the minishift profile is already up and running

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/os_temps/tasks/start_mcluster.yml:10
Task/Handler: Start minishift profile {{ profile }}

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/main.yml:5
Task/Handler: Check to see if a Jenkins Master instance is running

[ANSIBLE0007] mkdir used in place of argument state=directory to file module
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:12
Task/Handler: Create directory for sample pipleine job

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:12
Task/Handler: Create directory for sample pipleine job

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:12
Task/Handler: Create directory for sample pipleine job

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:23
Task/Handler: Update sample pipeline job inside the Jenkins Master pod

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:23
Task/Handler: Update sample pipeline job inside the Jenkins Master pod

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:27
Task/Handler: Scale the pod down to update the sample pipeline jobs in Jenkins

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:27
Task/Handler: Scale the pod down to update the sample pipeline jobs in Jenkins

[ANSIBLE0012] Commands should not change things if nothing needs doing
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:30
Task/Handler: Scale the pod up to update the sample pipeline jobs in Jenkins

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/pipeline/tasks/setup_sample_pipelines.yml:30
Task/Handler: Scale the pod up to update the sample pipeline jobs in Jenkins

[ANSIBLE0006] rpm used in place of yum or rpm_key module
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/prereqs/tasks/install_virtual_reqs.yml:18
Task/Handler: Check if EPEL is installed for non Fedora distros

[ANSIBLE0006] rpm used in place of yum or rpm_key module
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/prereqs/tasks/install_virtual_reqs.yml:31
Task/Handler: Install EPEL for non Fedora distros

[ANSIBLE0013] Use shell only when shell functionality is required
/home/firemanxbr/GitHub/ari/contra-env-setup/playbooks/roles/prereqs/tasks/install_virtual_reqs.yml:31
Task/Handler: Install EPEL for non Fedora distros