Skip to content

Instantly share code, notes, and snippets.

@fisadev
Created May 12, 2020 16:38
Show Gist options
  • Save fisadev/343b506f2d8026156c73f5589f98cc10 to your computer and use it in GitHub Desktop.
Save fisadev/343b506f2d8026156c73f5589f98cc10 to your computer and use it in GitHub Desktop.
Bug in GithubPages for HTTPS and custom domains

Hi!

In 2018 Github Pages announced support for custom domains with HTTPS: https://github.blog/2018-05-01-github-pages-custom-domains-https/

This meant that Github had to generate certs which pointed to the custom domains the users were configuring for their pages. This worked perfectly until a few weeks ago, when all certs started to point to the default domains instead of the custom domains.

That bug breaks all the Github Pages that were using custom domains and HTTPS, because most browsers (Chrome, Firefox, Safari) now block access via HTTPS, warning the users that the sites are insecure and could steal info, etc.

Example:

https://vim.fisadev.com/

(from the repo https://github.com/fisadev/fisa-vim-config-website )

Example of what chrome says:

Example of what Firefox says:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment