code scanning

README.md

NeoMutt CodeQL Code Scanning

Last update: 2026-07-17

• Commit https://github.com/neomutt/neomutt/commit/e86aa187fbe5324b9a794136b198813af3edec96

• Issues: https://github.com/neomutt/neomutt/security/code-scanning

• How to use gh api: https://docs.github.com/en/rest/code-scanning/code-scanning?apiVersion=2022-11-28#list-code-scanning-alerts-for-a-repository

Download 1 page of 100 issues

gh api -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" "/repos/neomutt/neomutt/code-scanning/alerts?state=open&per_page=100&page=1" | json_reformat > s1.json

Export some fields

jq '.[] | .most_recent_instance.location.path,.most_recent_instance.location.start_line,.most_recent_instance.location.start_column,.number,.rule.description' s1.json > l1

Tidy the results

In Vim, edit l1 then :source tidy.vim

vim quickfix list

qf.txt

86 Issues

• 35 For loop variable changed in body
• 22 Local variable address stored in non-local memory
• 9 Long switch case
• 3 Poorly documented large function
• 3 Nested loops with same variable
• 3 Futile conditional
• 2 Time-of-check time-of-use filesystem race condition
• 2 File created without restricting permissions
• 2 Commented-out code
• 2 Cleartext transmission of sensitive information
• 1 Uncontrolled process operation
• 1 Uncontrolled data used in OS command
• 1 Inconsistent nullness check

qf.txt

ncrypt/smime.c:747:11:           2    Cleartext transmission of sensitive information
ncrypt/smime.c:782:13:           3    Cleartext transmission of sensitive information

browser/dlg_browser.c:866:7:     1457 Commented-out code
browser/dlg_browser.c:869:7:     1456 Commented-out code

maildir/message.c:586:10:        1103 File created without restricting permissions
mh/shared.c:86:10:               691  File created without restricting permissions

compose/functions.c:937:9:       187  For loop variable changed in body
compose/functions.c:949:9:       188  For loop variable changed in body
docs/makedoc.c:769:17:           1307 For loop variable changed in body
docs/makedoc.c:774:17:           1308 For loop variable changed in body
docs/makedoc.c:779:17:           1309 For loop variable changed in body
docs/makedoc.c:808:19:           1303 For loop variable changed in body
docs/makedoc.c:813:19:           1304 For loop variable changed in body
docs/makedoc.c:818:19:           1305 For loop variable changed in body
docs/makedoc.c:1224:7:           1259 For loop variable changed in body
docs/makedoc.c:1237:9:           1260 For loop variable changed in body
email/header.c:333:13:           1312 For loop variable changed in body
email/parse.c:191:17:            507  For loop variable changed in body
email/parse.c:649:5:             1467 For loop variable changed in body
email/parse.c:661:5:             1468 For loop variable changed in body
email/rfc2047.c:397:9:           1063 For loop variable changed in body
email/rfc2231.c:119:7:           571  For loop variable changed in body
email/url.c:208:9:               572  For loop variable changed in body
imap/utf7.c:121:7:               213  For loop variable changed in body
imap/utf7.c:131:27:              214  For loop variable changed in body
imap/util.c:733:11:              1183 For loop variable changed in body
mutt/buffer.c:452:20:            932  For loop variable changed in body
mutt/file.c:1384:28:             508  For loop variable changed in body
mutt/file.c:1389:11:             509  For loop variable changed in body
mutt/path.c:80:13:               217  For loop variable changed in body
mutt/slist.c:201:7:              218  For loop variable changed in body
ncrypt/functions_gpgme.c:199:7:  1471 For loop variable changed in body
ncrypt/functions_gpgme.c:216:9:  1472 For loop variable changed in body
ncrypt/functions_gpgme.c:224:11: 1473 For loop variable changed in body
ncrypt/gnupgparse.c:282:13:      223  For loop variable changed in body
ncrypt/gnupgparse.c:288:13:      224  For loop variable changed in body
ncrypt/gnupgparse.c:294:13:      225  For loop variable changed in body
ncrypt/gnupgparse.c:361:20:      226  For loop variable changed in body
ncrypt/smime.c:292:20:           231  For loop variable changed in body
nntp/complete.c:69:9:            230  For loop variable changed in body
pattern/pattern.c:99:7:          483  For loop variable changed in body

mutt/signal.c:84:3:              1330 Futile conditional
mutt/signal.c:98:5:              1329 Futile conditional
mutt/signal.c:117:3:             1328 Futile conditional

imap/imap.c:2114:35:             1474 Inconsistent nullness check

alias/dlg_alias.c:245:3:         325  Local variable address stored in non-local memory
alias/dlg_query.c:322:3:         326  Local variable address stored in non-local memory
browser/dlg_browser.c:854:3:     1130 Local variable address stored in non-local memory
browser/dlg_browser.c:855:3:     1131 Local variable address stored in non-local memory
conn/dlg_verifycert.c:174:3:     331  Local variable address stored in non-local memory
editor/window.c:336:3:           1187 Local variable address stored in non-local memory
email/parse.c:222:9:             334  Local variable address stored in non-local memory
email/rfc2231.c:234:5:           336  Local variable address stored in non-local memory
email/thread.c:112:3:            527  Local variable address stored in non-local memory
gui/thread.c:1166:5:             1298 Local variable address stored in non-local memory
history/dlg_history.c:161:3:     1475 Local variable address stored in non-local memory
imap/browse.c:164:3:             341  Local variable address stored in non-local memory
imap/browse.c:276:5:             1100 Local variable address stored in non-local memory
imap/command.c:778:3:            343  Local variable address stored in non-local memory
imap/imap.c:1499:3:              344  Local variable address stored in non-local memory
imap/imap.c:2716:5:              1465 Local variable address stored in non-local memory
mutt/notify.c:210:3:             1110 Local variable address stored in non-local memory
ncrypt/dlg_gpgme.c:237:3:        1135 Local variable address stored in non-local memory
ncrypt/dlg_pgp.c:237:3:          1133 Local variable address stored in non-local memory
ncrypt/dlg_smime.c:215:3:        1134 Local variable address stored in non-local memory
pager/dlg_pager.c:355:3:         353  Local variable address stored in non-local memory
postpone/dlg_postpone.c:262:3:   1136 Local variable address stored in non-local memory

docs/makedoc.c:621:7:            1306 Long switch case
email/parse.c:807:3:             521  Long switch case
flags.c:69:3:                    575  Long switch case
muttlib.c:138:5:                 1193 Long switch case
ncrypt/gnupgparse.c:174:5:       19   Long switch case
ncrypt/smime.c:2073:5:           20   Long switch case
notmuch/notmuch.c:1403:3:        21   Long switch case
pattern/compile.c:431:5:         23   Long switch case
pattern/compile.c:993:5:         692  Long switch case

postpone/postpone.c:220:24:      356  Nested loops with same variable
postpone/postpone.c:255:22:      357  Nested loops with same variable
postpone/postpone.c:292:16:      358  Nested loops with same variable

docs/makedoc.c:1287:13:          1454 Poorly documented large function
index/functions.c:1830:12:       1464 Poorly documented large function
key/commands.c:554:6:            1466 Poorly documented large function

mutt/file.c:168:18:              1451 Time-of-check time-of-use filesystem race condition
mutt/file.c:180:3:               6    Time-of-check time-of-use filesystem race condition

mutt/filter.c:159:36:            1327 Uncontrolled data used in OS command

send/sendmail.c:173:14:          384  Uncontrolled process operation

tidy.vim

%s/"//e
0
g/\.c$/norm Jr:Jr:A:Jr	Jr	
%!sort -t'	' -k3,3 -k1,1